Skip to contentSkip to conversation

package/tio: new package

PATCH New Sergio Prado 3 participants 6 messages Dec 22, 2019 – Dec 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/tio: new package

"tio" is a simple TTY terminal application which features a straightforward commandline interface to easily connect to TTY devices for basic input/output.

---
 DEVELOPERS            |  1 +
 package/Config.in     |  1 +
 package/tio/Config.in |  8 ++++++++
 package/tio/tio.hash  |  5 +++++
 package/tio/tio.mk    | 13 +++++++++++++
 5 files changed, 28 insertions(+)
 create mode 100644 package/tio/Config.in
 create mode 100644 package/tio/tio.hash
 create mode 100644 package/tio/tio.mk
DEVELOPERS +1 -0
index d2089e2672ce..d66f9a3bdd25 100644
@@ -2213,6 +2213,7 @@ F:	package/libgdiplus/
 F:	package/pimd/
 F:	package/snort/
 F:	package/stella/
+F:	package/tio/
 F:	package/traceroute/
 F:	package/tunctl/
 F:	package/ubus/
package/Config.in +1 -0
index 2bfec097025c..3acc93620910 100644
@@ -546,6 +546,7 @@ endmenu
 	source "package/ti-sgx-um/Config.in"
 	source "package/ti-uim/Config.in"
 	source "package/ti-utils/Config.in"
+	source "package/tio/Config.in"
 	source "package/triggerhappy/Config.in"
 	source "package/uboot-tools/Config.in"
 	source "package/ubus/Config.in"
package/tio/Config.in new file +8 -0
new file mode 100644
index 000000000000..6c748c5d12a1
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_TIO
+	bool "tio"
+	help
+	  "tio" is a simple TTY terminal application which features a
+	  straightforward commandline interface to easily connect to
+	  TTY devices for basic input/output.
+
+	  https://tio.github.io/
package/tio/tio.hash new file +5 -0
new file mode 100644
index 000000000000..3053bd1bf085
@@ -0,0 +1,5 @@
+# Locally computed:
+sha256 a8f5ed6994cacb96780baa416b19e5a6d7d67e8c162a8ea4fd9eccd64984ae44  tio-1.32.tar.xz
+
+# Hash for license files:
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
package/tio/tio.mk new file +13 -0
new file mode 100644
index 000000000000..dcddea7fd9b9
@@ -0,0 +1,13 @@
+################################################################################
+#
+# tio
+#
+################################################################################
+
+TIO_VERSION = 1.32
+TIO_SOURCE = tio-$(TIO_VERSION).tar.xz
+TIO_SITE = https://github.com/tio/tio/releases/download/v$(TIO_VERSION)
+TIO_LICENSE = GPLv2
+TIO_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/tio: new package

Hi Sergio,

Quoted 71 lines · Sergio Prado

"tio" is a simple TTY terminal application which features a straightforward commandline interface to easily connect to TTY devices for basic input/output.

---
 DEVELOPERS            |  1 +
 package/Config.in     |  1 +
 package/tio/Config.in |  8 ++++++++
 package/tio/tio.hash  |  5 +++++
 package/tio/tio.mk    | 13 +++++++++++++
 5 files changed, 28 insertions(+)
 create mode 100644 package/tio/Config.in
 create mode 100644 package/tio/tio.hash
 create mode 100644 package/tio/tio.mk
DEVELOPERS +1 -0
index d2089e2672ce..d66f9a3bdd25 100644
@@ -2213,6 +2213,7 @@ F:	package/libgdiplus/
 F:	package/pimd/
 F:	package/snort/
 F:	package/stella/
+F:	package/tio/
 F:	package/traceroute/
 F:	package/tunctl/
 F:	package/ubus/
package/Config.in +1 -0
index 2bfec097025c..3acc93620910 100644
@@ -546,6 +546,7 @@ endmenu
 	source "package/ti-sgx-um/Config.in"
 	source "package/ti-uim/Config.in"
 	source "package/ti-utils/Config.in"
+	source "package/tio/Config.in"
 	source "package/triggerhappy/Config.in"
 	source "package/uboot-tools/Config.in"
 	source "package/ubus/Config.in"
package/tio/Config.in new file +8 -0
new file mode 100644
index 000000000000..6c748c5d12a1
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_TIO
+	bool "tio"
+	help
+	  "tio" is a simple TTY terminal application which features a
+	  straightforward commandline interface to easily connect to
+	  TTY devices for basic input/output.
+
+	  https://tio.github.io/
package/tio/tio.hash new file +5 -0
new file mode 100644
index 000000000000..3053bd1bf085
@@ -0,0 +1,5 @@
+# Locally computed:
+sha256 a8f5ed6994cacb96780baa416b19e5a6d7d67e8c162a8ea4fd9eccd64984ae44  tio-1.32.tar.xz
+
+# Hash for license files:
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
package/tio/tio.mk new file +0 -0
new file mode 100644
index 000000000000..dcddea7fd9b9

package/tio/tio.mk line 10

Quoted 10 lines
package/tio/tio.mk new file +10 -0
@@ -0,0 +1,13 @@
+################################################################################
+#
+# tio
+#
+################################################################################
+
+TIO_VERSION = 1.32
+TIO_SOURCE = tio-$(TIO_VERSION).tar.xz
+TIO_SITE = https://github.com/tio/tio/releases/download/v$(TIO_VERSION)
+TIO_LICENSE = GPLv2

The LICENSE file has the "or any later version" language. Also, we prefer the SPDX license identifiers. So "GPL-2.0+".

package/tio/tio.mk line 11

Quoted 1 line
package/tio/tio.mk new file +1 -0
+TIO_LICENSE_FILES = COPYING

Should also add "LICENSE".

package/tio/tio.mk line 13

Quoted 1 line
package/tio/tio.mk new file +1 -0
+$(eval $(autotools-package))

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 package/tio: new package

Quoted 4 lines · On Mon, 23 Dec 2019 07:51:02 +0200 Baruch Siach <[email protected]> wrote:
Quoted 1 line

+TIO_LICENSE = GPLv2

The LICENSE file has the "or any later version" language. Also, we prefer the SPDX license identifiers. So "GPL-2.0+".

Fixed when applying.

Quoted 3 lines
Quoted 1 line

+TIO_LICENSE_FILES = COPYING

Should also add "LICENSE".

There was no file named "LICENSE" in the source code, so I'm not sure what your suggestion was. Did you suggest to add README instead maybe ?

Thanks for the review, it's definitely a lot easier when a well-known contributor like you has reviewed a patch.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/tio: new package

Hi Thomas,

Quoted 8 lines · Thomas Petazzoni
Quoted 4 lines · On Mon, 23 Dec 2019 07:51:02 +0200 Baruch Siach <[email protected]> wrote:
Quoted 1 line

+TIO_LICENSE = GPLv2

The LICENSE file has the "or any later version" language. Also, we prefer the SPDX license identifiers. So "GPL-2.0+".

Quoted 8 lines

Fixed when applying.

Quoted 3 lines
Quoted 1 line

+TIO_LICENSE_FILES = COPYING

Should also add "LICENSE".

There was no file named "LICENSE" in the source code, so I'm not sure what your suggestion was. Did you suggest to add README instead maybe ?

Is see this here:

https://github.com/tio/tio/blob/master/LICENSE

According to the log this file has been there since 2016.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#4 lore raw

PATCH 1/1 package/tio: new package

Quoted 8 lines · On Tue, 24 Dec 2019 15:38:32 +0200 Baruch Siach <[email protected]> wrote:
Quoted 2 lines

There was no file named "LICENSE" in the source code, so I'm not sure what your suggestion was. Did you suggest to add README instead maybe ?

Is see this here:

https://github.com/tio/tio/blob/master/LICENSE

According to the log this file has been there since 2016.

It is not in the tarball as far as I can see:

$ tar tvf tio-1.32.tar.xz | grep LICENSE
$

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/1 package/tio: new package

In reply to Sergio Prado
Quoted 5 lines · On Sun, 22 Dec 2019 19:12:03 -0300 Sergio Prado <[email protected]>…

"tio" is a simple TTY terminal application which features a straightforward commandline interface to easily connect to TTY devices for basic input/output.

Quoted 10 lines
---
 DEVELOPERS            |  1 +
 package/Config.in     |  1 +
 package/tio/Config.in |  8 ++++++++
 package/tio/tio.hash  |  5 +++++
 package/tio/tio.mk    | 13 +++++++++++++
 5 files changed, 28 insertions(+)
 create mode 100644 package/tio/Config.in
 create mode 100644 package/tio/tio.hash
 create mode 100644 package/tio/tio.mk

Applied to master after adjusting TIO_LICENSE to GPL-2.0+, as noticed by Baruch. Nice little program BTW, the automatic reconnect to USB serial devices can be quite useful.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com