Skip to contentSkip to conversation

base.bbclass: clean up dead symlink when handling hosttools

PATCH New Chen Qi 1 participant 1 message Dec 25, 2019

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

PATCH 1/1 base.bbclass: clean up dead symlink when handling hosttools

When some hosttool is a dead symlink, bitbake any recipe will fail with error like below.

FileExistsError: [Errno 17] File exists: '/usr/bin/chrpath' -> '/path/to/builddir/tmp-glibc/hosttools/chrpath'

So we remove dead symlink under hostools/ directory to avoid such error.

---
 meta/classes/base.bbclass | 3 +++
 1 file changed, 3 insertions(+)
meta/classes/base.bbclass +3 -0
index 2fdab74f4b..3db8527d04 100644
@@ -127,6 +127,9 @@ def setup_hosttools_dir(dest, toolsvar, d, fatal=True):
     for tool in tools:
         desttool = os.path.join(dest, tool)
         if not os.path.exists(desttool):
+            # clean up dead symlink
+            if os.path.islink(desttool):
+                os.unlink(desttool)
             srctool = bb.utils.which(path, tool, executable=True)
             # gcc/g++ may link to ccache on some hosts, e.g.,
             # /usr/local/bin/ccache/gcc -> /usr/bin/ccache, then which(gcc)
Signature · 1 line
2.17.1