serial_ir: change "ignoring spike" to debug level
Subsystems (3)
PATCH 1/1 serial_ir: change "ignoring spike" to debug level
At least on my system with a self-made IR receiver, my kernel log is filled with:serial_ir serial_ir.0: ignoring spike: 1 1 1419988034627194ns 1419956080709377ns
These messages happen at random and do not prevent the receiver from working. Also I cannot change the features of the IC, therefore they are not useful. Probably they are not useful at all.
However they fill the console, they accumulate and fill the dmesg log, by doing this, they prevent me from seeing important message.
--- drivers/media/rc/serial_ir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/serial_ir.c +1 -1
@@ -353,7 +353,7 @@ static irqreturn_t serial_ir_irq_handler(int i, void *blah) dcd = (status & hardware[type].signal_pin) ?1 :0 ;if (dcd == last_dcd) { -dev_err (&serial_ir.pdev->dev, +dev_dbg (&serial_ir.pdev->dev,"ignoring spike: %d %d %lldns %lldns\n" , dcd, sense,ktime_to_ns (kt),ktime_to_ns (serial_ir.lastkt));
Signature · 1 line
2.24.0
Sean Young
maintainerHi,
Quoted 9 lines · Bodo Eggert
At least on my system with a self-made IR receiver, my kernel log is filled with:
serial_irserial_ir.0: ignoring spike: 1 1 1419988034627194ns 1419956080709377nsThese messages happen at random and do not prevent the receiver from working. Also I cannot change the features of the IC, therefore they are not useful. Probably they are not useful at all.
However they fill the console, they accumulate and fill the dmesg log, by doing this, they prevent me from seeing important message.
I think this patch is right, but it needs a Signed-off-by: line.
See:
Thanks,
Sean
Quoted 19 lines
--- drivers/media/rc/serial_ir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/rc/serial_ir.c +1
-1@@ -353,7 +353,7 @@ static irqreturn_t serial_ir_irq_handler(int i, void *blah) dcd = (status & hardware[type].signal_pin) ?1 :0 ;if (dcd == last_dcd) { -dev_err (&serial_ir.pdev->dev, +dev_dbg (&serial_ir.pdev->dev,"ignoring spike: %d %d %lldns %lldns\n" , dcd, sense,ktime_to_ns (kt),ktime_to_ns (serial_ir.lastkt));Signature · 1 line
2.24.0
PATCH 1/1 serial_ir: change "ignoring spike" to debug level
At least on my system with a self-made IR receiver, my kernel log is filled with:serial_ir serial_ir.0: ignoring spike: 1 1 1419988034627194ns 1419956080709377ns
These messages happen at random and do not prevent the receiver from working. Also I cannot change the features of the IC, therefore they are not useful. Probably they are not useful at all.
However they fill the console, they accumulate and fill the dmesg log, by doing this, they prevent me from seeing important message.
--- drivers/media/rc/serial_ir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/serial_ir.c +1 -1
@@ -353,7 +353,7 @@ static irqreturn_t serial_ir_irq_handler(int i, void *blah) dcd = (status & hardware[type].signal_pin) ?1 :0 ;if (dcd == last_dcd) { -dev_err (&serial_ir.pdev->dev, +dev_dbg (&serial_ir.pdev->dev,"ignoring spike: %d %d %lldns %lldns\n" , dcd, sense,ktime_to_ns (kt),ktime_to_ns (serial_ir.lastkt));
Signature · 1 line
2.24.0