Skip to contentSkip to conversation

package/lvm2: install udev rules

PATCH New Pascal de Bruijn 2 participants 2 messages Dec 3, 2019 – Dec 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lvm2: install udev rules

Without the device-mapper udev rules, dm devices will not get a proper symlink like /dev/disk/by-label/LABEL, which in turn causes fstab LABEL= mounts to fails.

And by extension causes shenanigans with systemd, where it will unmount a manually mounted disk because it can't resolve the label.

---
 package/lvm2/lvm2.mk | 1 +
 1 file changed, 1 insertion(+)
package/lvm2/lvm2.mk +1 -0
index 7fdb9a7..65576f4 100644
@@ -19,6 +19,7 @@ LVM2_CONF_OPTS += \
 	--enable-pkgconfig \
 	--enable-cmdlib \
 	--enable-dmeventd \
+	--enable-udev_rules \
 	--disable-nls \
 	--disable-symvers
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/lvm2: install udev rules

Hello Pascal,

Quoted 17 lines · On Tue, 3 Dec 2019 10:00:50 +0100 Pascal de Bruijn <[email protected]>…

Without the device-mapper udev rules, dm devices will not get a proper symlink like /dev/disk/by-label/LABEL, which in turn causes fstab LABEL= mounts to fails.

And by extension causes shenanigans with systemd, where it will unmount a manually mounted disk because it can't resolve the label.

---
 package/lvm2/lvm2.mk | 1 +
 1 file changed, 1 insertion(+)
package/lvm2/lvm2.mk +0 -0
index 7fdb9a7..65576f4 100644

package/lvm2/lvm2.mk LVM2_CONF_OPTS += \ · line 22

Quoted 4 lines
package/lvm2/lvm2.mk +1 -0
@@ -19,6 +19,7 @@ LVM2_CONF_OPTS += \
 	--enable-pkgconfig \
 	--enable-cmdlib \
 	--enable-dmeventd \
+	--enable-udev_rules \

Why should this be done unconditionally ? Shouldn't instead this be:

ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
LVM2_CONF_OPTS += --enable-udev_rules
endif

instead ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com