Skip to contentSkip to conversation

package/postgresql: explicitly use en_US.UTF-8 locale for initdb

PATCH New Pascal de Bruijn 3 participants 3 messages Nov 21, 2019 – Dec 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/postgresql: explicitly use en_US.UTF-8 locale for initdb

From: Pascal de Bruijn <[email protected]>

postgres[290]: initdb: error: invalid locale settings; check LANG and LC_* environment variables postgres[290]: pg_ctl: database system initialization failed

---
 package/postgresql/Config.in          | 2 ++
 package/postgresql/S50postgresql      | 2 +-
 package/postgresql/postgresql.service | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)
package/postgresql/Config.in +2 -0
index e548d3c..e912249 100644
@@ -17,6 +17,8 @@ config BR2_PACKAGE_POSTGRESQL
 	  Enable the zlib package to gain builtin compression for
 	  archives with pg_dump and pg_restore.
 
+	  NOTE: PostgreSQL needs a working en_US.UTF-8 locale (BR2_GENERATE_LOCALE)
+
 	  http://www.postgresql.org
 
 comment "postgresql needs a toolchain w/ dynamic library, wchar"
package/postgresql/S50postgresql +1 -1
index 1ece4fc..3c0c520 100644
@@ -7,7 +7,7 @@ umask 077
 
 if [ ! -f /var/lib/pgsql/PG_VERSION ]; then
 	echo "Initializing postgresql data base..."
-	su - postgres -c '/usr/bin/pg_ctl initdb -D /var/lib/pgsql'
+	su - postgres -c '/usr/bin/pg_ctl initdb -D /var/lib/pgsql -o --locale=en_US.UTF-8'
 	echo "done"
 fi
 
package/postgresql/postgresql.service +1 -1
index 53e6f84..4bbe742 100644
@@ -17,7 +17,7 @@ StandardError=syslog
 SyslogIdentifier=postgres
 PIDFile=/var/lib/pgsql/postmaster.pid
 
-ExecStartPre=/bin/sh -c "if [ ! -f /var/lib/pgsql/PG_VERSION ]; then /usr/bin/pg_ctl initdb -D /var/lib/pgsql; fi"
+ExecStartPre=/bin/sh -c "if [ ! -f /var/lib/pgsql/PG_VERSION ]; then /usr/bin/pg_ctl initdb -D /var/lib/pgsql -o --locale=en_US.UTF-8; fi"
 ExecStart=/usr/bin/postgres -D /var/lib/pgsql
 ExecReload=/usr/bin/kill -HUP $MAINPID
 KillMode=mixed
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/2 package/postgresql: explicitly use en_US.UTF-8 locale for initdb

Hello Pascal,

Quoted 4 lines · Pascal de Bruijn

From: Pascal de Bruijn <[email protected]>

postgres[290]: initdb: error: invalid locale settings; check LANG and LC_* environment variables postgres[290]: pg_ctl: database system initialization failed

Thanks for the patch, but tested with raspberrypi3_64_defconfig (and changed to glibc), my output is:

[...]
The database cluster will be initialized with locale "C". The default database encoding has accordingly been set to "SQL_ASCII". The default text search configuration will be set to "english". [...]
performing post-bootstrap initialization ... sh: locale: not found

1970-01-01 00:00:16.233 UTC [206] WARNING:  no usable system locales were found

ok
[...]
Success. You can now start the database server using:
[...]

No need for an (additional) locale with my setup (and the warning is, after a quick look at the source code postgresql-12.1/src/backend/commands/collationcmds.c, about the missing locale command on the target, nothing your patch can fix)...

Can you provide your failing defconfig file?

Regards,
Peter

Quoted 47 lines
---
 package/postgresql/Config.in          | 2 ++
 package/postgresql/S50postgresql      | 2 +-
 package/postgresql/postgresql.service | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)
package/postgresql/Config.in renamed from package/postgresql/Config.in./host/aarch64-buildroot-linux-gnu/sysroot/usr/bin/locale +2 -0
index e548d3c..e912249 100644
@@ -17,6 +17,8 @@ config BR2_PACKAGE_POSTGRESQL
 	  Enable the zlib package to gain builtin compression for
 	  archives with pg_dump and pg_restore.
 
+	  NOTE: PostgreSQL needs a working en_US.UTF-8 locale (BR2_GENERATE_LOCALE)
+
 	  http://www.postgresql.org
 
 comment "postgresql needs a toolchain w/ dynamic library, wchar"
package/postgresql/S50postgresql +1 -1
index 1ece4fc..3c0c520 100644
@@ -7,7 +7,7 @@ umask 077
 
 if [ ! -f /var/lib/pgsql/PG_VERSION ]; then
 	echo "Initializing postgresql data base..."
-	su - postgres -c '/usr/bin/pg_ctl initdb -D /var/lib/pgsql'
+	su - postgres -c '/usr/bin/pg_ctl initdb -D /var/lib/pgsql -o --locale=en_US.UTF-8'
 	echo "done"
 fi
 
package/postgresql/postgresql.service +1 -1
index 53e6f84..4bbe742 100644
@@ -17,7 +17,7 @@ StandardError=syslog
 SyslogIdentifier=postgres
 PIDFile=/var/lib/pgsql/postmaster.pid
 
-ExecStartPre=/bin/sh -c "if [ ! -f /var/lib/pgsql/PG_VERSION ]; then /usr/bin/pg_ctl initdb -D /var/lib/pgsql; fi"
+ExecStartPre=/bin/sh -c "if [ ! -f /var/lib/pgsql/PG_VERSION ]; then /usr/bin/pg_ctl initdb -D /var/lib/pgsql -o --locale=en_US.UTF-8; fi"
 ExecStart=/usr/bin/postgres -D /var/lib/pgsql
 ExecReload=/usr/bin/kill -HUP $MAINPID
 KillMode=mixed
#2 lore raw

PATCH 1/2 package/postgresql: explicitly use en_US.UTF-8 locale for initdb

In reply to Pascal de Bruijn

Hello Pascal,

Quoted 6 lines · On Thu, 21 Nov 2019 11:15:38 +0100 Pascal de Bruijn <[email protected]>…

From: Pascal de Bruijn <[email protected]>

postgres[290]: initdb: error: invalid locale settings; check LANG and LC_* environment variables postgres[290]: pg_ctl: database system initialization failed

Following the feedback from Peter Seiderer on both patches, I marked them as "Changes Requested" in patchwork. Could you reply to Peter's comments, or resend updated patches ?

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com