Skip to contentSkip to conversation

Removing a dead definition or RSB_FILL_LOOPS

PATCH Applied Anthony Steinhauser 2 participants 2 messages Dec 26, 2019 – Jan 2, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Removing a dead definition or RSB_FILL_LOOPS

It is never used, but it is misleading.

---
 arch/x86/include/asm/nospec-branch.h | 1 -
 1 file changed, 1 deletion(-)
arch/x86/include/asm/nospec-branch.h +0 -1
index 5c24a7b35166..07e95dcb40ad 100644
@@ -37,7 +37,6 @@
  */
 
 #define RSB_CLEAR_LOOPS		32	/* To forcibly overwrite all entries */
-#define RSB_FILL_LOOPS		16	/* To avoid underflow */
 
 /*
  * Google experimented with loop-unrolling and this turned out to be
Signature · 1 line
2.24.1.735.g03f4e72817-goog
#1 lore raw

[tip: x86/cleanups] x86/nospec: Remove unused RSB_FILL_LOOPS

The following commit has been merged into the x86/cleanups branch of tip:

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     fae7bfcc78146057ac2730719de8d5e41de19540
Gitweb:        https://git.kernel.org/tip/fae7bfcc78146057ac2730719de8d5e41de19540
Author:        Anthony Steinhauser <[email protected]>
AuthorDate:    Thu, 26 Dec 2019 12:45:12 -08:00
Committer:     Borislav Petkov <[email protected]>
CommitterDate: Thu, 02 Jan 2020 10:54:53 +01:00

x86/nospec: Remove unused RSB_FILL_LOOPS

It was never really used, see

117cc7a908c8 ("x86/retpoline: Fill return stack buffer on vmexit")

[ bp: Massage. ]

---
 arch/x86/include/asm/nospec-branch.h | 1 -
 1 file changed, 1 deletion(-)
arch/x86/include/asm/nospec-branch.h +0 -1
index 5c24a7b..07e95dc 100644
@@ -37,7 +37,6 @@
  */
 
 #define RSB_CLEAR_LOOPS		32	/* To forcibly overwrite all entries */
-#define RSB_FILL_LOOPS		16	/* To avoid underflow */
 
 /*
  * Google experimented with loop-unrolling and this turned out to be