Documentation: fs: Fix warnings
Subsystems (2)
PATCH 1/1 Documentation: fs: Fix warnings
From: "Daniel W. S. Almeida" <[email protected]>
Fix the following warnings:
fs/debugfs/inode.c:423: WARNING: Inline literal start-string without end-string. fs/debugfs/inode.c:502: WARNING: Inline literal start-string without end-string. fs/debugfs/inode.c:534: WARNING: Inline literal start-string without end-string. fs/debugfs/inode.c:627: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:496: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:502: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:581: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:587: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:846: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:852: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:899: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:905: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:1091: WARNING: Inline literal start-string without end-string. fs/debugfs/file.c:1097: WARNING: Inline literal start-string without end-string
By replacing %ERR_PTR with ERR_PTR.
--- fs/debugfs/file.c | 21 ++++++++++----------- fs/debugfs/inode.c | 9 ++++----- 2 files changed, 14 insertions(+), 16 deletions(-)
fs/debugfs/file.c +10 -11
@@ -496,10 +496,10 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_u32_wo, NULL, debugfs_u32_set, "%llu\n");* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the file is * to be removed (no automatic cleanup happens if your module is unloaded, -* you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) will be +* you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be * returned. * -* If debugfs is not enabled in the kernel, the value %ERR_PTR(-ENODEV) will +* If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will * be returned. */ struct dentry *debugfs_create_u32(const char *name, umode_t mode,
@@ -581,10 +581,10 @@ DEFINE_DEBUGFS_ATTRIBUTE(fops_ulong_wo, NULL, debugfs_ulong_set, "%llu\n");* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the file is * to be removed (no automatic cleanup happens if your module is unloaded, -* you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) will be +* you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be * returned. * -* If debugfs is not enabled in the kernel, the value %ERR_PTR(-ENODEV) will +* If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will * be returned. */ struct dentry *debugfs_create_ulong(const char *name, umode_t mode,
@@ -846,10 +846,10 @@ static const struct file_operations fops_bool_wo = {* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the file is * to be removed (no automatic cleanup happens if your module is unloaded, -* you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) will be +* you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be * returned. * -* If debugfs is not enabled in the kernel, the value %ERR_PTR(-ENODEV) will +* If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will * be returned. */ struct dentry *debugfs_create_bool(const char *name, umode_t mode,
@@ -899,10 +899,10 @@ static const struct file_operations fops_blob = {* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the file is * to be removed (no automatic cleanup happens if your module is unloaded, -* you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) will be +* you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be * returned. * -* If debugfs is not enabled in the kernel, the value %ERR_PTR(-ENODEV) will +* If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will * be returned. */ struct dentry *debugfs_create_blob(const char *name, umode_t mode,
@@ -1091,10 +1091,10 @@ static const struct file_operations fops_regset32 = {* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the file is * to be removed (no automatic cleanup happens if your module is unloaded, -* you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) will be +* you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be * returned. * -* If debugfs is not enabled in the kernel, the value %ERR_PTR(-ENODEV) will +* If debugfs is not enabled in the kernel, the value ERR_PTR(-ENODEV) will * be returned. */ struct dentry *debugfs_create_regset32(const char *name, umode_t mode,
@@ -1158,4 +1158,3 @@ struct dentry *debugfs_create_devm_seqfile(struct device *dev, const char *name, &debugfs_devm_entry_ops); }EXPORT_SYMBOL_GPL (debugfs_create_devm_seqfile); -
fs/debugfs/inode.c +4 -5
@@ -423,7 +423,7 @@ static struct dentry *__debugfs_create_file(const char *name, umode_t mode,* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the file is * to be removed (no automatic cleanup happens if your module is unloaded, -* you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) will be +* you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be * returned. * * If debugfs is not enabled in the kernel, the value -%ENODEV will be
@@ -502,7 +502,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_file_unsafe);* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the file is * to be removed (no automatic cleanup happens if your module is unloaded, -* you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) will be +* you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be * returned. * * If debugfs is not enabled in the kernel, the value -%ENODEV will be
@@ -534,7 +534,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_file_size);* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the file is * to be removed (no automatic cleanup happens if your module is unloaded, -* you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) will be +* you are responsible here.) If an error occurs, ERR_PTR(-ERROR) will be * returned. * * If debugfs is not enabled in the kernel, the value -%ENODEV will be
@@ -627,7 +627,7 @@ EXPORT_SYMBOL(debugfs_create_automount);* This function will return a pointer to a dentry if it succeeds. This * pointer must be passed to the debugfs_remove() function when the symbolic * link is to be removed (no automatic cleanup happens if your module is -* unloaded, you are responsible here.) If an error occurs, %ERR_PTR(-ERROR) +* unloaded, you are responsible here.) If an error occurs, ERR_PTR(-ERROR) * will be returned. * * If debugfs is not enabled in the kernel, the value -%ENODEV will be
@@ -906,4 +906,3 @@ static int __init debugfs_init(void)return retval; }core_initcall (debugfs_init); -
Signature · 6 lines
2.24.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
PATCH 1/1 fs: posix-acl.c: Fix warnings
From: "Daniel W. S. Almeida" <[email protected]>
Fix the following warning
/fs/posix_acl.c:636: WARNING: Inline emphasis start-string without end-string.
By escaping a character.
--- fs/posix_acl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
fs/posix_acl.c +3 -3
@@ -634,7 +634,7 @@ EXPORT_SYMBOL_GPL(posix_acl_create);* * Update the file mode when setting an ACL: compute the new file permission * bits based on the ACL. In addition, if the ACL is equivalent to the new -* file mode, set *acl to NULL to indicate that no ACL should be set. +* file mode, set \*acl to NULL to indicate that no ACL should be set. * * As with chmod, clear the setgit bit if the caller is not in the owning group * or capable of CAP_FSETID (see inode_change_ok).
@@ -743,12 +743,12 @@ posix_acl_from_xattr(struct user_namespace *user_ns,return ERR_PTR (-EINVAL );if (count ==0 )return NULL ; - + acl =posix_acl_alloc (count,GFP_NOFS );if (!acl)return ERR_PTR (-ENOMEM ); acl_e = acl->a_entries; - +for (end = entry + count; entry != end; acl_e++, entry++) { acl_e->e_tag =le16_to_cpu (entry->e_tag); acl_e->e_perm =le16_to_cpu (entry->e_perm);
Signature · 1 line
2.24.1
PATCH 1/1 fs: seq_file.c: Fix warnings
In reply to Daniel W. S. AlmeidaFrom: "Daniel W. S. Almeida" <[email protected]>
Fix the following warnings:
fs/seq_file.c:40: WARNING: Inline strong start-string without end-string. fs/seq_file.c:40: WARNING: Inline strong start-string without end-string. fs/seq_file.c:40: WARNING: Inline strong start-string without end-string. fs/seq_file.c:40: WARNING: Inline strong start-string without end-string
By escaping the parenthesis in the affected line. Line breaks were added for clarity.
--- fs/seq_file.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
fs/seq_file.c +12 -4
@@ -38,10 +38,18 @@ static void *seq_buf_alloc(unsigned long size)* @op: method table describing the sequence * * seq_open() sets @file, associating it with a sequence described -* by @op. @op->start() sets the iterator up and returns the first -* element of sequence. @op->stop() shuts it down. @op->next() -* returns the next element of sequence. @op->show() prints element -* into the buffer. In case of error ->start() and ->next() return +* by @op. +* +* @op->start\(\) sets the iterator up and returns the first +* element of sequence. +* +* @op->stop\(\) shuts it down. +* +* @op->next\(\) returns the next element of sequence. +* +* @op->show\(\) prints element into the buffer. +* +* In case of error ->start() and ->next() return * ERR_PTR(error). In the end of sequence they return %NULL. ->show() * returns 0 in case of success and negative number in case of error. * Returning SEQ_SKIP means "discard this element and move on".
Signature · 6 lines
2.24.1 _______________________________________________ Linux-kernel-mentees mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees