net: dsa: sja1105: Really make the PTP command read-write
Vladimir Oltean
maintainerPATCH 1/1 net: dsa: sja1105: Really make the PTP command read-write
When activating tc-taprio offload on the switch ports, the TAS state machine will try to check whether it is running or not, but will find both the STARTED and STOPPED bits as false in the sja1105_tas_check_running function. So the function will return -EINVAL (an abnormal situation) and the kernel will keep printing this from the TAS FSM workqueue:
[ 37.691971] sja1105 spi0.1: An operation returned -22
The reason is that the underlying function that gets called, sja1105_ptp_commit, does not actually do a SPI_READ, but a SPI_WRITE. So the command buffer remains initialized with zeroes instead of retrieving the hardware state. Fix that.
--- drivers/net/dsa/sja1105/sja1105_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/dsa/sja1105/sja1105_ptp.c +1 -1
@@ -237,7 +237,7 @@ int sja1105_ptp_commit(struct dsa_switch *ds, struct sja1105_ptp_cmd *cmd,if (rw ==SPI_WRITE ) priv->info->ptp_cmd_packing (buf, cmd,PACK ); - rc =sja1105_xfer_buf (priv,SPI_WRITE , regs->ptp_control, buf, + rc =sja1105_xfer_buf (priv, rw, regs->ptp_control, buf,SJA1105_SIZE_PTP_CMD );if (rw ==SPI_READ )
Signature · 1 line
2.17.1
From: Vladimir Oltean <[email protected]>
Date: Fri, 27 Dec 2019 03:01:50 +0200
Quoted 9 lines
When activating tc-taprio offload on the switch ports, the TAS state machine will try to check whether it is running or not, but will find both the STARTED and STOPPED bits as false in the
sja1105_tas_check_runningfunction. So the function will return-EINVAL(an abnormal situation) and the kernel will keep printing this from the TAS FSM workqueue:[ 37.691971] sja1105 spi0.1: An operation returned -22
Quoted 7 lines
The reason is that the underlying function that gets called,
sja1105_ptp_commit, does not actually do aSPI_READ, but aSPI_WRITE. So the command buffer remains initialized with zeroes instead of retrieving the hardware state. Fix that.Fixes 41603d78b362 ("net: dsa: sja1105: Make the PTP command read-write")Signed-off-by Vladimir Oltean <[email protected]>
Applied, thanks.