Skip to contentSkip to conversation

imx8m: ddr_init: Move ddr_init() messages to debug level

PATCH New Fabio Estevam 3 participants 3 messages Dec 11, 2019 – Dec 28, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 imx8m: ddr_init: Move ddr_init() messages to debug level

Currently inside ddr_init() there is a mix of printf() and debug() level messages.

Since this type of information is useful for debug purposes, convert all of them to debug level for consistency.

---
 drivers/ddr/imx/imx8m/ddr_init.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/ddr/imx/imx8m/ddr_init.c +3 -3
index d6e915c9b9..21af66e4e7 100644
@@ -24,7 +24,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
 {
 	unsigned int tmp, initial_drate, target_freq;
 
-	printf("DDRINFO: start DRAM init\n");
+	debug("DDRINFO: start DRAM init\n");
 
 	/* Step1: Follow the power up procedure */
 	if (is_imx8mq()) {
@@ -109,7 +109,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
 		tmp = reg32_read(DDRPHY_CalBusy(0));
 	} while ((tmp & 0x1));
 
-	printf("DDRINFO:ddrphy calibration done\n");
+	debug("DDRINFO:ddrphy calibration done\n");
 
 	/* Step15: Set SWCTL.sw_done to 0 */
 	reg32_write(DDRC_SWCTL(0), 0x00000000);
@@ -161,7 +161,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
 
 	/* enable port 0 */
 	reg32_write(DDRC_PCTRL_0(0), 0x00000001);
-	printf("DDRINFO: ddrmix config done\n");
+	debug("DDRINFO: ddrmix config done\n");
 
 	/* save the dram timing config into memory */
 	dram_config_save(dram_timing, CONFIG_SAVED_DRAM_TIMING_BASE);
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx8m: ddr_init: Move ddr_init() messages to debug level

Quoted 8 lines

Subject: [PATCH] imx8m: ddr_init: Move ddr_init() messages to debug level

Currently inside ddr_init() there is a mix of printf() and debug() level messages.

Since this type of information is useful for debug purposes, convert all of them to debug level for consistency.

Quoted 38 lines
---
 drivers/ddr/imx/imx8m/ddr_init.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/ddr/imx/imx8m/ddr_init.c +2 -2
index d6e915c9b9..21af66e4e7 100644
@@ -24,7 +24,7 @@ void ddr_init(struct dram_timing_info *dram_timing)  {
 	unsigned int tmp, initial_drate, target_freq;
 
-	printf("DDRINFO: start DRAM init\n");
+	debug("DDRINFO: start DRAM init\n");
 
 	/* Step1: Follow the power up procedure */
 	if (is_imx8mq()) {
@@ -109,7 +109,7 @@ void ddr_init(struct dram_timing_info *dram_timing)
 		tmp = reg32_read(DDRPHY_CalBusy(0));
 	} while ((tmp & 0x1));
 
-	printf("DDRINFO:ddrphy calibration done\n");
+	debug("DDRINFO:ddrphy calibration done\n");
 
 	/* Step15: Set SWCTL.sw_done to 0 */
 	reg32_write(DDRC_SWCTL(0), 0x00000000); @@ -161,7 +161,7 @@

void ddr_init(struct dram_timing_info *dram_timing)

drivers/ddr/imx/imx8m/ddr_init.c +1 -1
 	/* enable port 0 */
 	reg32_write(DDRC_PCTRL_0(0), 0x00000001);
-	printf("DDRINFO: ddrmix config done\n");
+	debug("DDRINFO: ddrmix config done\n");
 
 	/* save the dram timing config into memory */
 	dram_config_save(dram_timing,

CONFIG_SAVED_DRAM_TIMING_BASE);
--
2.17.1

#2 lore raw

PATCH 1/1 imx8m: ddr_init: Move ddr_init() messages to debug level

In reply to Fabio Estevam
Quoted 6 lines

Currently inside ddr_init() there is a mix of printf() and debug() level messages.
Since this type of information is useful for debug purposes, convert all of them to debug level for consistency.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================