lib: devres: provide devm_ioremap_resource_nocache()
Subsystems (3)
PATCH 1/2 lib: devres: provide devm_ioremap_resource_nocache()
Provide a variant of devm_ioremap_resource() for nocache ioremap.
--- Documentation/driver-api/driver-model/devres.rst | 1 + include/linux/device.h | 2 ++ lib/devres.c | 15 +++++++++++++++ 3 files changed, 18 insertions(+)
Documentation/driver-api/driver-model/devres.rst +1 -0
@@ -317,6 +317,7 @@ IOMAP devm_ioremap_uc() devm_ioremap_wc() devm_ioremap_resource() : checks resource, requests memory region, ioremaps + devm_ioremap_resource_nocache() devm_ioremap_resource_wc() devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device devm_platform_ioremap_resource_wc()
include/linux/device.h +2 -0
@@ -962,6 +962,8 @@ extern void devm_free_pages(struct device *dev, unsigned long addr);void __iomem *devm_ioremap_resource (struct device *dev,const struct resource *res); +void __iomem *devm_ioremap_resource_nocache (struct device *dev, +const struct resource *res);void __iomem *devm_ioremap_resource_wc (struct device *dev,const struct resource *res);
lib/devres.c +15 -0
@@ -188,6 +188,21 @@ void __iomem *devm_ioremap_resource(struct device *dev, }EXPORT_SYMBOL (devm_ioremap_resource); +/** +* devm_ioremap_resource_nocache() - nocache variant of +* devm_ioremap_resource() +* @dev: generic device to handle the resource for +* @res: resource to be handled +* +* Returns a pointer to the remapped memory or an ERR_PTR() encoded error code +* on failure. +*/ +void __iomem *devm_ioremap_resource_nocache (struct device *dev, +const struct resource *res) +{ +return __devm_ioremap_resource (dev, res,DEVM_IOREMAP_NC ); +} +/** * devm_ioremap_resource_wc() - write-combined variant of * devm_ioremap_resource()
Signature · 1 line
2.17.1
PATCH 1/1 platform: goldfish: pipe: switch to platform_get_irq
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for requesting IRQ's resources, as they can be not ready yet. Using platform_get_irq() instead is preferred for getting IRQ even if it was not retrieved earlier.
--- drivers/platform/goldfish/goldfish_pipe.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/platform/goldfish/goldfish_pipe.c +3 -5
@@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)return -EINVAL ; } - r =platform_get_resource (pdev,IORESOURCE_IRQ ,0 ); -if (!r) -return -EINVAL ; - - dev->irq = r->start; + dev->irq =platform_get_irq (pdev,0 ); +if (dev->irq <0 ) +return dev->irq;/* * Exchange the versions with the host device
Signature · 1 line
2.17.1
Re: [PATCH] platform: goldfish: pipe: switch to platform_get_irq
Ignore this, I posted it just now...
Quoted 33 lines · Yangtao Li
platform_get_resource(pdev, IORESOURCE_IRQ)is not recommended for requesting IRQ's resources, as they can be not ready yet. Usingplatform_get_irq()instead is preferred for getting IRQ even if it was not retrieved earlier.Signed-off-by Yangtao Li <[email protected]>--- drivers/platform/goldfish/goldfish_pipe.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)drivers/platform/goldfish/goldfish_pipe.c +3
-6@@ -913,11 +913,9 @@ static int goldfish_pipe_probe(struct platform_device *pdev)return -EINVAL ; } - r =platform_get_resource (pdev,IORESOURCE_IRQ ,0 ); -if (!r) -return -EINVAL ; - - dev->irq = r->start; + dev->irq =platform_get_irq (pdev,0 ); +if (dev->irq <0 ) +return dev->irq;/* * Exchange the versions with the host device -- 2.17.1
PATCH 2/2 drivers: platform: provide devm_platform_ioremap_resource_nocache()
In reply to Yangtao LiProvide a nocache variant of devm_platform_ioremap_resource().
--- .../driver-api/driver-model/devres.rst | 1 + drivers/base/platform.c | 19 +++++++++++++++++++ include/linux/platform_device.h | 3 +++ 3 files changed, 23 insertions(+)
Documentation/driver-api/driver-model/devres.rst +1 -0
@@ -320,6 +320,7 @@ IOMAP devm_ioremap_resource_nocache() devm_ioremap_resource_wc() devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device + devm_platform_ioremap_resource_nocache() devm_platform_ioremap_resource_wc() devm_platform_ioremap_resource_byname() devm_iounmap()
drivers/base/platform.c +19 -0
@@ -79,6 +79,25 @@ void __iomem *devm_platform_ioremap_resource(struct platform_device *pdev, }EXPORT_SYMBOL_GPL (devm_platform_ioremap_resource); +/** +* devm_platform_ioremap_resource_nocache - nocache variant of +* devm_platform_ioremap_resource() +* +* @pdev: platform device to use both for memory resource lookup as well as +* resource management +* @index: resource index +*/ +void __iomem * +devm_platform_ioremap_resource_nocache (struct platform_device *pdev, +unsigned int index) +{ +struct resource *res; + + res =platform_get_resource (pdev,IORESOURCE_MEM , index); +return devm_ioremap_resource_nocache (&pdev->dev, res); +} +EXPORT_SYMBOL_GPL (devm_platform_ioremap_resource_nocache); +/** * devm_platform_ioremap_resource_wc - write-combined variant of * devm_platform_ioremap_resource()
include/linux/platform_device.h +3 -0
@@ -58,6 +58,9 @@ extern void __iomem * devm_platform_ioremap_resource(struct platform_device *pdev, unsigned int index);extern void __iomem * +devm_platform_ioremap_resource_nocache (struct platform_device *pdev, +unsigned int index); +extern void __iomem *devm_platform_ioremap_resource_wc (struct platform_device *pdev,unsigned int index); extern void __iomem *
Signature · 1 line
2.17.1
Re: [PATCH 2/2] drivers: platform: provide devm_platform_ioremap_resource_nocache()
niedz., 29 gru 2019 o 11:43 Yangtao Li <[email protected]> napisał(a):
Quoted 67 lines
Provide a nocache variant of
devm_platform_ioremap_resource().Signed-off-by Yangtao Li <[email protected]>--- .../driver-api/driver-model/devres.rst | 1 + drivers/base/platform.c | 19 +++++++++++++++++++ include/linux/platform_device.h | 3 +++ 3 files changed, 23 insertions(+)Documentation/driver-api/driver-model/devres.rst +1
-0@@ -320,6 +320,7 @@ IOMAP devm_ioremap_resource_nocache() devm_ioremap_resource_wc() devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device + devm_platform_ioremap_resource_nocache() devm_platform_ioremap_resource_wc() devm_platform_ioremap_resource_byname() devm_iounmap()drivers/base/platform.c +19
-0@@ -79,6 +79,25 @@ void __iomem *devm_platform_ioremap_resource(struct platform_device *pdev, }EXPORT_SYMBOL_GPL (devm_platform_ioremap_resource); +/** +* devm_platform_ioremap_resource_nocache - nocache variant of +* devm_platform_ioremap_resource() +* +* @pdev: platform device to use both for memory resource lookup as well as +* resource management +* @index: resource index +*/ +void __iomem * +devm_platform_ioremap_resource_nocache (struct platform_device *pdev, +unsigned int index) +{ +struct resource *res; + + res =platform_get_resource (pdev,IORESOURCE_MEM , index); +return devm_ioremap_resource_nocache (&pdev->dev, res); +} +EXPORT_SYMBOL_GPL (devm_platform_ioremap_resource_nocache); +/** * devm_platform_ioremap_resource_wc - write-combined variant of * devm_platform_ioremap_resource() include/linux/platform_device.h +3
-1@@ -58,6 +58,9 @@ extern void __iomem * devm_platform_ioremap_resource(struct platform_device *pdev, unsigned int index);extern void __iomem * +devm_platform_ioremap_resource_nocache (struct platform_device *pdev, +unsigned int index); +extern void __iomem *devm_platform_ioremap_resource_wc (struct platform_device *pdev,unsigned int index); extern void __iomem * --
Quoted 2 lines
2.17.1
Please see my response to patch 1/2.
Bart
niedz., 29 gru 2019 o 11:43 Yangtao Li <[email protected]> napisał(a):
Quoted 62 lines
Provide a variant of
devm_ioremap_resource()for nocache ioremap.Signed-off-by Yangtao Li <[email protected]>--- Documentation/driver-api/driver-model/devres.rst | 1 + include/linux/device.h | 2 ++ lib/devres.c | 15 +++++++++++++++ 3 files changed, 18 insertions(+)Documentation/driver-api/driver-model/devres.rst +1
-0@@ -317,6 +317,7 @@ IOMAP devm_ioremap_uc() devm_ioremap_wc() devm_ioremap_resource() : checks resource, requests memory region, ioremaps + devm_ioremap_resource_nocache() devm_ioremap_resource_wc() devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device devm_platform_ioremap_resource_wc()include/linux/device.h +2
-0@@ -962,6 +962,8 @@ extern void devm_free_pages(struct device *dev, unsigned long addr);void __iomem *devm_ioremap_resource (struct device *dev,const struct resource *res); +void __iomem *devm_ioremap_resource_nocache (struct device *dev, +const struct resource *res);void __iomem *devm_ioremap_resource_wc (struct device *dev,const struct resource *res);lib/devres.c +15
-1@@ -188,6 +188,21 @@ void __iomem *devm_ioremap_resource(struct device *dev, }EXPORT_SYMBOL (devm_ioremap_resource); +/** +* devm_ioremap_resource_nocache() - nocache variant of +* devm_ioremap_resource() +* @dev: generic device to handle the resource for +* @res: resource to be handled +* +* Returns a pointer to the remapped memory or an ERR_PTR() encoded error code +* on failure. +*/ +void __iomem *devm_ioremap_resource_nocache (struct device *dev, +const struct resource *res) +{ +return __devm_ioremap_resource (dev, res,DEVM_IOREMAP_NC ); +} +/** * devm_ioremap_resource_wc() - write-combined variant of * devm_ioremap_resource() --
Quoted 2 lines
2.17.1
This has been discussed before. The nocache variants of ioremap() are being phased out as they're only ever needed on one obscure architecture IIRC. This is not needed, rather we should convert all nocache calls to regular ioremap().
Bart
Quoted 63 lines · Bartosz Golaszewski
niedz., 29 gru 2019 o 11:43 Yangtao Li <[email protected]> napisał(a):
Quoted 61 lines
Provide a variant of
devm_ioremap_resource()for nocache ioremap.Signed-off-by Yangtao Li <[email protected]>--- Documentation/driver-api/driver-model/devres.rst | 1 + include/linux/device.h | 2 ++ lib/devres.c | 15 +++++++++++++++ 3 files changed, 18 insertions(+)Documentation/driver-api/driver-model/devres.rst +1
-0@@ -317,6 +317,7 @@ IOMAP devm_ioremap_uc() devm_ioremap_wc() devm_ioremap_resource() : checks resource, requests memory region, ioremaps + devm_ioremap_resource_nocache() devm_ioremap_resource_wc() devm_platform_ioremap_resource() : calls devm_ioremap_resource() for platform device devm_platform_ioremap_resource_wc()include/linux/device.h +2
-0@@ -962,6 +962,8 @@ extern void devm_free_pages(struct device *dev, unsigned long addr);void __iomem *devm_ioremap_resource (struct device *dev,const struct resource *res); +void __iomem *devm_ioremap_resource_nocache (struct device *dev, +const struct resource *res);void __iomem *devm_ioremap_resource_wc (struct device *dev,const struct resource *res);lib/devres.c +15
-0@@ -188,6 +188,21 @@ void __iomem *devm_ioremap_resource(struct device *dev, }EXPORT_SYMBOL (devm_ioremap_resource); +/** +* devm_ioremap_resource_nocache() - nocache variant of +* devm_ioremap_resource() +* @dev: generic device to handle the resource for +* @res: resource to be handled +* +* Returns a pointer to the remapped memory or an ERR_PTR() encoded error code +* on failure. +*/ +void __iomem *devm_ioremap_resource_nocache (struct device *dev, +const struct resource *res) +{ +return __devm_ioremap_resource (dev, res,DEVM_IOREMAP_NC ); +} +/** * devm_ioremap_resource_wc() - write-combined variant of * devm_ioremap_resource()
Quoted 8 lines
Quoted 3 lines
--
2.17.1This has been discussed before. The nocache variants of
ioremap()are being phased out as they're only ever needed on one obscure architecture IIRC. This is not needed, rather we should convert all nocache calls to regularioremap().
Thanks for pointing out!
I have seen the use of ioremap_nocache in many architectures, so they are wrong and should be changed to ioremap?
Yangtao
Quoted 2 lines
Bart
Quoted 3 lines · Frank Lee
Thanks for pointing out!
I have seen the use ofioremap_nocachein many architectures, so they are wrong and should be changed to ioremap?
Yes, those patches are already part of linux-next.
Arnd