Skip to contentSkip to conversation

package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI

PATCH New Fabrice Fontaine 4 participants 6 messages Dec 30, 2019 – Mar 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI

gui is a mandatory dependency of python-pyqt5 as "-gui" option is used internally by the configure.py script

Fixes:
- http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9

---
 package/python-pyqt5/Config.in       | 1 +
 package/python-pyqt5/python-pyqt5.mk | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)
package/python-pyqt5/Config.in +1 -0
index 20ac988703..9fa7676f98 100644
@@ -5,6 +5,7 @@ config BR2_PACKAGE_PYTHON_PYQT5
 	bool "python-pyqt5"
 	depends on BR2_PACKAGE_QT5
 	select BR2_PACKAGE_PYTHON_SIP
+	select BR2_PACKAGE_QT5BASE_GUI
 	help
 	  Python bindings for Qt 5
 
package/python-pyqt5/python-pyqt5.mk +1 -2
index b6d559cd5b..260a93af9c 100644
@@ -12,9 +12,8 @@ PYTHON_PYQT5_LICENSE_FILES = LICENSE
 
 PYTHON_PYQT5_DEPENDENCIES = python-sip host-python-sip qt5base
 PYTHON_PYQT5_MODULES = \
-	QtCore \
+	QtCore QtGui \
 	$(if $(BR2_PACKAGE_QT5BASE_DBUS),QtDBus) \
-	$(if $(BR2_PACKAGE_QT5BASE_GUI),QtGui) \
 	$(if $(BR2_PACKAGE_QT5BASE_NETWORK),QtNetwork) \
 	$(if $(BR2_PACKAGE_QT5BASE_OPENGL_LIB),QtOpenGL) \
 	$(if $(BR2_PACKAGE_QT5BASE_PRINTSUPPORT),QtPrintSupport) \
Signature · 1 line
2.24.0
#1 lore raw

PATCH 1/1 package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI

Quoted 7 lines · On Mon, 30 Dec 2019 22:48:42 +0100 Fabrice Fontaine…

gui is a mandatory dependency of python-pyqt5 as "-gui" option is used internally by the configure.py script

Fixes:
- http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9

This seems weird. Are you sure? Could you talk with upstream about this?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI

Fabrice,

Any comment on the below question ?

Thanks!

Thomas

Quoted 14 lines · On Mon, 30 Dec 2019 23:42:59 +0100 Thomas Petazzoni…
Quoted 7 lines · On Mon, 30 Dec 2019 22:48:42 +0100 Fabrice Fontaine…

gui is a mandatory dependency of python-pyqt5 as "-gui" option is used internally by the configure.py script

Fixes:
- http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9

This seems weird. Are you sure? Could you talk with upstream about this?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI

Le dim. 12 janv. 2020 ? 23:06, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 4 lines

Fabrice,

Any comment on the below question ?

This is indeed "strange" but configure.py is really passing -gui unconditionally for QtCore (as well as QtDbus, QtNetwork ...). I didn't try to get in touch with upstream yet however I would assume that pyqt really expects that GUI is enabled on Qt.
Here is an extract of their whitepaper
(https://www.riverbankcomputing.com/static/Docs/PyQt4-whitepaper/pyqt-whitepaper-a4.pdf):
PyQt, provides an ideal combination for rapidly creating powerful and flexible GUI applications.

Quoted 21 lines

Thanks!

Thomas

Quoted 13 lines · On Mon, 30 Dec 2019 23:42:59 +0100 Thomas Petazzoni…
Quoted 7 lines · On Mon, 30 Dec 2019 22:48:42 +0100 Fabrice Fontaine…

gui is a mandatory dependency of python-pyqt5 as "-gui" option is used internally by the configure.py script

Fixes:
- http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9

This seems weird. Are you sure? Could you talk with upstream about this?

Quoted 8 lines
Quoted 1 line

Thomas

--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice

#4 lore raw

PATCH 1/1 package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI

Quoted 8 lines · Fabrice Fontaine

Le dim. 12 janv. 2020 ? 23:06, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 4 lines

Fabrice,

Any comment on the below question ?

This is indeed "strange" but configure.py is really passing -gui unconditionally for QtCore (as well as QtDbus, QtNetwork ...).

I've added a bit of this explanation to the commit message and applied to
master, thanks!

Regards,
Arnout

Quoted 43 lines

I didn't try to get in touch with upstream yet however I would assume that pyqt really expects that GUI is enabled on Qt.
Here is an extract of their whitepaper
(https://www.riverbankcomputing.com/static/Docs/PyQt4-whitepaper/pyqt-whitepaper-a4.pdf):
PyQt, provides an ideal combination for rapidly creating powerful and flexible GUI applications.

Quoted 21 lines

Thanks!

Thomas

Quoted 13 lines · On Mon, 30 Dec 2019 23:42:59 +0100 Thomas Petazzoni…
Quoted 7 lines · On Mon, 30 Dec 2019 22:48:42 +0100 Fabrice Fontaine…

gui is a mandatory dependency of python-pyqt5 as "-gui" option is used internally by the configure.py script

Fixes:
- http://autobuild.buildroot.org/results/ea0c8db44aacf1ce76f75e8288969fe5da6690d9

This seems weird. Are you sure? Could you talk with upstream about this?

Quoted 8 lines
Quoted 1 line

Thomas

--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#5 lore raw

PATCH 1/1 package/python-pyqt5: select BR2_PACKAGE_QT5BASE_GUI

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 3 lines · Fabrice Fontaine

Le dim. 12 janv. 2020 ? 23:06, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Fabrice,

Any comment on the below question ?

This is indeed "strange" but configure.py is really passing -gui unconditionally for QtCore (as well as QtDbus, QtNetwork ...).

I've added a bit of this explanation to the commit message and applied to
master, thanks!

Committed to 2019.02.x and 2019.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard