Skip to contentSkip to conversation

DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

PATCH New Thomas Petazzoni 2 participants 9 messages Aug 11, 2019 – Jan 6, 2020 5 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Nicholas was the most recent person to make significant changes to the galileo_defconfig, so let's add him as a contact for this defconfig, so that he receives notification of build failures and gets Cc'ed on patches.

Cc Nicholas Sielicki <[email protected]>
Cc Ray Kinsella <[email protected]>
Cc Padraig James Connolly <[email protected]>

---
Nicholas, could you reply with an Acked-by if you're fine with this? Thanks!

Otherwise, Ray and Padraig, if you are still working at Intel and willing to maintain this defconfig, please let us know. Thanks!

---
 DEVELOPERS | 4 ++++
 1 file changed, 4 insertions(+)
DEVELOPERS +4 -0
index 4cfb67e3a7..a9ed4d5360 100644
@@ -1707,6 +1707,10 @@ N:	Naumann Andreas <[email protected]>
 F:	package/evemu/
 F:	package/libevdev/
 
+N:	Nicholas Sielicki <[email protected]>
+F:	board/intel/galileo/
+F:	configs/galileo_defconfig
+
 N:	Nicolas Cavallari <[email protected]>
 F:	package/libgit2/
 
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

On 2019-08-11 14:07 +0200, Thomas Petazzoni spake thusly:

Quoted 9 lines

Nicholas was the most recent person to make significant changes to the galileo_defconfig, so let's add him as a contact for this defconfig, so that he receives notification of build failures and gets Cc'ed on patches.

Cc Nicholas Sielicki <[email protected]>
Cc Ray Kinsella <[email protected]>
Cc Padraig James Connolly <[email protected]>

Applied to master, thanks.

Quoted 6 lines

---
Nicholas, could you reply with an Acked-by if you're fine with this? Thanks!

Otherwise, Ray and Padraig, if you are still working at Intel and willing to maintain this defconfig, please let us know. Thanks!

Nicholas, Ray, Padraig, we really need people to take care of the defconfigs, at least when they fail to build. Without caretakers interested in those, we may have to remove them in the end.

If you really can't handle it, please say so, so we can take appropriate action.

Thanks! ;-)

Regards,
Yann E. MORIN.

Quoted 26 lines
---
 DEVELOPERS | 4 ++++
 1 file changed, 4 insertions(+)
DEVELOPERS +4 -0
index 4cfb67e3a7..a9ed4d5360 100644
@@ -1707,6 +1707,10 @@ N:	Naumann Andreas <[email protected]>
 F:	package/evemu/
 F:	package/libevdev/
 
+N:	Nicholas Sielicki <[email protected]>
+F:	board/intel/galileo/
+F:	configs/galileo_defconfig
+
 N:	Nicolas Cavallari <[email protected]>
 F:	package/libgit2/
 
Signature · 6 lines
2.21.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

A message that is not in the archive (sent off-list or not yet received): BN6PR11MB4145284497C2AF782D307B3590260@BN6PR11MB4145.namprd11.prod.outlook.com

#3 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Ray, All,

On 2019-12-31 20:15 +0000, Kinsella, Ray spake thusly:

Quoted 1 line

Is there a log I can take a look at?

None as of yet. We have gitlab-ci pipelines [0] running every week to test that the defconfigs still build. When a defconfig fails to build, a mail is automatically sent to whoever is registered for it.

Do you wish to be a recipient of such mail?

[0] the latest pipeline:

    https://gitlab.com/buildroot.org/buildroot/pipelines/105713000

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

A message that is not in the archive (sent off-list or not yet received): MN2PR11MB4160005AC798211088F160C090210@MN2PR11MB4160.namprd11.prod.outlook.com

#5 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Hello,

Quoted 11 lines · Ray

My buildroot skills are bit rusty, but I have been mean to dust them off. So I am willing to give it a go.

BTW is there a specific failure that is causing a problem at the moment. I have grub failing on what look to be Unicode related issues.

/build/buildroot/output/host/lib/gcc/i586-buildroot-linux-uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: grub-core/lib/gnulib/libgnu.a(mbrtowc.o): in function `mbrtowc':
mbrtowc.c:(.text+0x169): undefined reference to mbtowc' /build/buildroot/output/host/lib/gcc/i586-buildroot-linux-uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: mbrtowc.c:(.text+0x17a): undefined reference to mbtowc' /build/buildroot/output/host/lib/gcc/i586-buildroot-linux-uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: grub-core/lib/gnulib/libgnu.a(vasnprintf.o): in function `vasnprintf':
vasnprintf.c:(.text+0x566): undefined reference to `wctomb'

Could you try enabling BR2_TOOLCHAIN_BUILDROOT_WCHAR and do a full rebuild? Maybe we're missing this dependency in the grub package.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#6 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Ray, All,

(removing Padraig from the loop, their email is bouncing)

On 2020-01-01 16:34 +0100, Thomas Petazzoni spake thusly:

Quoted 7 lines
Quoted 5 lines · Ray

My buildroot skills are bit rusty, but I have been mean to dust them off. So I am willing to give it a go.

BTW is there a specific failure that is causing a problem at the moment. I have grub failing on what look to be Unicode related issues.

Is this really 'grub' (as in grub legacy), or 'grub2'? We do not have the legacy grub in Buildroot anymore.

Quoted 5 lines
Quoted 5 lines

/build/buildroot/output/host/lib/gcc/i586-buildroot-linux-uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: grub-core/lib/gnulib/libgnu.a(mbrtowc.o): in function `mbrtowc':
mbrtowc.c:(.text+0x169): undefined reference to mbtowc' /build/buildroot/output/host/lib/gcc/i586-buildroot-linux-uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: mbrtowc.c:(.text+0x17a): undefined reference to mbtowc' /build/buildroot/output/host/lib/gcc/i586-buildroot-linux-uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: grub-core/lib/gnulib/libgnu.a(vasnprintf.o): in function `vasnprintf':
vasnprintf.c:(.text+0x566): undefined reference to `wctomb'

I've just tried to build the galileo_defconfig, and it completed successfully here.

Quoted 2 lines

Could you try enabling BR2_TOOLCHAIN_BUILDROOT_WCHAR and do a full rebuild? Maybe we're missing this dependency in the grub package.

We already have a dependency on BR2_USE_WCHAR in grub2.

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

A message that is not in the archive (sent off-list or not yet received): BN6PR11MB4145B63CE33025809CB99F8490210@BN6PR11MB4145.namprd11.prod.outlook.com

#8 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Ray, All,

On 2020-01-01 21:08 +0000, Kinsella, Ray spake thusly:

Quoted 4 lines

Yup - a make clean and rebuild sorted it out.

So Yann/Thomas - what do you need someone to sign up to here? Is a nightly build or a regular checkin or ... ?

As I explained earlier, there is a weekly build of all the defconfigs on gitlab-ci [0], and when there is a failure, an automatic my is sent to whoever is registered in the DEVELOPPERS file for that defconfig.

So, that means no mail until there is a failure, and this is at most once a week, until the failure is fixed.

Regards,
Yann E. MORIN.

Quoted 65 lines

Ray K

Quoted 63 lines

-----Original Message-----
From: Yann E. MORIN <[email protected]>
Sent: Wednesday 1 January 2020 16:11
To: Thomas Petazzoni <[email protected]>
Cc: Kinsella, Ray <[email protected]>; buildroot at buildroot.org; Nicholas Sielicki <[email protected]>
Subject: Re: [Buildroot] [PATCH] DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Ray, All,

(removing Padraig from the loop, their email is bouncing)

On 2020-01-01 16:34 +0100, Thomas Petazzoni spake thusly:

Quoted 3 lines
Quoted 1 line · Ray

My buildroot skills are bit rusty, but I have been mean to dust

them off.

Quoted 3 lines
Quoted 3 lines

So I am willing to give it a go.

BTW is there a specific failure that is causing a problem at the

moment.

Quoted 1 line
Quoted 1 line

I have grub failing on what look to be Unicode related issues.

Is this really 'grub' (as in grub legacy), or 'grub2'? We do not have the legacy grub in Buildroot anymore.

Quoted 1 line
Quoted 1 line

/build/buildroot/output/host/lib/gcc/i586-buildroot-linux-

uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: grub- core/lib/gnulib/libgnu.a(mbrtowc.o): in function `mbrtowc':

Quoted 2 lines
Quoted 2 lines

mbrtowc.c:(.text+0x169): undefined reference to `mbtowc' /build/buildroot/output/host/lib/gcc/i586-buildroot-linux-

uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld:
mbrtowc.c:(.text+0x17a): undefined reference to `mbtowc'

Quoted 1 line
Quoted 1 line

/build/buildroot/output/host/lib/gcc/i586-buildroot-linux-

uclibc/8.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld: grub- core/lib/gnulib/libgnu.a(vasnprintf.o): in function `vasnprintf':

Quoted 1 line
Quoted 1 line

vasnprintf.c:(.text+0x566): undefined reference to `wctomb'

I've just tried to build the galileo_defconfig, and it completed successfully here.

Quoted 2 lines

Could you try enabling BR2_TOOLCHAIN_BUILDROOT_WCHAR and do a full rebuild? Maybe we're missing this dependency in the grub package.

We already have a dependency on BR2_USE_WCHAR in grub2.

Regards,
Yann E. MORIN.

--
.-----------------.--------------------.------------------.------------
--------.

|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics'
| conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___
|
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There
is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v
conspiracy.  |

'------------------------------^-------^------------------^------------ --------'

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#9 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Hello Ray,

Quoted 6 lines · On Wed, 1 Jan 2020 22:16:57 +0100 "Yann E. MORIN" <[email protected]>…

On 2020-01-01 21:08 +0000, Kinsella, Ray spake thusly:

Quoted 4 lines

Yup - a make clean and rebuild sorted it out.

So Yann/Thomas - what do you need someone to sign up to here? Is a nightly build or a regular checkin or ... ?

Quoted 6 lines

As I explained earlier, there is a weekly build of all the defconfigs on gitlab-ci [0], and when there is a failure, an automatic my is sent to whoever is registered in the DEVELOPPERS file for that defconfig.

So, that means no mail until there is a failure, and this is at most once a week, until the failure is fixed.

Another thing that can be done if you still have the Galileo hardware available is to update the defconfig to use newer version of the different components, i.e in this case the kernel: the defconfig uses 3.14, which is quite old now. There is no need to do that every week, but doing that once a year or so is nice.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

A message that is not in the archive (sent off-list or not yet received): BN6PR11MB4145CB3739932D59E074FC1C90200@BN6PR11MB4145.namprd11.prod.outlook.com

#11 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Hello Ray,

Quoted 5 lines · Ray

I had thought about that a few times, upgrading the kernel to the latest and greatest.

A good share of the Quark/X1000 SoC + Galileo Board support was upstreamed to the kernel. However some was not.

Quoted 8 lines

That out-of-tree 3.14 was the last version Intel engineers validated as supporting all the I/Os etc. So there is some unknown delta between the what is supported by the upstream and this out-of-tree kernels

If memory serves me the main difference was the SRAM drivers and some power management features.

Given this board is pretty old.
I would be inclined to update it to the latest kernel, and we can see if anyone screams. No doubt we will be retiring it completely soon enough.

Does it still make sense to have this Galileo defconfig? If I understood correctly, this platform is no longer sold/supported by Intel, so perhaps we should simply remove this defconfig, either now or at some point in the future ?

Quoted 1 line

You guys heading to FOSDEM this year?

A number of Buildroot developers will indeed be at FOSDEM, since we organize our Buildroot Developers meeting right after FOSDEM, see
https://elinux.org/Buildroot:DeveloperDaysFOSDEM2020.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

A message that is not in the archive (sent off-list or not yet received): BN6PR11MB4145527DD926BC273CA3F6B7903C0@BN6PR11MB4145.namprd11.prod.outlook.com

#13 lore raw

PATCH 1/1 DEVELOPERS: add Nicholas Sielicki as contact for galileo_defconfig

Hello,

Quoted 6 lines · Ray

The Galileo had a nice niche as being one of the very few boards with PCIe. Although it had been EOL'ed at Intel, I would get contacted about it regularly enough.

Now there are alternatives such as the PINE64 etc, so that interest as dried up. So yes, I think we should be agree'ing when we remove the defconfig.

Quoted 7 lines

Presume the next buildroot LTS is 20.02, we I suppose gives us three choices.

1. EOL Galileo in 20.02
2. Update Galileo to support a latest Kernel LTS in 20.02 (with the compromises discussed previously).
3. Leave Galileo as is for 20.02, and remove it post 20.02 release.

When is code freeze for 20.02?

End of January 2020.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com