Skip to contentSkip to conversation

package/samba4: AD DC needs python3

PATCH New Fabrice Fontaine 2 participants 2 messages Jan 1, 2020 – Jan 2, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/samba4: AD DC needs python3

python3 is mandatory since version 4.11 and
https://gitlab.com/samba-team/samba/commit/63d20d7822ead1626f7cb41fdbae6c9300893314

As a result, AD DC needs python3

Fixes:
- http://autobuild.buildroot.org/results/7af629b8acc92c81e006b1b87ae9a6fd461cf96d

---
 package/samba4/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/samba4/Config.in +4 -0
index a6997c13eb..493c79f3f8 100644
@@ -31,10 +31,14 @@ if BR2_PACKAGE_SAMBA4
 
 config BR2_PACKAGE_SAMBA4_AD_DC
 	bool "AD DC"
+	depends on BR2_PACKAGE_PYTHON3
 	select BR2_PACKAGE_JANSSON
 	help
 	  Enable Active Directory Domain Controller functionality.
 
+comment "AD DC depends on python3"
+	depends on !BR2_PACKAGE_PYTHON3
+
 config BR2_PACKAGE_SAMBA4_ADS
 	bool "ADS"
 	select BR2_PACKAGE_OPENLDAP
Signature · 1 line
2.24.0
#1 lore raw

PATCH 1/1 package/samba4: AD DC needs python3

Quoted 5 lines · On Wed, 1 Jan 2020 18:56:15 +0100 Fabrice Fontaine…

python3 is mandatory since version 4.11 and
https://gitlab.com/samba-team/samba/commit/63d20d7822ead1626f7cb41fdbae6c9300893314

As a result, AD DC needs python3

Quoted 7 lines

Fixes:
- http://autobuild.buildroot.org/results/7af629b8acc92c81e006b1b87ae9a6fd461cf96d

---
 package/samba4/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

Applied to master, thanks. Could you have a look at the discussion we had at
http://lists.busybox.net/pipermail/buildroot/2019-November/266145.html
on the topic of Samba4 use of Python, and see if we have now taken into account all what Trent Piepho reported back then ?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com