arm: dts: bcm283x: Allow UARTs to work before relocation
Subsystems (3)
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)
arch/arm/dts/bcm283x-u-boot.dtsi +8 -0
@@ -19,3 +19,11 @@ &gpio { u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; + +&uart1_gpio14 { + u-boot,dm-pre-reloc; +};
Signature · 1 line
2.24.0.393.g34dc348eaf-goog
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Quoted 17 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +0
-0@@ -19,3 +19,11 @@ &gpio {
arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 10 lines
arch/arm/dts/bcm283x-u-boot.dtsi +8
-0u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; + +&uart1_gpio14 { + u-boot,dm-pre-reloc; +};
I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191202/f2a101a7/attachment.sig>
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Hi Simon,
Quoted 26 lines · Tom Rini
Quoted 24 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +5
-0@@ -19,3 +19,11 @@ &gpio { u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; +
Quoted 9 lines
arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 3 lines
arch/arm/dts/bcm283x-u-boot.dtsi +3
-0+&uart1_gpio14 { + u-boot,dm-pre-reloc; +};I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Can you confirm if this is working with master branch or if we still need your patch. In which situation would we need your patch then?
Regards,
Matthias
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Hi Matthias,
Quoted 40 lines · Matthias Brugger
Hi Simon,
Quoted 26 lines · Tom Rini
Quoted 24 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +5
-0@@ -19,3 +19,11 @@ &gpio { u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; +Quoted 9 lines
arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 3 lines
arch/arm/dts/bcm283x-u-boot.dtsi +3
-0+&uart1_gpio14 { + u-boot,dm-pre-reloc; +};I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Quoted 2 lines
Can you confirm if this is working with master branch or if we still need your patch. In which situation would we need your patch then?
Unfortunately with the 'next' branch I still need this patch. WIthout it I don't get the pre-relocation serial output and tests fail.
Regards,
Simon
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Quoted 43 lines · Simon Glass
Hi Matthias,
Quoted 40 lines · Matthias Brugger
Hi Simon,
Quoted 35 lines · Tom Rini
Quoted 17 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +0
-0@@ -19,3 +19,11 @@ &gpio {arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 10 lines
arch/arm/dts/bcm283x-u-boot.dtsi +8
-0u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; + +&uart1_gpio14 { + u-boot,dm-pre-reloc; +};I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Quoted 5 lines
Quoted 2 lines
Can you confirm if this is working with master branch or if we still need your patch. In which situation would we need your patch then?
Unfortunately with the 'next' branch I still need this patch. WIthout it I don't get the pre-relocation serial output and tests fail.
Which Pi exactly? My 3B works with rpi_3_32b, rpi_3 and rpi_arm64 defconfigs and test.py.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200102/7c0797ec/attachment.sig>
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Hi Tom,
Quoted 45 lines · Tom Rini
Quoted 43 lines · Simon Glass
Hi Matthias,
Quoted 40 lines · Matthias Brugger
Hi Simon,
Quoted 35 lines · Tom Rini
Quoted 17 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +0
-0@@ -19,3 +19,11 @@ &gpio {arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 10 lines
arch/arm/dts/bcm283x-u-boot.dtsi +8
-0u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; + +&uart1_gpio14 { + u-boot,dm-pre-reloc; +};I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Can you confirm if this is working with master branch or if we still need your patch. In which situation would we need your patch then?
Unfortunately with the 'next' branch I still need this patch. WIthout it I don't get the pre-relocation serial output and tests fail.
Which Pi exactly? My 3B works with
rpi_3_32b,rpi_3andrpi_arm64defconfigs andtest.py.
It is a rpi_3b I believe, and I am using the rpi_3_32b.
When I cherry-pick the patch the banner appears but before that it doesn't. Shall I check it again?
Regards,
Simon
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Hi Tom,
Quoted 55 lines · Simon Glass
Hi Tom,
Quoted 51 lines · Tom Rini
Quoted 48 lines · Simon Glass
Hi Matthias,
Quoted 40 lines · Matthias Brugger
Hi Simon,
Quoted 26 lines · Tom Rini
Quoted 24 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +5
-0@@ -19,3 +19,11 @@ &gpio { u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; +Quoted 9 lines
arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 3 lines
arch/arm/dts/bcm283x-u-boot.dtsi +3
-0+&uart1_gpio14 { + u-boot,dm-pre-reloc; +};I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Quoted 2 lines
Can you confirm if this is working with master branch or if we still need your patch. In which situation would we need your patch then?
Unfortunately with the 'next' branch I still need this patch. WIthout it I don't get the pre-relocation serial output and tests fail.
Quoted 7 lines
Quoted 2 lines
Which Pi exactly? My 3B works with
rpi_3_32b,rpi_3andrpi_arm64defconfigs andtest.py.It is a
rpi_3bI believe, and I am using therpi_3_32b.When I cherry-pick the patch the banner appears but before that it doesn't. Shall I check it again?
Actually, can you please confirm the tree you are using? I was testing with -next. I wonder if I was missing a patch?
Regards,
SImon
Quoted 3 lines
Regards,
Simon
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Quoted 61 lines · Simon Glass
Hi Tom,
Quoted 58 lines · Simon Glass
Hi Tom,
Quoted 53 lines · Tom Rini
Quoted 43 lines · Simon Glass
Hi Matthias,
Quoted 40 lines · Matthias Brugger
Hi Simon,
Quoted 35 lines · Tom Rini
Quoted 17 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +0
-0@@ -19,3 +19,11 @@ &gpio {arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 10 lines
arch/arm/dts/bcm283x-u-boot.dtsi +8
-0u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; + +&uart1_gpio14 { + u-boot,dm-pre-reloc; +};I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Quoted 5 lines
Quoted 2 lines
Can you confirm if this is working with master branch or if we still need your patch. In which situation would we need your patch then?
Unfortunately with the 'next' branch I still need this patch. WIthout it I don't get the pre-relocation serial output and tests fail.
Which Pi exactly? My 3B works with
rpi_3_32b,rpi_3andrpi_arm64defconfigs andtest.py.
Quoted 7 lines
Quoted 4 lines
It is a
rpi_3bI believe, and I am using therpi_3_32b.When I cherry-pick the patch the banner appears but before that it doesn't. Shall I check it again?
Actually, can you please confirm the tree you are using? I was testing with -next. I wonder if I was missing a patch?
I just re-confirmed by checking out current 'next' and re-running test.py on all of the above combinations and they pass.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200102/a6d53060/attachment.sig>
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Hi Tom,
Quoted 65 lines · Tom Rini
Quoted 63 lines · Simon Glass
Hi Tom,
Quoted 60 lines · Simon Glass
Hi Tom,
Quoted 45 lines · Tom Rini
Quoted 43 lines · Simon Glass
Hi Matthias,
Quoted 40 lines · Matthias Brugger
Hi Simon,
Quoted 35 lines · Tom Rini
Quoted 17 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +0
-0@@ -19,3 +19,11 @@ &gpio {arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 10 lines
arch/arm/dts/bcm283x-u-boot.dtsi +8
-0u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; + +&uart1_gpio14 { + u-boot,dm-pre-reloc; +};I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Can you confirm if this is working with master branch or if we still need your patch. In which situation would we need your patch then?
Unfortunately with the 'next' branch I still need this patch. WIthout it I don't get the pre-relocation serial output and tests fail.
Which Pi exactly? My 3B works with
rpi_3_32b,rpi_3andrpi_arm64defconfigs andtest.py.It is a
rpi_3bI believe, and I am using therpi_3_32b.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
When I cherry-pick the patch the banner appears but before that it doesn't. Shall I check it again?
Actually, can you please confirm the tree you are using? I was testing with -next. I wonder if I was missing a patch?
I just re-confirmed by checking out current 'next' and re-running
test.pyon all of the above combinations and they pass.
I'm reviving this thread as I still have problems. I have these in config.txt:
enable_uart =1
gpu_freq=250
Have you tried with those?
Separately, on latest mainline I don't see any serial output at all from U-Boot with this config although linux does boot. I'm taking a look as the culprit is the ofdata commit.
Regards,
Simon
PATCH 1/1 arm: dts: bcm283x: Allow UARTs to work before relocation
Quoted 77 lines · Simon Glass
Hi Tom,
Quoted 65 lines · Tom Rini
Quoted 63 lines · Simon Glass
Hi Tom,
Quoted 60 lines · Simon Glass
Hi Tom,
Quoted 45 lines · Tom Rini
Quoted 43 lines · Simon Glass
Hi Matthias,
Quoted 40 lines · Matthias Brugger
Hi Simon,
Quoted 35 lines · Tom Rini
Quoted 17 lines · Simon Glass
At present the pinctrl nodes are not enabled in pre-relocation U-Boot so the UARTs do not correctly select the pinconfig to enable the UART pins. Fix this so that the U-Boot banner is printed.
Signed-off-by Simon Glass <[email protected]>Fixes 9821636b64 (bcm2835_pinctrl: Probe pre-reloc)---
arch/arm/dts/bcm283x-u-boot.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+)arch/arm/dts/bcm283x-u-boot.dtsi +0
-0@@ -19,3 +19,11 @@ &gpio {arch/arm/dts/bcm283x-u-boot.dtsi line 29
Quoted 10 lines
arch/arm/dts/bcm283x-u-boot.dtsi +8
-0u-boot,dm-pre-reloc; }; + +&uart0_gpio14 { + u-boot,dm-pre-reloc; +}; + +&uart1_gpio14 { + u-boot,dm-pre-reloc; +};I think this is superseded by the RPi PR that I had been testing and just now pushed. Can you confirm that master is fine on your Pis as well? I gather you hit this failure doing pytest on the board, which is also how I found it. Thanks!
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Can you confirm if this is working with master branch or if we still need your patch. In which situation would we need your patch then?
Unfortunately with the 'next' branch I still need this patch. WIthout it I don't get the pre-relocation serial output and tests fail.
Which Pi exactly? My 3B works with
rpi_3_32b,rpi_3andrpi_arm64defconfigs andtest.py.It is a
rpi_3bI believe, and I am using therpi_3_32b.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
When I cherry-pick the patch the banner appears but before that it doesn't. Shall I check it again?
Actually, can you please confirm the tree you are using? I was testing with -next. I wonder if I was missing a patch?
I just re-confirmed by checking out current 'next' and re-running
test.pyon all of the above combinations and they pass.
Quoted 6 lines
I'm reviving this thread as I still have problems. I have these in config.txt:
enable_uart=1
gpu_freq=250Have you tried with those?
No as I only have enable_uart=1 in mine.
Quoted 3 lines
Separately, on latest mainline I don't see any serial output at all from U-Boot with this config although linux does boot. I'm taking a look as the culprit is the ofdata commit.
OK, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200323/8c32220d/attachment.sig>