Skip to contentSkip to conversation

kms_content_protection: add check for DPMS off state

PATCH In review Ramalingam C 3 participants 4 messages Jan 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kms_content_protection: add check for DPMS off state

During DPMS off HDCP state should be DESIRED.
Lets add a check for that.

cc Anshuman Gupta <[email protected]>
---
 tests/kms_content_protection.c | 5 +++++
 1 file changed, 5 insertions(+)
tests/kms_content_protection.c +5 -0
index 8b361fdefb2e..eb6cd9ec50b1 100644
@@ -513,6 +513,11 @@ static void test_content_protection_on_output(igt_output_t *output,
 						IGT_CRTC_ACTIVE, 0);
 			igt_display_commit2(display, s);
 
+			/* Wait for HDCP to be disabled, before crtc off */
+			ret = wait_for_prop_value(output, CP_DESIRED,
+						  KERNEL_DISABLE_TIME_ALLOWED_MSEC);
+			igt_assert_f(ret, "Content Protection not cleared\n");
+
 			igt_pipe_set_prop_value(display, pipe,
 						IGT_CRTC_ACTIVE, 1);
 			igt_display_commit2(display, s);
Signature · 6 lines
2.20.1

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for kms_content_protection: add check for DPMS off state

== Series Details ==

== Series Details ==

Series: kms_content_protection: add check for DPMS off state
URL : https://patchwork.freedesktop.org/series/71590/
State : warning

== Summary ==

Did not get list of undocumented tests for this run, something is wrong!

Other than that, pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/93477 for the overview.

test:ninja-test-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/1263790):
[test_root] Directory that contains the IGT tests. The environment
variable IGT_TEST_ROOT will be used if set, overriding this option if given.
Cannot open /builds/gfx-ci/igt-ci-tags/build/tmpdirX9IMb1/test-list.txt
-------

Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt
FAILED: meson-test
/usr/bin/meson test --no-rebuild --print-errorlogs
ninja: build stopped: subcommand failed. section_end:1578040536:build_script section_start:1578040536:after_script section_end:1578040537:after_script section_start:1578040537:upload_artifacts_on_failure Uploading artifacts...
build: found 1366 matching files 
Uploading artifacts to coordinator... ok  id=1263790 responseStatus=201 Created token=NnfZARNG
section_end:1578040542:upload_artifacts_on_failure ERROR: Job failed: exit code 1


== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/93477
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for kms_content_protection: add check for DPMS off state

In reply to Ramalingam C
== Series Details ==

== Series Details ==

Series: kms_content_protection: add check for DPMS off state
URL : https://patchwork.freedesktop.org/series/71590/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7671 -> IGTPW_3894
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_3894 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_3894, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_3894:

### IGT changes ###

#### Possible regressions ####

* igt@kms_busy@basic-flip-pipe-b:
- fi-tgl-y: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/fi-tgl-y/igt@[email protected]

Known issues
------------

Here are the changes found in IGTPW_3894 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_suspend@basic-s3:
- fi-skl-6600u: [PASS][2] -> [INCOMPLETE][3] ([i915#146] / [i915#69])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7671/fi-skl-6600u/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/fi-skl-6600u/igt@[email protected]

* igt@i915_module_load@reload-with-fault-injection:
- fi-kbl-x1275: [PASS][4] -> [INCOMPLETE][5] ([i915#879])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7671/fi-kbl-x1275/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/fi-kbl-x1275/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-kbl-guc: [PASS][6] -> [FAIL][7] ([i915#579])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7671/fi-kbl-guc/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/fi-kbl-guc/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-ivb-3770: [PASS][8] -> [DMESG-FAIL][9] ([i915#725])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7671/fi-ivb-3770/igt@i915_selftest@live_blt.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/fi-ivb-3770/igt@i915_selftest@live_blt.html

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0:
- fi-cml-s: [INCOMPLETE][10] ([i915#283]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7671/fi-cml-s/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/fi-cml-s/igt@[email protected]

* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][12] ([i915#725]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7671/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/fi-hsw-4770r/igt@i915_selftest@live_blt.html

* igt@i915_selftest@live_gem_contexts:
- fi-cfl-guc: [DMESG-FAIL][14] ([i915#623]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7671/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/fi-cfl-guc/igt@i915_selftest@live_gem_contexts.html

[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#283]: https://gitlab.freedesktop.org/drm/intel/issues/283
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
[i915#623]: https://gitlab.freedesktop.org/drm/intel/issues/623
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#879]: https://gitlab.freedesktop.org/drm/intel/issues/879

Participating hosts (48 -> 47)
------------------------------

Additional (5): fi-hsw-peppy fi-bwr-2160 fi-snb-2520m fi-gdg-551 fi-tgl-y
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_5357 -> IGTPW_3894

CI-20190529: 20190529
CI_DRM_7671: 2348d330223761be0a66ce3725d9be35fec0019a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3894: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/index.html
IGT_5357: a555a4b98f90dab655d24bb3d07e9291a8b8dac8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3894/index.html
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#3 lore raw
In reply to Ramalingam C
Quoted 2 lines · Ramalingam C

During DPMS off HDCP state should be DESIRED.
Lets add a check for that.

Not related to this patch but DPMS is connector property and test name is DPMS but sub-test is setting crtc property. slightly confusing. Leaving up to you to change it.

Quoted 3 lines
cc Anshuman Gupta <[email protected]>
Quoted 11 lines
---
  tests/kms_content_protection.c | 5 +++++
  1 file changed, 5 insertions(+)
tests/kms_content_protection.c +0 -0
index 8b361fdefb2e..eb6cd9ec50b1 100644
@@ -513,6 +513,11 @@ static void test_content_protection_on_output(igt_output_t *output,
  						IGT_CRTC_ACTIVE, 0);

tests/kms_content_protection.c static void test_content_protection_on_output(igt_output_t *output, · line 523

Quoted 10 lines
tests/kms_content_protection.c +5 -0
  			igt_display_commit2(display, s);
 
+			/* Wait for HDCP to be disabled, before crtc off */
+			ret = wait_for_prop_value(output, CP_DESIRED,
+						  KERNEL_DISABLE_TIME_ALLOWED_MSEC);
+			igt_assert_f(ret, "Content Protection not cleared\n");
+
  			igt_pipe_set_prop_value(display, pipe,
  						IGT_CRTC_ACTIVE, 1);
  			igt_display_commit2(display, s);

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev