sched/fair: calculate delta runnable load only when it's needed
PATCH 1/1 sched/fair: calculate delta runnable load only when it's needed
Move the code of calculation for delta_sum/delta_avg to where it is really needed to be done.
Signed-off-by Peng Wang <[email protected]>
--- kernel/sched/fair.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
kernel/sched/fair.c +6 -5
@@ -3366,16 +3366,17 @@ update_tg_cfs_runnable(struct cfs_rq *cfs_rq, struct sched_entity *se, struct cf runnable_load_sum = (s64 )se_runnable (se) * runnable_sum; runnable_load_avg =div_s64 (runnable_load_sum,LOAD_AVG_MAX ); - delta_sum = runnable_load_sum -se_weight (se) * se->avg.runnable_load_sum; - delta_avg = runnable_load_avg - se->avg.runnable_load_avg; - - se->avg.runnable_load_sum = runnable_sum; - se->avg.runnable_load_avg = runnable_load_avg;if (se->on_rq) { + delta_sum = runnable_load_sum - +se_weight (se) * se->avg.runnable_load_sum; + delta_avg = runnable_load_avg - se->avg.runnable_load_avg;add_positive (&cfs_rq->avg.runnable_load_avg, delta_avg);add_positive (&cfs_rq->avg.runnable_load_sum, delta_sum); } + + se->avg.runnable_load_sum = runnable_sum; + se->avg.runnable_load_avg = runnable_load_avg; }static inline void add_tg_cfs_propagate (struct cfs_rq *cfs_rq,long runnable_sum)
Signature · 1 line
2.24.0
Quoted 2 lines · Peng Wang
Move the code of calculation for delta_sum/delta_avg to where
Maybe precise that you move delta_sum/delta_avg for runnable_load_sum/avg
Quoted 3 lines
it is really needed to be done.
Signed-off-by Peng Wang <[email protected]>
make sense to me
Reviewed-by Vincent Guittot <[email protected]>
Quoted 34 lines
--- kernel/sched/fair.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)kernel/sched/fair.c +6
-6@@ -3366,16 +3366,17 @@ update_tg_cfs_runnable(struct cfs_rq *cfs_rq, struct sched_entity *se, struct cf runnable_load_sum = (s64 )se_runnable (se) * runnable_sum; runnable_load_avg =div_s64 (runnable_load_sum,LOAD_AVG_MAX ); - delta_sum = runnable_load_sum -se_weight (se) * se->avg.runnable_load_sum; - delta_avg = runnable_load_avg - se->avg.runnable_load_avg; - - se->avg.runnable_load_sum = runnable_sum; - se->avg.runnable_load_avg = runnable_load_avg;if (se->on_rq) { + delta_sum = runnable_load_sum - +se_weight (se) * se->avg.runnable_load_sum; + delta_avg = runnable_load_avg - se->avg.runnable_load_avg;add_positive (&cfs_rq->avg.runnable_load_avg, delta_avg);add_positive (&cfs_rq->avg.runnable_load_sum, delta_sum); } + + se->avg.runnable_load_sum = runnable_sum; + se->avg.runnable_load_avg = runnable_load_avg; }static inline void add_tg_cfs_propagate (struct cfs_rq *cfs_rq,long runnable_sum) --2.24.0
The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: fe71bbb21ee14160f73f81b113d71145327a1c0d Gitweb: https://git.kernel.org/tip/fe71bbb21ee14160f73f81b113d71145327a1c0d Author: Peng Wang <[email protected]> AuthorDate: Fri, 03 Jan 2020 19:44:00 +08:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Fri, 17 Jan 2020 10:19:21 +01:00
sched/fair: calculate delta runnable load only when it's needed
Move the code of calculation for delta_sum/delta_avg to where it is really needed to be done.
Signed-off-by Peng Wang <[email protected]>
Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Reviewed-by Vincent Guittot <[email protected]>
--- kernel/sched/fair.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)
kernel/sched/fair.c +6 -5
@@ -3366,16 +3366,17 @@ update_tg_cfs_runnable(struct cfs_rq *cfs_rq, struct sched_entity *se, struct cf runnable_load_sum = (s64 )se_runnable (se) * runnable_sum; runnable_load_avg =div_s64 (runnable_load_sum,LOAD_AVG_MAX ); - delta_sum = runnable_load_sum -se_weight (se) * se->avg.runnable_load_sum; - delta_avg = runnable_load_avg - se->avg.runnable_load_avg; - - se->avg.runnable_load_sum = runnable_sum; - se->avg.runnable_load_avg = runnable_load_avg;if (se->on_rq) { + delta_sum = runnable_load_sum - +se_weight (se) * se->avg.runnable_load_sum; + delta_avg = runnable_load_avg - se->avg.runnable_load_avg;add_positive (&cfs_rq->avg.runnable_load_avg, delta_avg);add_positive (&cfs_rq->avg.runnable_load_sum, delta_sum); } + + se->avg.runnable_load_sum = runnable_sum; + se->avg.runnable_load_avg = runnable_load_avg; }static inline void add_tg_cfs_propagate (struct cfs_rq *cfs_rq,long runnable_sum)