Skip to contentSkip to conversation

gpio: gpiolib: fix confusing indention

PATCH In review Enrico Weigelt, metux IT consult 2 participants 2 messages Jan 4, 2020 – Jan 6, 2020 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: gpiolib: fix confusing indention

There's a confusing indention in gpiochip_add_data_with_key(), which could be misinterpreted on a quick walkthrough. Fixing this in order to improve code readability a bit.

---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib.c +1 -1
index 3fa2f4d3cdce..d77695cc82ef 100644
@@ -1447,7 +1447,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data,
 
 	if (chip->ngpio > FASTPATH_NGPIO)
 		chip_warn(chip, "line cnt %u is greater than fast path cnt %u\n",
-		chip->ngpio, FASTPATH_NGPIO);
+			  chip->ngpio, FASTPATH_NGPIO);
 
 	gdev->label = kstrdup_const(chip->label ?: "unknown", GFP_KERNEL);
 	if (!gdev->label) {
Signature · 1 line
2.11.0
#1 lore raw

sob., 4 sty 2020 o 20:49 Enrico Weigelt, metux IT consult <[email protected]> napisał(a):

Quoted 24 lines

There's a confusing indention in gpiochip_add_data_with_key(), which could be misinterpreted on a quick walkthrough. Fixing this in order to improve code readability a bit.

---
 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpio/gpiolib.c +1 -2
index 3fa2f4d3cdce..d77695cc82ef 100644
@@ -1447,7 +1447,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *chip, void *data,
 
        if (chip->ngpio > FASTPATH_NGPIO)
                chip_warn(chip, "line cnt %u is greater than fast path cnt %u\n",
-               chip->ngpio, FASTPATH_NGPIO);
+                         chip->ngpio, FASTPATH_NGPIO);
 
        gdev->label = kstrdup_const(chip->label ?: "unknown", GFP_KERNEL);
        if (!gdev->label) {
--
Quoted 2 lines

2.11.0

Patch applied, thanks!

Bart