Skip to contentSkip to conversation

dt-bindings: mmc: clarify disable-wp text

PATCH New Johan Jonker 3 participants 7 messages Dec 19, 2019 – Jan 16, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: mmc: clarify disable-wp text

Clarify disable-wp text.
Clean up and add that "disable-wp" is not used in combination with eMMC or SDIO.

---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/mmc/mmc-controller.yaml +2 -3
index b130450c3..3c0df4016 100644
@@ -96,11 +96,10 @@ properties:
     description:
       When set, no physical write-protect line is present. This
       property should only be specified when the controller has a
-      dedicated write-protect detection logic. If a GPIO is always
-      used for the write-protect detection. If a GPIO is always used
+      dedicated write-protect detection logic. If a GPIO is always used
       for the write-protect detection logic, it is sufficient to not
       specify the wp-gpios property in the absence of a write-protect
-      line.
+      line. Not used in combination with eMMC or SDIO.
 
   wp-gpios:
     description:
Signature · 1 line
2.11.0
#1 lore raw

PATCH v2 1/2 dt-bindings: mmc: remove identical phrase in disable-wp text

There are two identical phrases in the disable-wp text, so remove one of them.

---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Documentation/devicetree/bindings/mmc/mmc-controller.yaml +1 -2
index b130450c3..d668d0fbe 100644
@@ -96,8 +96,7 @@ properties:
     description:
       When set, no physical write-protect line is present. This
       property should only be specified when the controller has a
-      dedicated write-protect detection logic. If a GPIO is always
-      used for the write-protect detection. If a GPIO is always used
+      dedicated write-protect detection logic. If a GPIO is always used
       for the write-protect detection logic, it is sufficient to not
       specify the wp-gpios property in the absence of a write-protect
       line.
Signature · 1 line
2.11.0
#2 lore raw

PATCH v2 2/2 dt-bindings: mmc: clarify disable-wp text

"disable-wp" has been removed from all Rockchip eMMC and SDIO dts nodes, but people still continue to submit new patches with "disable-wp" added to other nodes then for the SD card slot,
what it was designed for in the first place.
So clarify the "disable-wp" text by adding that this option should not be used in combination with eMMC or SDIO.

---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/devicetree/bindings/mmc/mmc-controller.yaml +1 -1
index d668d0fbe..3c0df4016 100644
@@ -99,7 +99,7 @@ properties:
       dedicated write-protect detection logic. If a GPIO is always used
       for the write-protect detection logic, it is sufficient to not
       specify the wp-gpios property in the absence of a write-protect
-      line.
+      line. Not used in combination with eMMC or SDIO.
 
   wp-gpios:
     description:
Signature · 1 line
2.11.0
maintainer Applied
#3 lore raw
Quoted 7 lines · Johan Jonker

"disable-wp" has been removed from all Rockchip eMMC and SDIO dts nodes, but people still continue to submit new patches with "disable-wp" added to other nodes then for the SD card slot,
what it was designed for in the first place.
So clarify the "disable-wp" text by adding that this option should not be used in combination with eMMC or SDIO.

Quoted 5 lines
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Rob

maintainer Applied
#4 lore raw

Re: [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in disable-wp text

In reply to Johan Jonker
Quoted 8 lines · Johan Jonker

There are two identical phrases in the disable-wp text, so remove one of them.

---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Applied, thanks.

Rob

#5 lore raw

Re: [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in disable-wp text

Quoted 11 lines · Rob Herring
Quoted 8 lines · Johan Jonker

There are two identical phrases in the disable-wp text, so remove one of them.

---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 3 lines

Applied, thanks.

Rob

Rob,

Normally I pick up the DT doc changes for mmc whenever you have acked them (at least more non-trivial changes). I regards to the mmc-controller.yaml file, I have no queued changes in my tree for this cycle so this should be fine in regards to conflicts.

Going forward, do you prefer to pick the DT doc changes for mmc, or can I consider this as a single occasion thingy?

Kind regards
Uffe

maintainer
#6 lore raw

Re: [PATCH v2 1/2] dt-bindings: mmc: remove identical phrase in disable-wp text

Quoted 19 lines · Ulf Hansson
Quoted 11 lines · Rob Herring
Quoted 8 lines · Johan Jonker

There are two identical phrases in the disable-wp text, so remove one of them.

---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 3 lines

Applied, thanks.

Rob

Rob,

Quoted 7 lines

Normally I pick up the DT doc changes for mmc whenever you have acked them (at least more non-trivial changes). I regards to the mmc-controller.yaml file, I have no queued changes in my tree for this cycle so this should be fine in regards to conflicts.

Going forward, do you prefer to pick the DT doc changes for mmc, or can I consider this as a single occasion thingy?

I usually only pick up small changes if they are a binding only series and if they haven't been picked up already.

Though I've been picking up a few schema conversions primarily so I can check that they validate. Hopefully that's temporary.

Rob