Skip to contentSkip to conversation

net: stmmac: dwmac-sunxi: Allow all RGMII modes

PATCH In review Chen-Yu Tsai 3 participants 3 messages Jan 6, 2020 – Jan 8, 2020

Subsystems (5)
lore
Share & tools
lore

Chen-Yu Tsai

author maintainer
#0 lore raw

PATCH 1/1 net: stmmac: dwmac-sunxi: Allow all RGMII modes

From: Chen-Yu Tsai <[email protected]>

Allow all the RGMII modes to be used. This would allow us to represent the hardware better in the device tree with RGMII_ID where in most cases the PHY's internal delay for both RX and TX are used.

Fixes af0bd4e9ba80 ("net: stmmac: sunxi platform extensions for GMAC in Allwinner A20 SoC's")

---

Maybe CC stable so future device trees can be used with stable kernels?

---
 drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c +1 -1
index 26353ef616b8..7d40760e9ba8 100644
@@ -44,7 +44,7 @@ static int sun7i_gmac_init(struct platform_device *pdev, void *priv)
 	 * rate, which then uses the auto-reparenting feature of the
 	 * clock driver, and enabling/disabling the clock.
 	 */
-	if (gmac->interface == PHY_INTERFACE_MODE_RGMII) {
+	if (phy_interface_mode_is_rgmii(gmac->interface)) {
 		clk_set_rate(gmac->tx_clk, SUN7I_GMAC_GMII_RGMII_RATE);
 		clk_prepare_enable(gmac->tx_clk);
 		gmac->clk_enabled = 1;
Signature · 1 line
2.24.1
#1 lore raw

From: Chen-Yu Tsai <[email protected]>
Date: Mon, 6 Jan 2020 11:09:22 +0800

Quoted 1 line

Maybe CC stable so future device trees can be used with stable kernels?

Please read the netdev FAQ, you should never CC: stable for networking changes.

maintainer
#2 lore raw
In reply to Chen-Yu Tsai

From: Chen-Yu Tsai <[email protected]>
Date: Mon, 6 Jan 2020 11:09:22 +0800

Quoted 8 lines

From: Chen-Yu Tsai <[email protected]>

Allow all the RGMII modes to be used. This would allow us to represent the hardware better in the device tree with RGMII_ID where in most cases the PHY's internal delay for both RX and TX are used.

Fixes af0bd4e9ba80 ("net: stmmac: sunxi platform extensions for GMAC in Allwinner A20 SoC's")

Applied and queued up for -stable.