Skip to contentSkip to conversation

freebsd: use python37

PATCH In review Gerd Hoffmann 3 participants 4 messages Jan 6, 2020 – Jan 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 freebsd: use python37

FreeBSD seems to use python37 by default now, which breaks the build script. Add python to the package list, to explicitly pick the version, and also adapt the configure command line.

---
 tests/vm/freebsd | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tests/vm/freebsd +2 -1
index 1825cc58218b..33a736298a9a 100755
@@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
         "git",
         "pkgconf",
         "bzip2",
+        "python37",
 
         # gnu tools
         "bash",
@@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
         mkdir src build; cd src;
         tar -xf /dev/vtbd1;
         cd ../build
-        ../src/configure --python=python3.6 {configure_opts};
+        ../src/configure --python=python3.7 {configure_opts};
         gmake --output-sync -j{jobs} {target} {verbose};
     """
 
Signature · 1 line
2.18.1
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 23 lines · Gerd Hoffmann

FreeBSD seems to use python37 by default now, which breaks the build script. Add python to the package list, to explicitly pick the version, and also adapt the configure command line.

---
  tests/vm/freebsd | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
tests/vm/freebsd +1 -0
index 1825cc58218b..33a736298a9a 100755
@@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
          "git",
          "pkgconf",
          "bzip2",
+        "python37",
 
          # gnu tools
          "bash",

tests/vm/freebsd class FreeBSDVM(basevm.BaseVM): · line 70

Quoted 8 lines
tests/vm/freebsd +1 -1
@@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
          mkdir src build; cd src;
          tar -xf /dev/vtbd1;
          cd ../build
-        ../src/configure --python=python3.6 {configure_opts};
+        ../src/configure --python=python3.7 {configure_opts};
          gmake --output-sync -j{jobs} {target} {verbose};
      """
 
#2 lore raw
Quoted 3 lines · Philippe Mathieu-Daudé
Quoted 1 line · Gerd Hoffmann

FreeBSD seems to use python37 by default now, which breaks the build

BTW it looks clearer replacing by 'python3.7' here and in subject.

Quoted 33 lines
Quoted 22 lines

script. Add python to the package list, to explicitly pick the version, and also adapt the configure command line.

---
  tests/vm/freebsd | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
tests/vm/freebsd +1 -0
index 1825cc58218b..33a736298a9a 100755
@@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
          "git",
          "pkgconf",
          "bzip2",
+        "python37",
 
          # gnu tools
          "bash",

tests/vm/freebsd class FreeBSDVM(basevm.BaseVM): · line 70

Quoted 8 lines
tests/vm/freebsd +1 -1
@@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
          mkdir src build; cd src;
          tar -xf /dev/vtbd1;
          cd ../build
-        ../src/configure --python=python3.6 {configure_opts};
+        ../src/configure --python=python3.7 {configure_opts};
          gmake --output-sync -j{jobs} {target} {verbose};
      """
 
#3 lore raw
In reply to Gerd Hoffmann
Quoted 5 lines · Gerd Hoffmann

FreeBSD seems to use python37 by default now, which breaks the build script. Add python to the package list, to explicitly pick the version, and also adapt the configure command line.

Queued to testing/next, thanks.

Quoted 24 lines
---
 tests/vm/freebsd | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tests/vm/freebsd +2 -1
index 1825cc58218b..33a736298a9a 100755
@@ -32,6 +32,7 @@ class FreeBSDVM(basevm.BaseVM):
         "git",
         "pkgconf",
         "bzip2",
+        "python37",
 
         # gnu tools
         "bash",
@@ -63,7 +64,7 @@ class FreeBSDVM(basevm.BaseVM):
         mkdir src build; cd src;
         tar -xf /dev/vtbd1;
         cd ../build
-        ../src/configure --python=python3.6 {configure_opts};
+        ../src/configure --python=python3.7 {configure_opts};
         gmake --output-sync -j{jobs} {target} {verbose};
     """
Signature · 1 line
Alex Bennée