Skip to contentSkip to conversation

drm/udl: Make udl driver depend on CONFIG_USB

PATCH In review Thomas Zimmermann 2 participants 2 messages Jan 6, 2020

Subsystems (3)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/udl: Make udl driver depend on CONFIG_USB

The udl driver for DisplayLink devices depends on support for host-side USB controllers, which is enabled with CONFIG_USB. Plain USB support as given by CONFIG_USB_SUPPORT not sufficient.

This patch changes dependencies for udl to depend on CONFIG_USB, instead of CONFIG_USB_SUPPORT. Users will have to enable CONFIG_USB and select a USB host controller. With this change udl dependencies work the same way as dependencies for PCI drivers.

---
 drivers/gpu/drm/udl/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/udl/Kconfig +1 -2
index 065974bf010e..1f497d8f1ae5 100644
@@ -2,9 +2,8 @@
 config DRM_UDL
 	tristate "DisplayLink"
 	depends on DRM
-	depends on USB_SUPPORT
+	depends on USB
 	depends on USB_ARCH_HAS_HCD
-	select USB
 	select DRM_GEM_SHMEM_HELPER
 	select DRM_KMS_HELPER
 	help
Signature · 6 lines
2.24.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Thomas Zimmermann

The udl driver for DisplayLink devices depends on support for host-side USB controllers, which is enabled with CONFIG_USB. Plain USB support as given by CONFIG_USB_SUPPORT not sufficient.

This patch changes dependencies for udl to depend on CONFIG_USB, instead of CONFIG_USB_SUPPORT. Users will have to enable CONFIG_USB and select a USB host controller. With this change udl dependencies work the same way as dependencies for PCI drivers.

Quoted 22 lines
---
 drivers/gpu/drm/udl/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/gpu/drm/udl/Kconfig +1 -3
index 065974bf010e..1f497d8f1ae5 100644
@@ -2,9 +2,8 @@
 config DRM_UDL
        tristate "DisplayLink"
        depends on DRM
-       depends on USB_SUPPORT
+       depends on USB
        depends on USB_ARCH_HAS_HCD
-       select USB
        select DRM_GEM_SHMEM_HELPER
        select DRM_KMS_HELPER
        help
--

2.24.1

Quoted 4 lines

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel