Skip to contentSkip to conversation

mx6ul_14x14_evk: Fix SPL hang

PATCH New Fabio Estevam 4 participants 18 messages Jan 6, 2020 – Jan 10, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mx6ul_14x14_evk: Fix SPL hang

Currently the following SPL hang is observed:

U-Boot SPL 2020.01-rc5-00079-g797eee36a1 (Jan 06 2020 - 11:24:09 -0300) Trying to boot from MMC1
Card did not respond to voltage select!
spl: mmc init failed with error: -95
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

Fix it by moving the eSDHC1 initialization to SPL.

While at it, since this board uses DM_MMC all the esdhc board code can be removed.

---
Hi,

Still get the following "no card present" error in U-Boot proper:

MMC: FSL_SDHC: 0, FSL_SDHC: 1
Loading Environment from MMC... MMC: no card present *** Warning - No block device, using default environment

but this should be treated separately.

 .../mx6ul_14x14_evk/mx6ul_14x14_evk.c         | 175 ++----------------
 1 file changed, 20 insertions(+), 155 deletions(-)
board/freescale/mx6ul_14x14_evk/mx6ul_14x14_evk.c +20 -155
index 898da34729..086e0e6739 100644
@@ -36,14 +36,6 @@ DECLARE_GLOBAL_DATA_PTR;
 	PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED |		\
 	PAD_CTL_DSE_40ohm   | PAD_CTL_SRE_FAST  | PAD_CTL_HYS)
 
-#define USDHC_PAD_CTRL (PAD_CTL_PKE | PAD_CTL_PUE |		\
-	PAD_CTL_PUS_22K_UP  | PAD_CTL_SPEED_LOW |		\
-	PAD_CTL_DSE_80ohm   | PAD_CTL_SRE_FAST  | PAD_CTL_HYS)
-
-#define USDHC_DAT3_CD_PAD_CTRL (PAD_CTL_PKE | PAD_CTL_PUE |	\
-	PAD_CTL_PUS_100K_DOWN  | PAD_CTL_SPEED_LOW |		\
-	PAD_CTL_DSE_80ohm   | PAD_CTL_SRE_FAST  | PAD_CTL_HYS)
-
 #define I2C_PAD_CTRL    (PAD_CTL_PKE | PAD_CTL_PUE |            \
 	PAD_CTL_PUS_100K_UP | PAD_CTL_SPEED_MED |               \
 	PAD_CTL_DSE_40ohm | PAD_CTL_HYS |			\
@@ -112,67 +104,6 @@ static iomux_v3_cfg_t const uart1_pads[] = {
 	MX6_PAD_UART1_RX_DATA__UART1_DCE_RX | MUX_PAD_CTRL(UART_PAD_CTRL),
 };
 
-static iomux_v3_cfg_t const usdhc1_pads[] = {
-	MX6_PAD_SD1_CLK__USDHC1_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_SD1_CMD__USDHC1_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_SD1_DATA0__USDHC1_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_SD1_DATA1__USDHC1_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_SD1_DATA2__USDHC1_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_SD1_DATA3__USDHC1_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-
-	/* VSELECT */
-	MX6_PAD_GPIO1_IO05__USDHC1_VSELECT | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	/* CD */
-	MX6_PAD_UART1_RTS_B__GPIO1_IO19 | MUX_PAD_CTRL(NO_PAD_CTRL),
-	/* RST_B */
-	MX6_PAD_GPIO1_IO09__GPIO1_IO09 | MUX_PAD_CTRL(NO_PAD_CTRL),
-};
-
-/*
- * mx6ul_14x14_evk board default supports sd card. If want to use
- * EMMC, need to do board rework for sd2.
- * Introduce CONFIG_MX6UL_14X14_EVK_EMMC_REWORK, if sd2 reworked to support
- * emmc, need to define this macro.
- */
-#if defined(CONFIG_MX6UL_14X14_EVK_EMMC_REWORK)
-static iomux_v3_cfg_t const usdhc2_emmc_pads[] = {
-	MX6_PAD_NAND_RE_B__USDHC2_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_WE_B__USDHC2_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA00__USDHC2_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA01__USDHC2_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA02__USDHC2_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA03__USDHC2_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA04__USDHC2_DATA4 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA05__USDHC2_DATA5 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA06__USDHC2_DATA6 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA07__USDHC2_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-
-	/*
-	 * RST_B
-	 */
-	MX6_PAD_NAND_ALE__GPIO4_IO10 | MUX_PAD_CTRL(NO_PAD_CTRL),
-};
-#else
-static iomux_v3_cfg_t const usdhc2_pads[] = {
-	MX6_PAD_NAND_RE_B__USDHC2_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_WE_B__USDHC2_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA00__USDHC2_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA01__USDHC2_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA02__USDHC2_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-	MX6_PAD_NAND_DATA03__USDHC2_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
-};
-
-/*
- * The evk board uses DAT3 to detect CD card plugin,
- * in u-boot we mux the pin to GPIO when doing board_mmc_getcd.
- */
-static iomux_v3_cfg_t const usdhc2_cd_pad =
-	MX6_PAD_NAND_DATA03__GPIO4_IO05 | MUX_PAD_CTRL(USDHC_DAT3_CD_PAD_CTRL);
-
-static iomux_v3_cfg_t const usdhc2_dat3_pad =
-	MX6_PAD_NAND_DATA03__USDHC2_DATA3 |
-	MUX_PAD_CTRL(USDHC_DAT3_CD_PAD_CTRL);
-#endif
 
 static void setup_iomux_uart(void)
 {
@@ -189,101 +120,35 @@ static int board_qspi_init(void)
 }
 #endif
 
-#ifdef CONFIG_FSL_ESDHC_IMX
-static struct fsl_esdhc_cfg usdhc_cfg[2] = {
-	{USDHC1_BASE_ADDR, 0, 4},
-#if defined(CONFIG_MX6UL_14X14_EVK_EMMC_REWORK)
-	{USDHC2_BASE_ADDR, 0, 8},
-#else
-	{USDHC2_BASE_ADDR, 0, 4},
-#endif
+#ifdef CONFIG_SPL_BUILD
+
+#define USDHC_PAD_CTRL (PAD_CTL_PKE | PAD_CTL_PUE |		\
+	PAD_CTL_PUS_22K_UP  | PAD_CTL_SPEED_LOW |		\
+	PAD_CTL_DSE_80ohm   | PAD_CTL_SRE_FAST  | PAD_CTL_HYS)
+
+static iomux_v3_cfg_t const usdhc2_pads[] = {
+	MX6_PAD_NAND_RE_B__USDHC2_CLK | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_NAND_WE_B__USDHC2_CMD | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_NAND_DATA00__USDHC2_DATA0 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_NAND_DATA01__USDHC2_DATA1 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_NAND_DATA02__USDHC2_DATA2 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
+	MX6_PAD_NAND_DATA03__USDHC2_DATA3 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 };
 
-#define USDHC1_CD_GPIO	IMX_GPIO_NR(1, 19)
-#define USDHC1_PWR_GPIO	IMX_GPIO_NR(1, 9)
-#define USDHC2_CD_GPIO	IMX_GPIO_NR(4, 5)
-#define USDHC2_PWR_GPIO	IMX_GPIO_NR(4, 10)
+static struct fsl_esdhc_cfg usdhc_cfg[1] = {
+	{USDHC2_BASE_ADDR, 0, 4},
+};
 
 int board_mmc_getcd(struct mmc *mmc)
 {
-	struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
-	int ret = 0;
-
-	switch (cfg->esdhc_base) {
-	case USDHC1_BASE_ADDR:
-		ret = !gpio_get_value(USDHC1_CD_GPIO);
-		break;
-	case USDHC2_BASE_ADDR:
-#if defined(CONFIG_MX6UL_14X14_EVK_EMMC_REWORK)
-		ret = 1;
-#else
-		imx_iomux_v3_setup_pad(usdhc2_cd_pad);
-		gpio_request(USDHC2_CD_GPIO, "usdhc2 cd");
-		gpio_direction_input(USDHC2_CD_GPIO);
-
-		/*
-		 * Since it is the DAT3 pin, this pin is pulled to
-		 * low voltage if no card
-		 */
-		ret = gpio_get_value(USDHC2_CD_GPIO);
-
-		imx_iomux_v3_setup_pad(usdhc2_dat3_pad);
-#endif
-		break;
-	}
-
-	return ret;
+	return 1;
 }
 
 int board_mmc_init(bd_t *bis)
 {
-	int i, ret;
-
-	/*
-	 * According to the board_mmc_init() the following map is done:
-	 * (U-Boot device node)    (Physical Port)
-	 * mmc0                    USDHC1
-	 * mmc1                    USDHC2
-	 */
-	for (i = 0; i < CONFIG_SYS_FSL_USDHC_NUM; i++) {
-		switch (i) {
-		case 0:
-			imx_iomux_v3_setup_multiple_pads(
-				usdhc1_pads, ARRAY_SIZE(usdhc1_pads));
-			gpio_request(USDHC1_CD_GPIO, "usdhc1 cd");
-			gpio_direction_input(USDHC1_CD_GPIO);
-			usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
-
-			gpio_direction_output(USDHC1_PWR_GPIO, 0);
-			udelay(500);
-			gpio_direction_output(USDHC1_PWR_GPIO, 1);
-			break;
-		case 1:
-#if defined(CONFIG_MX6UL_14X14_EVK_EMMC_REWORK)
-			imx_iomux_v3_setup_multiple_pads(
-				usdhc2_emmc_pads, ARRAY_SIZE(usdhc2_emmc_pads));
-#else
-			imx_iomux_v3_setup_multiple_pads(
-				usdhc2_pads, ARRAY_SIZE(usdhc2_pads));
-#endif
-			gpio_request(USDHC2_PWR_GPIO, "usdhc2 pwr");
-			gpio_direction_output(USDHC2_PWR_GPIO, 0);
-			udelay(500);
-			gpio_direction_output(USDHC2_PWR_GPIO, 1);
-			usdhc_cfg[1].sdhc_clk = mxc_get_clock(MXC_ESDHC2_CLK);
-			break;
-		default:
-			printf("Warning: you configured more USDHC controllers (%d) than supported by the board\n", i + 1);
-			return -EINVAL;
-			}
-
-			ret = fsl_esdhc_initialize(bis, &usdhc_cfg[i]);
-			if (ret) {
-				printf("Warning: failed to initialize mmc dev %d\n", i);
-				return ret;
-			}
-	}
-	return 0;
+	imx_iomux_v3_setup_multiple_pads(usdhc2_pads, ARRAY_SIZE(usdhc2_pads));
+	usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC2_CLK);
+	return fsl_esdhc_initialize(bis, &usdhc_cfg[0]);
 }
 #endif
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 mx6ul_14x14_evk: Fix SPL hang

Quoted 18 lines · Fabio Estevam

Currently the following SPL hang is observed:

U-Boot SPL 2020.01-rc5-00079-g797eee36a1 (Jan 06 2020 - 11:24:09 -0300) Trying to boot from MMC1
Card did not respond to voltage select!
spl: mmc init failed with error: -95
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

Fix it by moving the eSDHC1 initialization to SPL.

While at it, since this board uses DM_MMC all the esdhc board code can be removed.

---
Hi,

Quoted 7 lines

Still get the following "no card present" error in U-Boot proper:

MMC: FSL_SDHC: 0, FSL_SDHC: 1
Loading Environment from MMC... MMC: no card present *** Warning - No block device, using default environment

but this should be treated separately.

Should this come in for the 2020.01 release then? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200106/782446a8/attachment.sig>
#2 lore raw

PATCH 1/1 mx6ul_14x14_evk: Fix SPL hang

Hi Tom,

Quoted 1 line · Tom Rini

Should this come in for the 2020.01 release then? Thanks!

I don't have the U-Boot proper fix yet, so I think this patch can wait and go into 2020.04.

Thanks

#3 lore raw

PATCH 1/1 mx6ul_14x14_evk: Fix SPL hang

Hi Tom,

Quoted 2 lines · Fabio Estevam

I don't have the U-Boot proper fix yet, so I think this patch can wait and go into 2020.04.

I managed to fix the card detection problem in U-Boot proper and have just sent a patch series.

Thanks

#4 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hi Fabio!

happy new year! Hope you are fine?

I just builded the newest mainline U-Boot code for the wandboard, and I get:

U-Boot SPL 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100) Trying to boot from MMC1

U-Boot 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  pmic_get() ret -19
MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0
Loading Environment from MMC... OK
In:    serial
Out:   serial
Err:   serial
Model: Wandboard i.MX6 Dual Lite Board rev B1
Board: Wandboard rev B1
Net:   Could not get PHY for FEC0: addr 1
Could not get PHY for FEC0: addr 1

No ethernet found.

Hit any key to stop autoboot: 0
=>

Ethernet does not work, also pmic setup seems buggy... Hmm pmic is not detected, and later board revision is B1 instead D1... I think thats the root cause of the problem...

Attached a bootlog from an older, working version [1].

Ok, I tried to bisect it, but bisecting does not work, as there are commits, which does not build for wandboard :-(

Looking into git history, there is a commit from you:

commit 5b858582512883b8a85d74e108873f9beed1e954

Author: Fabio Estevam <[email protected]>
Date:   Wed Jun 12 12:34:40 2019 -0300

wandboard: Add FIT image support

After the transition to DM, only the mx6dl/solo wandboard is supported.

Add FIT image support so that all the wandboard variants can be supported, like it was prior to the DM conversion.

Successfully booted Linux on mx6q/solo/qp wandboards.

So it worked for you? I flashed the u-boot-fit-dtb.bin instead of u-boot-dtb.bin, but this leads to:

resetting ...

U-Boot SPL 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:25:09 +0100) Trying to boot from MMC1
mmc_load_image_raw_sector: mmc block read error
spl: ext4fs_open failed
spl_load_image_ext: error reading image u-boot-dtb.img, err - -1
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

Same with u-boot-with-spl.imx flashed.

I am sure I make here something wrong... any ideas?

Attached also a working bootlog with an older version [1].

Thanks!

bye,
Heiko

[1] working U-Boot bootlog:
U-Boot SPL 2019.04-rc4-tbot-00111-gab8fc41 (Jan 08 2020 - 06:18:50 +0100) Trying to boot from MMC1

U-Boot 2019.04-rc4-tbot-00111-gab8fc41 (Jan 08 2020 - 06:18:50 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
I2C:   ready
DRAM:  1 GiB
PMIC:  PFUZE100 ID=0x10
MMC:   FSL_SDHC: 0, FSL_SDHC: 1
Loading Environment from MMC... OK
No panel detected: default to HDMI
Display: HDMI (1024x768)
In:    serial
Out:   serial
Err:   serial
Board: Wandboard rev D1
Net:   FEC [PRIME]
Hit any key to stop autoboot:  0

=>

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#5 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hi Heiko,

Quoted 12 lines · Heiko Schocher

Hi Fabio!

happy new year! Hope you are fine?

I just builded the newest mainline U-Boot code for the wandboard, and I get:

U-Boot SPL 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100) Trying to boot from MMC1

Quoted 6 lines

U-Boot 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  pmic_get() ret -19

I have already fixed this PMIC issue. Please try this series:
https://lists.denx.de/pipermail/u-boot/2019-December/393500.html

I thought it would reach 2020.01, but apparently it did not.

Regards,

Fabio Estevam

#7 lore raw

U-Boot: wandboard ethernet problem with newest mainline

In reply to Fabio Estevam

Hi Fabio, Heiko,

Quoted 22 lines · Fabio Estevam

Hi Heiko,

Quoted 12 lines · Heiko Schocher

Hi Fabio!

happy new year! Hope you are fine?

I just builded the newest mainline U-Boot code for the wandboard, and I get:

U-Boot SPL 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100) Trying to boot from MMC1

Quoted 6 lines

U-Boot 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  pmic_get() ret -19
Quoted 5 lines

I have already fixed this PMIC issue. Please try this series:
https://lists.denx.de/pipermail/u-boot/2019-December/393500.html

I thought it would reach 2020.01, but apparently it did not.

Indeed, I am sure I have already worked and merged the series, but I cannot find them, no idea why. I can just apply them now and push on -master :-(

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#8 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hello Stefano, Fabio,

Am 08.01.2020 um 10:54 schrieb Stefano Babic:

Quoted 28 lines

Hi Fabio, Heiko,

Quoted 25 lines · Fabio Estevam

Hi Heiko,

Quoted 12 lines · Heiko Schocher

Hi Fabio!

happy new year! Hope you are fine?

I just builded the newest mainline U-Boot code for the wandboard, and I get:

U-Boot SPL 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100) Trying to boot from MMC1

Quoted 6 lines

U-Boot 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  pmic_get() ret -19

I have already fixed this PMIC issue. Please try this series:
https://lists.denx.de/pipermail/u-boot/2019-December/393500.html

Quoted 6 lines
Quoted 2 lines

I thought it would reach 2020.01, but apparently it did not.

Indeed, I am sure I have already worked and merged the series, but I cannot find them, no idea why. I can just apply them now and push on -master :-(

With this patch I see the same issue:

U-Boot SPL 2020.01-tbot-00273-g877a689 (Jan 08 2020 - 11:05:27 +0100) Trying to boot from MMC1

U-Boot 2020.01-tbot-00273-g877a689 (Jan 08 2020 - 11:05:27 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  pmic_get() ret -19
MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0

Loading Environment from MMC... *** Warning - bad CRC, using default environment

No panel detected: default to HDMI
Display: HDMI (1024x768)
In:    serial
Out:   serial
Err:   serial
Model: Wandboard i.MX6 Dual Lite Board rev B1
Board: Wandboard rev B1
Net:   Could not get PHY for FEC0: addr 1

No ethernet found.

Hit any key to stop autoboot: 0
=>

I try to dig into it ...

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#9 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hello Fabio,

Am 08.01.2020 um 11:11 schrieb Heiko Schocher:

Quoted 63 lines

Hello Stefano, Fabio,

Am 08.01.2020 um 10:54 schrieb Stefano Babic:

Quoted 28 lines

Hi Fabio, Heiko,

Quoted 25 lines · Fabio Estevam

Hi Heiko,

Quoted 12 lines · Heiko Schocher

Hi Fabio!

happy new year! Hope you are fine?

I just builded the newest mainline U-Boot code for the wandboard, and I get:

U-Boot SPL 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100) Trying to boot from MMC1

Quoted 6 lines

U-Boot 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:33:42 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  pmic_get() ret -19

I have already fixed this PMIC issue. Please try this series:
https://lists.denx.de/pipermail/u-boot/2019-December/393500.html

Quoted 6 lines
Quoted 2 lines

I thought it would reach 2020.01, but apparently it did not.

Indeed, I am sure I have already worked and merged the series, but I cannot find them, no idea why. I can just apply them now and push on -master :-(

With this patch I see the same issue:

U-Boot SPL 2020.01-tbot-00273-g877a689 (Jan 08 2020 - 11:05:27 +0100) Trying to boot from MMC1

U-Boot 2020.01-tbot-00273-g877a689 (Jan 08 2020 - 11:05:27 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  pmic_get() ret -19
MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0
Loading Environment from MMC... *** Warning - bad CRC, using default environment

No panel detected: default to HDMI
Display: HDMI (1024x768)
In:    serial
Out:   serial
Err:   serial
Model: Wandboard i.MX6 Dual Lite Board rev B1
Board: Wandboard rev B1
Net:   Could not get PHY for FEC0: addr 1
No ethernet found.

Quoted 4 lines

Hit any key to stop autoboot:  0
=>

I try to dig into it ...

Hmm... current try (remove all other dts from image):

configs/wandboard_defconfig +2 -2
index ca564c5..62b013c 100644
@@ -42,8 +42,8 @@ CONFIG_CMD_BMP=y
  CONFIG_CMD_CACHE=y
  CONFIG_CMD_EXT4_WRITE=y
  CONFIG_OF_CONTROL=y
-CONFIG_DEFAULT_DEVICE_TREE="imx6dl-wandboard-revb1"
-CONFIG_OF_LIST="imx6q-wandboard-revb1 imx6qp-wandboard-revd1 imx6dl-wandboard-revb1"
+CONFIG_DEFAULT_DEVICE_TREE="imx6qp-wandboard-revd1"
+CONFIG_OF_LIST="imx6qp-wandboard-revd1"
  CONFIG_MULTI_DTB_FIT=y
  CONFIG_ENV_IS_IN_MMC=y
  CONFIG_SYS_RELOC_GD_ENV_ADDR=y

and with your patch applied, I see on the console:

resetting ...

U-Boot SPL 2020.01-tbot-00275-gae9089a (Jan 08 2020 - 11:53:10 +0100) Trying to boot from MMC1

U-Boot 2020.01-tbot-00275-gae9089a (Jan 08 2020 - 11:53:10 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  PMIC:  PFUZE100 ID=0x10
MMC:   [    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 4.20.3-jumpnow (oe-user at oe-host) (gcc version 8.2.0 (GCC)) #1 SMP Fri 
Jan 18 17:29:07 UTC 2019
[    0.000000] CPU: ARMv7 Processor [412fc09a] revision 10 (ARMv7), cr=10c5387d
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache

So, PMIC gets now detected, but after "MMC" no output from console ... but it seems, U-Boot boots into linux!

Hmm... looking into board/wandboard/wandboard.c

#ifdef CONFIG_SPL_LOAD_FIT
int board_fit_config_name_match(const char *name)

{
         if (is_mx6dq()) {
                 if (!strcmp(name, "imx6q-wandboard-revb1"))
                         return 0;
         } else if (is_mx6dqp()) {
                 if (!strcmp(name, "imx6qp-wandboard-revd1"))
                         return 0;
         } else if (is_mx6dl() || is_mx6solo()) {
                 if (!strcmp(name, "imx6dl-wandboard-revb1"))
                         return 0;
         }

         return -EINVAL;
}

#endif

On my board is_mx6dl() is true! but it is a revision D1 ... ? It has definitely a pmic at 0x08

May I make something obvious wrong?

Is the content of board/wandboard/README correct?

Thanks in advance!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#10 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hi Heiko,

Quoted 2 lines · Heiko Schocher

On my board is_mx6dl() is true! but it is a revision D1 ... ? It has definitely a pmic at 0x08

I think we need to import the imx6dl-wandboard-d1.dts from kernel to U-Boot and fix the board_fit_config_name_match() logic to take the imx6dl-wandboard-d1 into account.

We will need to use is_revd1() inside board_fit_config_name_match() to fix the detection logic.

Could you try that?

Thanks

#11 lore raw

U-Boot: wandboard ethernet problem with newest mainline

In reply to Heiko Schocher

Hi Heiko,

configs/wandboard_defconfig CONFIG_CMD_BMP=y · line 46

Quoted 12 lines · Heiko Schocher
configs/wandboard_defconfig +2 -2
index ca564c5..62b013c 100644
@@ -42,8 +42,8 @@ CONFIG_CMD_BMP=y
  CONFIG_CMD_CACHE=y
  CONFIG_CMD_EXT4_WRITE=y
  CONFIG_OF_CONTROL=y
-CONFIG_DEFAULT_DEVICE_TREE="imx6dl-wandboard-revb1"
-CONFIG_OF_LIST="imx6q-wandboard-revb1 imx6qp-wandboard-revd1 imx6dl-wandboard-revb1"
+CONFIG_DEFAULT_DEVICE_TREE="imx6qp-wandboard-revd1"
+CONFIG_OF_LIST="imx6qp-wandboard-revd1"

Here you mark only the imx6qp board, but yours is a imx6dl, so that's why the U-Boot console did not show up :-)

#12 lore raw

U-Boot: wandboard ethernet problem with newest mainline

In reply to Heiko Schocher

Hi Heiko,

Quoted 11 lines · Heiko Schocher

Looking into git history, there is a commit from you:

commit 5b858582512883b8a85d74e108873f9beed1e954

Author: Fabio Estevam <[email protected]>
Date:   Wed Jun 12 12:34:40 2019 -0300

wandboard: Add FIT image support

After the transition to DM, only the mx6dl/solo wandboard is supported.

Quoted 7 lines

Add FIT image support so that all the wandboard variants can be supported, like it was prior to the DM conversion.

Successfully booted Linux on mx6q/solo/qp wandboards.

So it worked for you? I flashed the u-boot-fit-dtb.bin instead of u-boot-dtb.bin, but this leads to:

Just tested the latest u-boot-imx, which contains the PMIC fix and booting a imx6qp-wandboard-revd1 works fine:
http://code.bulix.org/pncucj-1073321

This is the only revd1 wandboard I have access to.

I flashed the SD card as per the board/wandboard/README instructions.

Ethernet is also functional in U-Boot.

The support for imx6q-wandboard-revd1 and imx6dl-wandboard-revd1 still needs to be added (it used to work prior to the DM conversion as you noticed), but unfortunately I don't have access to these variants.

Regards,

Fabio Estevam

Quoted 50 lines

resetting ...

U-Boot SPL 2020.01-tbot-00271-gd8a3f52 (Jan 08 2020 - 06:25:09 +0100) Trying to boot from MMC1
mmc_load_image_raw_sector: mmc block read error
spl: ext4fs_open failed
spl_load_image_ext: error reading image u-boot-dtb.img, err - -1
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

Same with u-boot-with-spl.imx flashed.

I am sure I make here something wrong... any ideas?

Attached also a working bootlog with an older version [1].

Thanks!

bye,
Heiko

[1] working U-Boot bootlog:
U-Boot SPL 2019.04-rc4-tbot-00111-gab8fc41 (Jan 08 2020 - 06:18:50 +0100) Trying to boot from MMC1

U-Boot 2019.04-rc4-tbot-00111-gab8fc41 (Jan 08 2020 - 06:18:50 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
I2C:   ready
DRAM:  1 GiB
PMIC:  PFUZE100 ID=0x10
MMC:   FSL_SDHC: 0, FSL_SDHC: 1
Loading Environment from MMC... OK
No panel detected: default to HDMI
Display: HDMI (1024x768)
In:    serial
Out:   serial
Err:   serial
Board: Wandboard rev D1
Net:   FEC [PRIME]
Hit any key to stop autoboot:  0

=>

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de

#13 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hi Heiko,

Quoted 3 lines · Fabio Estevam

The support for imx6q-wandboard-revd1 and imx6dl-wandboard-revd1 still needs to be added (it used to work prior to the DM conversion as you noticed), but unfortunately I don't have access to these variants.

Could you please try the attached two patches?

I don't have access to a imx6dl-wandboard-revd1 board, but hopefully these two patches would make it to work.

It applies against the latest u-boot-imx tree.

Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wandboardrevd1.patch
Type: text/x-patch
Size: 2625 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200108/94eea987/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-revd1dtb.patch
Type: text/x-patch
Size: 2135 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200108/94eea987/attachment-0001.bin>

#14 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hello Fabio,

Am 08.01.2020 um 21:26 schrieb Fabio Estevam:

Quoted 9 lines

Hi Heiko,

Quoted 3 lines · Fabio Estevam

The support for imx6q-wandboard-revd1 and imx6dl-wandboard-revd1 still needs to be added (it used to work prior to the DM conversion as you noticed), but unfortunately I don't have access to these variants.

Could you please try the attached two patches?

You were faster than I, thanks!

Quoted 2 lines

I don't have access to a imx6dl-wandboard-revd1 board, but hopefully these two patches would make it to work.

Unfortunately they don;t work.

Quoted 1 line

It applies against the latest u-boot-imx tree.

Tried mainline also as u-boot-imx.

But! Additionally setting:

CONFIG_DEFAULT_DEVICE_TREE="imx6dl-wandboard-revd1" CONFIG_OF_LIST="imx6dl-wandboard-revd1"

and U-Boot works again, see [1]!

So we are on the correct direction...

Hmm.. I wonder ... if you want to detect the revd1, you must access the pmic in SPL, so you need a DTS in which it is configured, also DM PMIC support in SPL ... which introduces a lot of dependencies starting with enabling CONFIG_SPL_DM and blows up SPL ... :-(

2 problems I see:

- reorder board_fit_config_name_match

see attached patch: 0001-wandboard-reorder-board_fit_config_name_match.patch

With this patch (based on your patches) and hack [2] U-Boot works also again.

- detect rev D1 board (remaining problem)

board_fit_config_name_match() is called from board_fit_config_name_match, so from SPL where you have no access (yet?) to pmic_get(), and so is_revd1() is always 0 -> which leads to wrong DTB selection.

First question: other possibility to detect revision D1 ?

may only probing the chip is enough ?

Should we use instead CONFIG_DTB_RESELECT ?

This is the way to go I think, added patches:
0002-wandboard-enable-CONFIG_DTB_RESELECT.patch 0003-wandboard-use-imx6dl-wandboard-revd1-as-default-DTB.patch 0004-wandboard-add-u-boot-specific-wandboard-revd1-u-boot.patch 0005-wandboard-in-SPL-use-only-D1-DTB.patch

with them, after a soft reset all works fine, see [3] but on power on I see [4] :-(

Any idea, why after a power on, pmic does not work?

Uff... sorry for the long email ... and may dummy questions.

bye,
Heiko
[1]
U-Boot SPL 2020.01-tbot-00002-g6cd56d3 (Jan 09 2020 - 06:21:00 +0100) Trying to boot from MMC1

U-Boot 2020.01-tbot-00002-g6cd56d3 (Jan 09 2020 - 06:21:00 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
DRAM:  1 GiB
PMIC:  PFUZE100 ID=0x10
MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0

Loading Environment from MMC... *** Warning - bad CRC, using default environment

No panel detected: default to HDMI
Display: HDMI (1024x768)
In:    serial
Out:   serial
Err:   serial
Model: Wandboard i.MX6 Dual Lite Board revD1
Board: Wandboard rev D1

Net:
Warning: ethernet at 2188000 using MAC address from ROM
eth0: ethernet at 2188000
Hit any key to stop autoboot: 0
=>

[2] hack for is_revd1()

board/wandboard/wandboard.c +1 -0
index 4cb9bf6..5c64ab5 100644
@@ -414,6 +414,7 @@ static bool is_revc1(void)
 
  static bool is_revd1(void)
  {
+       with_pmic = 1;
         if (with_pmic)
                 return true;
         else

[3] softreset with patches 1-5
U-Boot SPL 2020.01-tbot-00007-g44f7a02 (Jan 09 2020 - 09:00:27 +0100) Trying to boot from MMC1

U-Boot 2020.01-tbot-00007-g44f7a02 (Jan 09 2020 - 09:00:27 +0100)

CPU:   Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: WDOG
PMIC:  PFUZE100 ID=0x10
DRAM:  1 GiB
PMIC:  PFUZE100 ID=0x10
MMC:   FSL_SDHC: 2, FSL_SDHC: 1, FSL_SDHC: 0

Loading Environment from MMC... *** Warning - bad CRC, using default environment

No panel detected: default to HDMI
Display: HDMI (1024x768)
In:    serial
Out:   serial
Err:   serial
Model: Wandboard i.MX6 Dual Lite Board revD1
Board: Wandboard rev D1

Net:
Warning: ethernet at 2188000 using MAC address from ROM
eth0: ethernet at 2188000
Hit any key to stop autoboot: 0
=>

[4] hard power on
U-Boot SPL 2020.01-tbot-00007-g44f7a02 (Jan 09 2020 - 09:00:27 +0100) Trying to boot from MMC1

U-Boot 2020.01-tbot-00007-g44f7a02 (Jan 09 2020 - 09:00:27 +0100)

CPU: Freescale i.MX6DL rev1.3 at 792 MHz
Reset cause: POR
wait_for_sr_state: failed sr=81 cr=a0 state=2020
i2c_init_transfer: failed for chip 0x8 retry=0
wait_for_sr_state: failed sr=81 cr=a0 state=2020
i2c_init_transfer: failed for chip 0x8 retry=1
wait_for_sr_state: failed sr=81 cr=a0 state=2020
i2c_init_transfer: failed for chip 0x8 retry=2
i2c_init_transfer: give up i2c_regs=0x21a8000
read error from device: 0093e358 register: 0x0!
pmic_reg_read() ret -5

DRAM:  1 GiB
PMIC:  PFUZE100 ID=0x10

[...]

Signature · 38 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-wandboard-add-u-boot-specific-wandboard-revd1-u-boot.patch
Type: text/x-patch
Size: 1511 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200109/220c408b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-wandboard-use-imx6dl-wandboard-revd1-as-default-DTB.patch
Type: text/x-patch
Size: 1128 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200109/220c408b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-wandboard-enable-CONFIG_DTB_RESELECT.patch
Type: text/x-patch
Size: 1810 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200109/220c408b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wandboard-reorder-board_fit_config_name_match.patch
Type: text/x-patch
Size: 1799 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200109/220c408b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-wandboard-in-SPL-use-only-D1-DTB.patch
Type: text/x-patch
Size: 794 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200109/220c408b/attachment-0004.bin>
#15 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hi Heiko,

Quoted 5 lines · Heiko Schocher

Hmm.. I wonder ... if you want to detect the revd1, you must access the pmic in SPL, so you need a DTS in which it is configured, also DM PMIC support in SPL ... which introduces a lot of dependencies starting with enabling CONFIG_SPL_DM and blows up SPL ... :-(

Yes, as we are very memory limited in SPL, so what about just probing the I2C bus directly at 0x8 via I2C API to detect the presence of the PMIC?

This way we do not need DM PMIC support in SPL.

Do we need to mark I2C with 'u-boot,dm-pre-reloc;' too and create a arch/arm/dts/imx6qdl-wandboard-u-boot.dtsi ?

Quoted 10 lines

2 problems I see:

- reorder board_fit_config_name_match

see attached patch: 0001-wandboard-reorder-board_fit_config_name_match.patch

With this patch (based on your patches) and hack [2] U-Boot works also again.

- detect rev D1 board (remaining problem)

Quoted 7 lines

board_fit_config_name_match() is called from board_fit_config_name_match, so from SPL where you have no access (yet?) to pmic_get(), and so is_revd1() is always 0 -> which leads to wrong DTB selection.

First question: other possibility to detect revision D1 ?

may only probing the chip is enough ?

As far as I know probing the PMIC chip is the only way to detect D1.

Quoted 2 lines

Should we use instead CONFIG_DTB_RESELECT ?

Not familiar with CONFIG_DTB_RESELECT, sorry.

Quoted 11 lines

This is the way to go I think, added patches:
0002-wandboard-enable-CONFIG_DTB_RESELECT.patch 0003-wandboard-use-imx6dl-wandboard-revd1-as-default-DTB.patch 0004-wandboard-add-u-boot-specific-wandboard-revd1-u-boot.patch 0005-wandboard-in-SPL-use-only-D1-DTB.patch

with them, after a soft reset all works fine, see [3] but on power on I see [4] :-(

Any idea, why after a power on, pmic does not work?

Interesting, I do not see this behavior with a imx6qp wandboard revd1.

I have seen I2C errors when booting with an HDMI cable connected:
https://lists.denx.de/pipermail/u-boot/2019-December/393503.html

,but haven't had a chance to debug this yet.

Regards,

Fabio Estevam

#16 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hello Fabio,

Am 09.01.2020 um 12:14 schrieb Fabio Estevam:

Quoted 10 lines

Hi Heiko,

Quoted 5 lines · Heiko Schocher

Hmm.. I wonder ... if you want to detect the revd1, you must access the pmic in SPL, so you need a DTS in which it is configured, also DM PMIC support in SPL ... which introduces a lot of dependencies starting with enabling CONFIG_SPL_DM and blows up SPL ... :-(

Quoted 5 lines

Yes, as we are very memory limited in SPL, so what about just probing the I2C bus directly at 0x8 via I2C API to detect the presence of the PMIC?

This way we do not need DM PMIC support in SPL.

Yes, i had such a hack also ...

Quoted 2 lines

Do we need to mark I2C with 'u-boot,dm-pre-reloc;' too and create a arch/arm/dts/imx6qdl-wandboard-u-boot.dtsi ?

see my patches, I added there such u-boot files. Unfortunately a imx6qdl-wandboard-u-boot.dtsi did not worked, I needed 2 files.

Quoted 14 lines
Quoted 14 lines

2 problems I see:

- reorder board_fit_config_name_match

see attached patch: 0001-wandboard-reorder-board_fit_config_name_match.patch

With this patch (based on your patches) and hack [2] U-Boot works also again.

- detect rev D1 board (remaining problem)

board_fit_config_name_match() is called from board_fit_config_name_match, so from SPL where you have no access (yet?) to pmic_get(), and so is_revd1() is always 0 -> which leads to wrong DTB selection.

Quoted 5 lines
Quoted 3 lines

First question: other possibility to detect revision D1 ?

may only probing the chip is enough ?

As far as I know probing the PMIC chip is the only way to detect D1.

Ok, so we must find a way for it ...

Quoted 14 lines
Quoted 1 line

Should we use instead CONFIG_DTB_RESELECT ?

Not familiar with CONFIG_DTB_RESELECT, sorry.

Quoted 10 lines

This is the way to go I think, added patches:
0002-wandboard-enable-CONFIG_DTB_RESELECT.patch 0003-wandboard-use-imx6dl-wandboard-revd1-as-default-DTB.patch 0004-wandboard-add-u-boot-specific-wandboard-revd1-u-boot.patch 0005-wandboard-in-SPL-use-only-D1-DTB.patch

with them, after a soft reset all works fine, see [3] but on power on I see [4] :-(

Quoted 8 lines
Quoted 1 line

Any idea, why after a power on, pmic does not work?

Interesting, I do not see this behavior with a imx6qp wandboard revd1.

I have seen I2C errors when booting with an HDMI cable connected:
https://lists.denx.de/pipermail/u-boot/2019-December/393503.html

,but haven't had a chance to debug this yet.

Ok, may I find more time for it...

If you have time, may I can ask, if you can test my patches, if they do not break other board revisions?

Many thanks!

bye,
Heiko

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de
#17 lore raw

U-Boot: wandboard ethernet problem with newest mainline

Hi Heiko,

Quoted 2 lines · Heiko Schocher

If you have time, may I can ask, if you can test my patches, if they do not break other board revisions?

I haven't had a chance to look at your patches yet, but could you please submit the whole series to the list?

I will try to review and test them next week.

Thanks