Skip to contentSkip to conversation

hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus

PATCH Applied Philippe Mathieu-Daudé 2 participants 2 messages Jan 6, 2020 – Jan 7, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/timer/Kconfig: Intel 8254 PIT depends of ISA bus

Since i8254_common.c calls isa_register_ioport() from "hw/isa/isa.h" we can not select it when ISA_BUS is disabled. Add a 'depends on' clause.

---
 hw/timer/Kconfig | 1 +
 1 file changed, 1 insertion(+)
hw/timer/Kconfig +1 -0
index a990f9fe35..59b3f44d69 100644
@@ -15,6 +15,7 @@ config HPET
 
 config I8254
     bool
+    depends on ISA_BUS
 
 config ALTERA_TIMER
     bool
Signature · 1 line
2.21.1
#1 lore raw
Quoted 15 lines · Philippe Mathieu-Daudé

Since i8254_common.c calls isa_register_ioport() from "hw/isa/isa.h" we can not select it when ISA_BUS is disabled. Add a 'depends on' clause.

---
 hw/timer/Kconfig | 1 +
 1 file changed, 1 insertion(+)
hw/timer/Kconfig +0 -0
index a990f9fe35..59b3f44d69 100644

hw/timer/Kconfig config HPET · line 21

Quoted 7 lines
hw/timer/Kconfig +1 -0
@@ -15,6 +15,7 @@ config HPET
 
 config I8254
     bool
+    depends on ISA_BUS
 
 config ALTERA_TIMER
     bool

Queued, thanks.

Paolo