tty: st-asc: switch to using devm_gpiod_get()
Subsystems (2)
PATCH 1/1 tty: st-asc: switch to using devm_gpiod_get()
The node pointer in question is not a child node, but the node assigned to the port device itself, so we should not be using devm_fwnode_get_gpiod_from_child() [that is going away], but standard devm_gpiod_get().
To maintain the previous labeling we use gpiod_set_consumer_name() after we acquire the GPIO.
--- drivers/tty/serial/st-asc.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/tty/serial/st-asc.c +5 -7
@@ -504,7 +504,6 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios, struct ktermios *old) {struct asc_port *ascport =to_asc_port (port); -struct device_node *np = port->dev->of_node;struct gpio_desc *gpiod;unsigned int baud;u32 ctrl_val;
@@ -566,13 +565,12 @@ static void asc_set_termios(struct uart_port *port, struct ktermios *termios,pinctrl_select_state (ascport->pinctrl, ascport->states[NO_HW_FLOWCTRL ]); - gpiod =devm_fwnode_get_gpiod_from_child (port->dev, -"rts" , - &np->fwnode, -GPIOD_OUT_LOW , - np->name); -if (!IS_ERR (gpiod)) + gpiod =devm_gpiod_get (port->dev,"rts" ,GPIOD_OUT_LOW ); +if (!IS_ERR (gpiod)) { +gpiod_set_consumer_name (gpiod, + port->dev->of_node->name); ascport->rts = gpiod; + } } }
Signature · 5 lines
2.24.1.735.g03f4e72817-goog -- Dmitry
Greg Kroah-Hartman
maintainerQuoted 5 lines · Dmitry Torokhov
The node pointer in question is not a child node, but the node assigned to the port device itself, so we should not be using
devm_fwnode_get_gpiod_from_child()[that is going away], but standarddevm_gpiod_get().
Quoted 7 lines
To maintain the previous labeling we use
gpiod_set_consumer_name()after we acquire the GPIO.Signed-off-by Dmitry Torokhov <[email protected]>--- drivers/tty/serial/st-asc.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
What changed from v1 of this patch? Please put that below the --- line and versino your patches.
v3?
thanks,
greg k-h
Quoted 9 lines · Greg Kroah-Hartman
Quoted 8 lines · Dmitry Torokhov
The node pointer in question is not a child node, but the node assigned to the port device itself, so we should not be using
devm_fwnode_get_gpiod_from_child()[that is going away], but standarddevm_gpiod_get().To maintain the previous labeling we use
gpiod_set_consumer_name()after we acquire the GPIO.
Quoted 7 lines
Quoted 4 lines
Signed-off-by Dmitry Torokhov <[email protected]>--- drivers/tty/serial/st-asc.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)What changed from v1 of this patch? Please put that below the --- line and versino your patches.
I did not add a version or changelog because I believe this is essentially a different patch, with different justification and different API that is being used.
The first one was a simple switch to devm_fwnode_gpiod_get(), the new one is abandoning the use of explicit node reference, and instead uses standard devm_gpiod_get() to get a GPIO assigned to a device + gpiod_set_consumer_name() to maintain the naming.
Thanks.
Signature · 1 line
Dmitry