drm/i915/gtt: split up i915_gem_gtt
PATCH 1/1 drm/i915/gtt: split up i915_gem_gtt
Attempt to split i915_gem_gtt.[ch] into more manageable chunks.
--- drivers/gpu/drm/i915/Makefile | 5 + drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 + drivers/gpu/drm/i915/gem/i915_gem_context.h | 1 - drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 498 +++ drivers/gpu/drm/i915/gt/gen6_ppgtt.h | 79 + drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 715 ++++ drivers/gpu/drm/i915/gt/gen8_ppgtt.h | 13 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 1402 +++++++ drivers/gpu/drm/i915/gt/intel_gtt.c | 716 ++++ drivers/gpu/drm/i915/gt/intel_gtt.h | 714 ++++ drivers/gpu/drm/i915/gt/intel_ppgtt.c | 226 + .../gpu/drm/i915/gt/intel_ring_submission.c | 2 + drivers/gpu/drm/i915/i915_gem_gtt.c | 3624 +---------------- drivers/gpu/drm/i915/i915_gem_gtt.h | 628 +-- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 3 +- drivers/gpu/drm/i915/selftests/mock_gtt.c | 9 +- 16 files changed, 4418 insertions(+), 4218 deletions(-) create mode 100644 drivers/gpu/drm/i915/gt/gen6_ppgtt.c create mode 100644 drivers/gpu/drm/i915/gt/gen6_ppgtt.h create mode 100644 drivers/gpu/drm/i915/gt/gen8_ppgtt.c create mode 100644 drivers/gpu/drm/i915/gt/gen8_ppgtt.h create mode 100644 drivers/gpu/drm/i915/gt/intel_ggtt.c create mode 100644 drivers/gpu/drm/i915/gt/intel_gtt.c create mode 100644 drivers/gpu/drm/i915/gt/intel_gtt.h create mode 100644 drivers/gpu/drm/i915/gt/intel_ppgtt.c
drivers/gpu/drm/i915/Makefile +5 -0
@@ -74,6 +74,8 @@ gt-y += \ gt/debugfs_engines.o \ gt/debugfs_gt.o \ gt/debugfs_gt_pm.o \ + gt/gen6_ppgtt.o \ + gt/gen8_ppgtt.o \ gt/intel_breadcrumbs.o \ gt/intel_context.o \ gt/intel_engine_cs.o \
@@ -82,6 +84,8 @@ gt-y += \ gt/intel_engine_pool.o \ gt/intel_engine_user.o \ gt/intel_gt.o \ + gt/intel_ggtt.o \ + gt/intel_gtt.o \ gt/intel_gt_irq.o \ gt/intel_gt_pm.o \ gt/intel_gt_pm_irq.o \
@@ -89,6 +93,7 @@ gt-y += \ gt/intel_llc.o \ gt/intel_lrc.o \ gt/intel_mocs.o \ + gt/intel_ppgtt.o \ gt/intel_rc6.o \ gt/intel_renderstate.o \ gt/intel_reset.o \
drivers/gpu/drm/i915/gem/i915_gem_context.c +1 -0
@@ -69,6 +69,7 @@#include <drm/i915_drm.h> +#include "gt/gen6_ppgtt.h" #include "gt/intel_context.h" #include "gt/intel_engine_heartbeat.h" #include "gt/intel_engine_pm.h"
drivers/gpu/drm/i915/gem/i915_gem_context.h +0 -1
@@ -13,7 +13,6 @@#include "i915_drv.h" #include "i915_gem.h" -#include "i915_gem_gtt.h" #include "i915_scheduler.h" #include "intel_device_info.h"
drivers/gpu/drm/i915/gt/gen6_ppgtt.c new file +498 -0
498 lines not on this page · raw message
drivers/gpu/drm/i915/gt/gen6_ppgtt.h new file +79 -0
79 lines not on this page · raw message
drivers/gpu/drm/i915/gt/gen8_ppgtt.c new file +715 -0
715 lines not on this page · raw message
drivers/gpu/drm/i915/gt/gen8_ppgtt.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2020 Intel Corporation +*/ + +#ifndef __GEN8_PPGTT_H__ +#define __GEN8_PPGTT_H__ + +struct drm_i915_private ; + +struct i915_ppgtt *gen8_ppgtt_create (struct drm_i915_private *i915); + +#endif
drivers/gpu/drm/i915/gt/intel_ggtt.c new file +1402 -0
1,402 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_gtt.c new file +716 -0
256 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_gtt.h new file +714 -0
714 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_ppgtt.c new file +226 -0
226 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_ring_submission.c +2 -0
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/i915/i915_gem_gtt.c +34 -3590
3,624 lines not on this page · raw message
drivers/gpu/drm/i915/i915_gem_gtt.h +4 -624
628 lines not on this page · raw message
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +2 -1
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/i915/selftests/mock_gtt.c +7 -2
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Part of the diff is not shown here. View the raw message.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: split up i915_gem_gtt
== Series Details ==
== Series Details ==
Series: drm/i915/gtt: split up i915_gem_gtt
URL : https://patchwork.freedesktop.org/series/71678/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip f96decd69a0e drm/i915/gtt: split up i915_gem_gtt -:67: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #67: new file mode 100644
-:86: WARNING:INCLUDE_LINUX: Use #include <linux/smp.h> instead of <asm/smp.h> #86: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:15:
+#include <asm/smp.h>
-:210: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #210: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:139:
+ unsigned first_entry = vma->node.start / I915_GTT_PAGE_SIZE;
-:211: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #211: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:140:
+ unsigned act_pt = first_entry / GEN6_PTES;
-:212: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #212: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:141:
+ unsigned act_pte = first_entry % GEN6_PTES;
-:258: WARNING:MEMORY_BARRIER: memory barrier without comment #258: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:187:
+ mb();
-:261: WARNING:MEMORY_BARRIER: memory barrier without comment #261: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:190:
+ mb();
-:489: WARNING:BRACES: braces {} are not necessary for single statement blocks #489: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:418:
+ if (!atomic_read(&ppgtt->pin_count)) {
+ err = i915_ggtt_pin(ppgtt->vma, GEN6_PD_ALIGN, PIN_HIGH);
+ }
-:589: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #589: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:14:
+ struct mutex flush;
-:594: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #594: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:19:
+ struct mutex pin_mutex;
-:599: CHECK:LINE_SPACING: Please don't use multiple blank lines #599: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:24:
+
+
-:615: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'base' - possible side-effects? #615: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:40:
+#define __to_gen6_ppgtt(base) container_of(base, struct gen6_ppgtt, base)
-:631: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'start' - possible side-effects? #631: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:56:
+#define gen6_for_each_pde(pt, pd, start, length, iter) \
+ for (iter = gen6_pde_index(start); \
+ length > 0 && iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
+ temp = min(temp - start, length); \
+ start += temp, length -= temp; }), ++iter)-:631: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'length' - possible side-effects? #631: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:56:
+#define gen6_for_each_pde(pt, pd, start, length, iter) \
+ for (iter = gen6_pde_index(start); \
+ length > 0 && iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
+ temp = min(temp - start, length); \
+ start += temp, length -= temp; }), ++iter)-:631: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'length' may be better as '(length)' to avoid precedence issues #631: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:56:
+#define gen6_for_each_pde(pt, pd, start, length, iter) \
+ for (iter = gen6_pde_index(start); \
+ length > 0 && iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
+ temp = min(temp - start, length); \
+ start += temp, length -= temp; }), ++iter)-:631: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #631: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:56:
+#define gen6_for_each_pde(pt, pd, start, length, iter) \
+ for (iter = gen6_pde_index(start); \
+ length > 0 && iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
+ temp = min(temp - start, length); \
+ start += temp, length -= temp; }), ++iter)-:635: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #635: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:60:
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
^
-:639: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #639: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:64:
+#define gen6_for_all_pdes(pt, pd, iter) \
+ for (iter = 0; \
+ iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ++iter)
-:645: CHECK:LINE_SPACING: Please don't use multiple blank lines #645: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:70:
+
+
-:675: WARNING:INCLUDE_LINUX: Use #include <linux/smp.h> instead of <asm/smp.h> #675: FILE: drivers/gpu/drm/i915/gt/gen8_ppgtt.c:15:
+#include <asm/smp.h>
-:693: ERROR:SPACING: spaces required around that '=' (ctx:VxW) #693: FILE: drivers/gpu/drm/i915/gt/gen8_ppgtt.c:33:
+ struct drm_i915_private *dev_priv= ppgtt->vm.i915;
^
-:777: WARNING:LINE_SPACING: Missing a blank line after declarations #777: FILE: drivers/gpu/drm/i915/gt/gen8_ppgtt.c:117:
+ unsigned int shift = __gen8_pte_shift(vm->top);
+ return (vm->total + (1ull << shift) - 1) >> shift;
-:1277: WARNING:MEMORY_BARRIER: memory barrier without comment #1277: FILE: drivers/gpu/drm/i915/gt/gen8_ppgtt.c:617:
+ wmb();
-:1643: WARNING:LINE_SPACING: Missing a blank line after declarations #1643: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:243:
+ dma_addr_t addr;
+ for_each_sgt_daddr(addr, iter, vma->pages)
-:1662: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1662: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:262:
+ unsigned first_entry = start / I915_GTT_PAGE_SIZE;
-:1663: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1663: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:263:
+ unsigned num_entries = length / I915_GTT_PAGE_SIZE;
-:1777: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1777: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:377:
+ unsigned first_entry = start / I915_GTT_PAGE_SIZE;
-:1778: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1778: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:378:
+ unsigned num_entries = length / I915_GTT_PAGE_SIZE;
-:2321: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #2321: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:921:
+ if (ggtt->mappable_end < (64<<20) || ggtt->mappable_end > (512<<20)) {
^
-:2321: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #2321: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:921:
+ if (ggtt->mappable_end < (64<<20) || ggtt->mappable_end > (512<<20)) {
^
-:2384: CHECK:SPACING: No space is necessary after a cast #2384: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:984:
+ (struct resource) DEFINE_RES_MEM(gmadr_base,
-:3009: CHECK:LINE_SPACING: Please don't use multiple blank lines #3009: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:201:
+
+
-:3104: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #3104: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:296:
+int setup_page_dma(struct i915_address_space *vm,
+ struct i915_page_dma *p)
-:3305: WARNING:LINE_SPACING: Missing a blank line after declarations #3305: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:497:
+ u64 pde = _PAGE_PRESENT | _PAGE_RW;
+ pde |= addr;
-:3318: WARNING:LINE_SPACING: Missing a blank line after declarations #3318: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:510:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= GEN6_PTE_ADDR_ENCODE(addr);
-:3340: WARNING:LINE_SPACING: Missing a blank line after declarations #3340: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:532:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= GEN6_PTE_ADDR_ENCODE(addr);
-:3364: WARNING:LINE_SPACING: Missing a blank line after declarations #3364: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:556:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= GEN6_PTE_ADDR_ENCODE(addr);
-:3380: WARNING:LINE_SPACING: Missing a blank line after declarations #3380: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:572:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= HSW_PTE_ADDR_ENCODE(addr);
-:3393: WARNING:LINE_SPACING: Missing a blank line after declarations #3393: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:585:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= HSW_PTE_ADDR_ENCODE(addr);
-:3452: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3452: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:644:
+ * writing this data shouldn't be harmful even in those cases. */
-:3458: WARNING:LONG_LINE_COMMENT: line over 100 characters #3458: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:650:
+ GEN8_PPAT(1, GEN8_PPAT_WC | GEN8_PPAT_LLCELLC) | /* for something pointing to ptes? */
-:3460: WARNING:LONG_LINE_COMMENT: line over 100 characters #3460: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:652:
+ GEN8_PPAT(3, GEN8_PPAT_UC) | /* Uncached objects, mostly for scanout */
-:3598: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #3598: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:68:
+#define GEN6_GTT_ADDR_ENCODE(addr) ((addr) | (((addr) >> 28) & 0xff0))
-:3610: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pde_shift' may be better as '(pde_shift)' to avoid precedence issues #3610: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:80:
+#define NUM_PTE(pde_shift) (1 << (pde_shift - PAGE_SHIFT))
-:3620: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bits' - possible side-effects? #3620: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:90:
+#define HSW_CACHEABILITY_CONTROL(bits) ((((bits) & 0x7) << 1) | \
+ (((bits) & 0x8) << (11 - 3)))
-:3629: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #3629: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:99:
+#define HSW_GTT_ADDR_ENCODE(addr) ((addr) | (((addr) >> 28) & 0x7f0))
-:3650: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3650: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:120:
+#define CHV_PPAT_SNOOP (1<<6)
^
-:3651: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3651: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:121:
+#define GEN8_PPAT_AGE(x) ((x)<<4)
^
-:3652: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3652: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:122:
+#define GEN8_PPAT_LLCeLLC (3<<2)
^
-:3653: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3653: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:123:
+#define GEN8_PPAT_LLCELLC (2<<2)
^
-:3654: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3654: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:124:
+#define GEN8_PPAT_LLC (1<<2)
^
-:3655: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3655: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:125:
+#define GEN8_PPAT_WB (3<<0)
^
-:3656: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3656: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:126:
+#define GEN8_PPAT_WT (2<<0)
^
-:3657: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3657: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:127:
+#define GEN8_PPAT_WC (1<<0)
^
-:3658: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3658: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:128:
+#define GEN8_PPAT_UC (0<<0)
^
-:3659: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3659: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:129:
+#define GEN8_PPAT_ELLC_OVERRIDE (0<<2)
^
-:3757: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #3757: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:227:
+ BUILD_BUG_ON(sizeof(struct intel_rotation_info) != 8*sizeof(unsigned int));
^
-:3759: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #3759: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:229:
+ BUILD_BUG_ON(sizeof(struct intel_remapped_info) != 9*sizeof(unsigned int));
^
-:3814: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #3814: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:284:
+ spinlock_t lock;
-:3825: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'px' - possible side-effects? #3825: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:295:
+#define px_base(px) \
+ __px_choose_expr(px, struct i915_page_dma *, __x, \
+ __px_choose_expr(px, struct i915_page_scratch *, &__x->base, \
+ __px_choose_expr(px, struct i915_page_table *, &__x->base, \
+ __px_choose_expr(px, struct i915_page_directory *, &__x->pt.base, \
+ (void)0))))
-:3833: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'px' - possible side-effects? #3833: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:303:
+#define px_pt(px) \
+ __px_choose_expr(px, struct i915_page_table *, __x, \
+ __px_choose_expr(px, struct i915_page_directory *, &__x->pt, \
+ (void)0))
-:3862: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #3862: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:332:
+ spinlock_t lock;
-:3926: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3926: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:396:
+#define PTE_READ_ONLY (1<<0)
^
-:4095: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #4095: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:565:
+ * GEN6_PTES for GEN6, and GEN8_PTES for GEN8.
+*/
-:4117: CHECK:LINE_SPACING: Please don't use multiple blank lines #4117: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:587:
+
+
-:4433: WARNING:MEMORY_BARRIER: memory barrier without comment #4433: FILE: drivers/gpu/drm/i915/gt/intel_ppgtt.c:183:
+ wmb();
-:4472: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #4472: FILE: drivers/gpu/drm/i915/gt/intel_ppgtt.c:222:
+struct sgt_dma sgt_dma(struct i915_vma *vma) {
-:4475: WARNING:LINE_SPACING: Missing a blank line after declarations #4475: FILE: drivers/gpu/drm/i915/gt/intel_ppgtt.c:225:
+ dma_addr_t addr = sg_dma_address(sg);
+ return (struct sgt_dma) { sg, addr, addr + sg->length };
-:4485: CHECK:LINE_SPACING: Please don't use multiple blank lines #4485: FILE: drivers/gpu/drm/i915/gt/intel_ring_submission.c:36:
+
-:5168: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #5168: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:68:
+ udelay(10);
total: 2 errors, 28 warnings, 40 checks, 8751 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: split up i915_gem_gtt
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915/gtt: split up i915_gem_gtt
URL : https://patchwork.freedesktop.org/series/71678/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7690 -> Patchwork_16010
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/index.html
Known issues
------------
Here are the changes found in Patchwork_16010 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@basic-threads:
- fi-byt-j1900: [PASS][1] -> [TIMEOUT][2] ([i915#816])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/fi-byt-j1900/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/fi-byt-j1900/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-6700k2: [PASS][3] -> [DMESG-WARN][4] ([i915#889])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/fi-skl-6700k2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/fi-skl-6700k2/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- fi-skl-6700k2: [PASS][5] -> [INCOMPLETE][6] ([i915#151])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/fi-skl-6700k2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/fi-skl-6700k2/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-skl-lmem: [INCOMPLETE][7] ([i915#671]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/fi-skl-lmem/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/fi-skl-lmem/igt@[email protected]
* igt@i915_selftest@live_blt:
- fi-byt-n2820: [DMESG-FAIL][9] ([i915#725]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/fi-byt-n2820/igt@i915_selftest@live_blt.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/fi-byt-n2820/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [DMESG-FAIL][11] ([i915#770]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/fi-hsw-4770/igt@i915_selftest@live_blt.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/fi-hsw-4770/igt@i915_selftest@live_blt.html
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#671]: https://gitlab.freedesktop.org/drm/intel/issues/671
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
[i915#816]: https://gitlab.freedesktop.org/drm/intel/issues/816
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
Participating hosts (41 -> 39)
------------------------------
Additional (6): fi-kbl-soraka fi-bsw-n3050 fi-skl-6770hq fi-skl-guc fi-ivb-3770 fi-kbl-r
Missing (8): fi-hsw-4770r fi-hsw-4200u fi-byt-squawks fi-cfl-8700k fi-ctg-p8600 fi-bdw-samus fi-byt-clapper fi-skl-6600u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7690 -> Patchwork_16010
CI-20190529: 20190529
CI_DRM_7690: fc0ff49196d0144e8b72406a8ca71a395dbd7040 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5357: a555a4b98f90dab655d24bb3d07e9291a8b8dac8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16010: f96decd69a0ee1bf6a884ff946ff1dbcf0df44f0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f96decd69a0e drm/i915/gtt: split up i915_gem_gtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Matthew Auld (2020-01-06 23:47:02)
Quoted 5 lines
Attempt to split i915_gem_gtt.[ch] into more manageable chunks.
Suggested-by Chris Wilson <[email protected]>Signed-off-by Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>
A few more exports than I was expecting (possibly suggesting some of those should be common functions), but it looks like what I had in mind. I'll take a closer look to see if we can use those exports to define a saner interface.
After this, the next big job is splitting i915_vma into HW facing and GEM facing.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 drm/i915/gtt: split up i915_gem_gtt
In reply to Matthew AuldFrom: Matthew Auld <[email protected]>
Attempt to split i915_gem_gtt.[ch] into more manageable chunks.
---
A few bits we can polish, but best to land the big move first.
--- drivers/gpu/drm/i915/Makefile | 5 + drivers/gpu/drm/i915/gem/i915_gem_context.c | 5 +- drivers/gpu/drm/i915/gem/i915_gem_context.h | 1 - drivers/gpu/drm/i915/gem/i915_gem_object.h | 1 + .../gpu/drm/i915/gem/selftests/huge_pages.c | 2 +- drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 482 +++ drivers/gpu/drm/i915/gt/gen6_ppgtt.h | 76 + drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 722 ++++ drivers/gpu/drm/i915/gt/gen8_ppgtt.h | 13 + drivers/gpu/drm/i915/gt/intel_ggtt.c | 1495 +++++++ drivers/gpu/drm/i915/gt/intel_gt.c | 2 +- drivers/gpu/drm/i915/gt/intel_gtt.c | 595 +++ drivers/gpu/drm/i915/gt/intel_gtt.h | 581 +++ drivers/gpu/drm/i915/gt/intel_ppgtt.c | 218 + .../gpu/drm/i915/gt/intel_ring_submission.c | 1 + drivers/gpu/drm/i915/gt/selftest_hangcheck.c | 2 +- drivers/gpu/drm/i915/gvt/scheduler.c | 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 3624 +---------------- drivers/gpu/drm/i915/i915_gem_gtt.h | 630 +-- drivers/gpu/drm/i915/i915_vma.h | 140 +- drivers/gpu/drm/i915/i915_vma_types.h | 294 ++ drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 78 +- drivers/gpu/drm/i915/selftests/mock_gtt.c | 9 +- 23 files changed, 4574 insertions(+), 4404 deletions(-) create mode 100644 drivers/gpu/drm/i915/gt/gen6_ppgtt.c create mode 100644 drivers/gpu/drm/i915/gt/gen6_ppgtt.h create mode 100644 drivers/gpu/drm/i915/gt/gen8_ppgtt.c create mode 100644 drivers/gpu/drm/i915/gt/gen8_ppgtt.h create mode 100644 drivers/gpu/drm/i915/gt/intel_ggtt.c create mode 100644 drivers/gpu/drm/i915/gt/intel_gtt.c create mode 100644 drivers/gpu/drm/i915/gt/intel_gtt.h create mode 100644 drivers/gpu/drm/i915/gt/intel_ppgtt.c create mode 100644 drivers/gpu/drm/i915/i915_vma_types.h
drivers/gpu/drm/i915/Makefile +5 -0
@@ -74,6 +74,8 @@ gt-y += \ gt/debugfs_engines.o \ gt/debugfs_gt.o \ gt/debugfs_gt_pm.o \ + gt/gen6_ppgtt.o \ + gt/gen8_ppgtt.o \ gt/intel_breadcrumbs.o \ gt/intel_context.o \ gt/intel_engine_cs.o \
@@ -81,14 +83,17 @@ gt-y += \ gt/intel_engine_pm.o \ gt/intel_engine_pool.o \ gt/intel_engine_user.o \ + gt/intel_ggtt.o \ gt/intel_gt.o \ gt/intel_gt_irq.o \ gt/intel_gt_pm.o \ gt/intel_gt_pm_irq.o \ gt/intel_gt_requests.o \ + gt/intel_gtt.o \ gt/intel_llc.o \ gt/intel_lrc.o \ gt/intel_mocs.o \ + gt/intel_ppgtt.o \ gt/intel_rc6.o \ gt/intel_renderstate.o \ gt/intel_reset.o \
drivers/gpu/drm/i915/gem/i915_gem_context.c +3 -2
@@ -69,6 +69,7 @@#include <drm/i915_drm.h> +#include "gt/gen6_ppgtt.h" #include "gt/intel_context.h" #include "gt/intel_engine_heartbeat.h" #include "gt/intel_engine_pm.h"
@@ -705,7 +706,7 @@ i915_gem_create_context(struct drm_i915_private *i915, unsigned int flags)if (HAS_FULL_PPGTT (i915)) {struct i915_ppgtt *ppgtt; - ppgtt =i915_ppgtt_create (i915); + ppgtt =i915_ppgtt_create (&i915->gt);if (IS_ERR (ppgtt)) {DRM_DEBUG_DRIVER ("PPGTT setup failed (%ld)\n" ,PTR_ERR (ppgtt));
@@ -861,7 +862,7 @@ int i915_gem_vm_create_ioctl(struct drm_device *dev, void *data,if (args->flags)return -EINVAL ; - ppgtt =i915_ppgtt_create (i915); + ppgtt =i915_ppgtt_create (&i915->gt);if (IS_ERR (ppgtt))return PTR_ERR (ppgtt);
drivers/gpu/drm/i915/gem/i915_gem_context.h +0 -1
@@ -13,7 +13,6 @@#include "i915_drv.h" #include "i915_gem.h" -#include "i915_gem_gtt.h" #include "i915_scheduler.h" #include "intel_device_info.h"
drivers/gpu/drm/i915/gem/i915_gem_object.h +1 -0
@@ -16,6 +16,7 @@#include "display/intel_frontbuffer.h" #include "i915_gem_object_types.h" #include "i915_gem_gtt.h" +#include "i915_vma_types.h" void i915_gem_init__objects (struct drm_i915_private *i915);
drivers/gpu/drm/i915/gem/selftests/huge_pages.c +1 -1
@@ -1865,7 +1865,7 @@ int i915_gem_huge_page_mock_selftests(void)mkwrite_device_info (dev_priv)->ppgtt_type =INTEL_PPGTT_FULL ;mkwrite_device_info (dev_priv)->ppgtt_size =48 ; - ppgtt =i915_ppgtt_create (dev_priv); + ppgtt =i915_ppgtt_create (&dev_priv->gt);if (IS_ERR (ppgtt)) { err =PTR_ERR (ppgtt); goto out_unlock;
drivers/gpu/drm/i915/gt/gen6_ppgtt.c new file +482 -0
482 lines not on this page · raw message
drivers/gpu/drm/i915/gt/gen6_ppgtt.h new file +76 -0
76 lines not on this page · raw message
drivers/gpu/drm/i915/gt/gen8_ppgtt.c new file +722 -0
722 lines not on this page · raw message
drivers/gpu/drm/i915/gt/gen8_ppgtt.h new file +13 -0
@@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2020 Intel Corporation +*/ + +#ifndef __GEN8_PPGTT_H__ +#define __GEN8_PPGTT_H__ + +struct intel_gt ; + +struct i915_ppgtt *gen8_ppgtt_create (struct intel_gt *gt); + +#endif
drivers/gpu/drm/i915/gt/intel_ggtt.c new file +1495 -0
1,495 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_gt.c +1 -1
@@ -366,7 +366,7 @@ static void intel_gt_fini_scratch(struct intel_gt *gt)static struct i915_address_space *kernel_vm (struct intel_gt *gt) {if (INTEL_PPGTT (gt->i915) >INTEL_PPGTT_ALIASING ) -return &i915_ppgtt_create (gt->i915)->vm; +return &i915_ppgtt_create (gt)->vm;else return i915_vm_get (>->ggtt->vm); }
drivers/gpu/drm/i915/gt/intel_gtt.c new file +595 -0
134 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_gtt.h new file +581 -0
581 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_ppgtt.c new file +218 -0
218 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_ring_submission.c +1 -0
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/i915/gt/selftest_hangcheck.c +1 -1
Lines of this file are not shown. View the raw message.
drivers/gpu/drm/i915/i915_gem_gtt.c +34 -3590
3,624 lines not on this page · raw message
drivers/gpu/drm/i915/i915_gem_gtt.h +6 -624
630 lines not on this page · raw message
drivers/gpu/drm/i915/i915_vma.h +3 -137
140 lines not on this page · raw message
drivers/gpu/drm/i915/i915_vma_types.h new file +294 -0
294 lines not on this page · raw message
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +34 -44
78 lines not on this page · raw message
drivers/gpu/drm/i915/selftests/mock_gtt.c +7 -2
Lines of this file are not shown. View the raw message.
The rest of this diff is not shown. View the raw message.
Signature · 6 lines
2.25.0.rc1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Part of the diff is not shown here. View the raw message.
Quoting Chris Wilson (2020-01-07 13:40:09)
Quoted 8 lines
From: Matthew Auld <[email protected]>
Attempt to split i915_gem_gtt.[ch] into more manageable chunks.
Suggested-by Chris Wilson <[email protected]>Signed-off-by Matthew Auld <[email protected]>Cc Chris Wilson <[email protected]>Reviewed-by Chris Wilson <[email protected]>
Had one ack from Mika, the pain should be worth it in the end... -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botThank you for the patch! Perhaps something to improve:
Hi Matthew,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip]
[cannot apply to v5.5-rc5 next-20200106]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Matthew-Auld/drm-i915-gtt-split-up-i915_gem_gtt/20200107-074805 base: git://anongit.freedesktop.org/drm-intel for-linux-next reproduce: make htmldocs
If you fix the issue, kindly add following tag
All warnings (new ones prefixed by >>):
include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_free' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_read' not described in 'security_list_options' include/linux/lsm_hooks.h:1830: warning: Function parameter or member 'perf_event_write' not described in 'security_list_options' fs/posix_acl.c:647: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode'
fs/posix_acl.c:647: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode'
fs/posix_acl.c:647: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' include/linux/regulator/machine.h:196: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:223: warning: Function parameter or member 'resume' not described in 'regulator_ops' sound/soc/soc-core.c:2509: warning: Function parameter or member 'legacy_dai_naming' not described in 'snd_soc_register_dai' include/linux/skbuff.h:888: warning: Function parameter or member 'dev_scratch' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'list' not described in 'sk_buff'
include/linux/skbuff.h:888: warning: Function parameter or member 'ip_defrag_offset' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'skb_mstamp_ns' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member '__cloned_offset' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'head_frag' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member '__pkt_type_offset' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'encapsulation' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'encap_hdr_csum' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'csum_valid' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member '__pkt_vlan_present_offset' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'vlan_present' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'csum_complete_sw' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'csum_level' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'inner_protocol_type' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'remcsum_offload' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'sender_cpu' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'reserved_tailroom' not described in 'sk_buff' include/linux/skbuff.h:888: warning: Function parameter or member 'inner_ipproto' not described in 'sk_buff' include/net/sock.h:232: warning: Function parameter or member 'skc_addrpair' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_portpair' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_ipv6only' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_net_refcnt' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_v6_daddr' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_v6_rcv_saddr' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_cookie' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_listener' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_tw_dr' not described in 'sock_common'
include/net/sock.h:232: warning: Function parameter or member 'skc_rcv_wnd' not described in 'sock_common' include/net/sock.h:232: warning: Function parameter or member 'skc_tw_rcv_nxt' not described in 'sock_common' include/net/sock.h:514: warning: Function parameter or member 'sk_rx_skb_cache' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_wq_raw' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'tcp_rtx_queue' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_tx_skb_cache' not described in 'sock'
include/net/sock.h:514: warning: Function parameter or member 'sk_route_forced_caps' not described in 'sock' include/net/sock.h:514: warning: Function parameter or member 'sk_txtime_report_errors' not described in 'sock' include/net/sock.h:514: warning: Function parameter or member 'sk_validate_xmit_skb' not described in 'sock' include/net/sock.h:514: warning: Function parameter or member 'sk_bpf_storage' not described in 'sock'
include/net/sock.h:2454: warning: Function parameter or member 'tcp_rx_skb_cache_key' not described in 'DECLARE_STATIC_KEY_FALSE' include/net/sock.h:2454: warning: Excess function parameter 'sk' description in 'DECLARE_STATIC_KEY_FALSE' include/net/sock.h:2454: warning: Excess function parameter 'skb' description in 'DECLARE_STATIC_KEY_FALSE' net/core/skbuff.c:5489: warning: Function parameter or member 'ethernet' not described in 'skb_mpls_push' include/linux/netdevice.h:1779: warning: bad line: spinlock
include/linux/netdevice.h:2082: warning: Function parameter or member 'gso_partial_features' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'l3mdev_ops' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'xfrmdev_ops' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'tlsdev_ops' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'name_assign_type' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'ieee802154_ptr' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'mpls_ptr' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'xdp_prog' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'gro_flush_timeout' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'nf_hooks_ingress' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'qdisc_hash' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'xps_cpus_map' not described in 'net_device' include/linux/netdevice.h:2082: warning: Function parameter or member 'xps_rxqs_map' not described in 'net_device' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(advertising' not described in 'phylink_link_state' include/linux/phylink.h:56: warning: Function parameter or member '__ETHTOOL_DECLARE_LINK_MODE_MASK(lp_advertising' not described in 'phylink_link_state' include/linux/i2c.h:337: warning: Function parameter or member 'init_irq' not described in 'i2c_client' drivers/infiniband/core/umem_odp.c:167: warning: Function parameter or member 'ops' not described in 'ib_umem_odp_alloc_child' drivers/infiniband/core/umem_odp.c:217: warning: Function parameter or member 'ops' not described in 'ib_umem_odp_get' drivers/infiniband/ulp/iser/iscsi_iser.h:401: warning: Function parameter or member 'all_list' not described in 'iser_fr_desc' drivers/infiniband/ulp/iser/iscsi_iser.h:415: warning: Function parameter or member 'all_list' not described in 'iser_fr_pool' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd0' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd1' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd2' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd3' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:148: warning: Function parameter or member 'rsvd4' not described in 'opa_vesw_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd0' not described in 'opa_per_veswport_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd1' not described in 'opa_per_veswport_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd2' not described in 'opa_per_veswport_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:205: warning: Function parameter or member 'rsvd3' not described in 'opa_per_veswport_info' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:263: warning: Function parameter or member 'tbl_entries' not described in 'opa_veswport_mactable' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:342: warning: Function parameter or member 'reserved' not described in 'opa_veswport_summary_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd0' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd1' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd2' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd3' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd4' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd5' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd6' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd7' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd8' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:394: warning: Function parameter or member 'rsvd9' not described in 'opa_veswport_error_counters' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:460: warning: Function parameter or member 'reserved' not described in 'opa_vnic_vema_mad' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:485: warning: Function parameter or member 'reserved' not described in 'opa_vnic_notice_attr' drivers/infiniband/ulp/opa_vnic/opa_vnic_encap.h:500: warning: Function parameter or member 'reserved' not described in 'opa_vnic_vema_mad_trap' include/linux/input/sparse-keymap.h:43: warning: Function parameter or member 'sw' not described in 'key_entry' kernel/futex.c:1187: warning: Function parameter or member 'ret' not described in 'wait_for_owner_exiting' include/drm/drm_modeset_helper_vtables.h:1052: warning: Function parameter or member 'prepare_writeback_job' not described in 'drm_connector_helper_funcs' include/drm/drm_modeset_helper_vtables.h:1052: warning: Function parameter or member 'cleanup_writeback_job' not described in 'drm_connector_helper_funcs'
>> drivers/gpu/drm/i915/i915_gem_gtt.c:1: warning: 'Global GTT views' not found
include/net/cfg80211.h:1189: warning: Function parameter or member 'txpwr' not described in 'station_parameters' include/net/mac80211.h:4081: warning: Function parameter or member 'sta_set_txpwr' not described in 'ieee80211_ops' include/net/mac80211.h:2036: warning: Function parameter or member 'txpwr' not described in 'ieee80211_sta' include/linux/devfreq.h:181: warning: Function parameter or member 'last_status' not described in 'devfreq' drivers/devfreq/devfreq.c:1687: warning: bad line: - Resource-managed devfreq_register_notifier()
drivers/devfreq/devfreq.c:1723: warning: bad line: - Resource-managed devfreq_unregister_notifier() drivers/devfreq/devfreq-event.c:355: warning: Function parameter or member 'edev' not described in 'devfreq_event_remove_edev' drivers/devfreq/devfreq-event.c:355: warning: Excess function parameter 'dev' description in 'devfreq_event_remove_edev' Documentation/admin-guide/xfs.rst:257: WARNING: Block quote ends without a blank line; unexpected unindent. Documentation/admin-guide/hw-vuln/tsx_async_abort.rst:142: WARNING: duplicate label virt_mechanism, other instance in Documentation/admin-guide/hw-vuln/mds.rst Documentation/admin-guide/ras.rst:358: WARNING: Definition list ends without a blank line; unexpected unindent. Documentation/admin-guide/ras.rst:358: WARNING: Definition list ends without a blank line; unexpected unindent. Documentation/admin-guide/ras.rst:363: WARNING: Definition list ends without a blank line; unexpected unindent. Documentation/admin-guide/ras.rst:363: WARNING: Definition list ends without a blank line; unexpected unindent. Documentation/driver-api/driver-model/driver.rst:215: WARNING: Inline emphasis start-string without end-string. Documentation/driver-api/driver-model/driver.rst:215: WARNING: Inline emphasis start-string without end-string. include/uapi/linux/firewire-cdev.h:312: WARNING: Inline literal start-string without end-string. drivers/firewire/core-transaction.c:606: WARNING: Inline strong start-string without end-string.
Documentation/usb/index.rst:5: WARNING: toctree contains reference to nonexisting document 'usb/rio'
Documentation/usb/index.rst:5: WARNING: toctree contains reference to nonexisting document 'usb/wusb-design-overview' Documentation/x86/boot.rst:72: WARNING: Malformed table.
Text in column margin in table line 57.
vim +1 drivers/gpu/drm/i915/i915_gem_gtt.c
> 1 // SPDX-License-Identifier: MIT
2 /*
3 * Copyright © 2010 Daniel Vetter
4 * Copyright © 2020 Intel Corporation
5 */
6 ---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gtt: split up i915_gem_gtt
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915/gtt: split up i915_gem_gtt
URL : https://patchwork.freedesktop.org/series/71678/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7690_full -> Patchwork_16010_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16010_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_16010_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16010_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_busy@close-race:
- shard-hsw: NOTRUN -> [TIMEOUT][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-hsw7/igt@[email protected]
* igt@i915_hangman@error-state-capture-vcs1:
- shard-tglb: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb3/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb4/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_16010_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-iclb: [PASS][4] -> [DMESG-WARN][5] ([fdo#111764])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb5/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb4/igt@[email protected]
* igt@gem_ctx_isolation@vecs0-s3:
- shard-skl: [PASS][6] -> [INCOMPLETE][7] ([i915#69])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl6/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl6/igt@[email protected]
* igt@gem_ctx_persistence@vcs1-queued:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#109276] / [fdo#112080]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb4/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb5/igt@[email protected]
* igt@gem_ctx_shared@q-smoketest-bsd1:
- shard-tglb: [PASS][10] -> [INCOMPLETE][11] ([fdo#111735])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb8/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb6/igt@[email protected]
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#112146]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb6/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb1/igt@[email protected]
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [PASS][14] -> [SKIP][15] ([fdo#112080]) +13 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb2/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb8/igt@[email protected]
* igt@gem_exec_schedule@pi-userfault-bsd:
- shard-iclb: [PASS][16] -> [SKIP][17] ([i915#677])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb5/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb4/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-chain-render:
- shard-tglb: [PASS][18] -> [INCOMPLETE][19] ([fdo#111606] / [fdo#111677] / [i915#472])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb7/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb6/igt@[email protected]
* igt@gem_sync@basic-store-each:
- shard-tglb: [PASS][20] -> [INCOMPLETE][21] ([i915#435] / [i915#472]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb2/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb7/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [PASS][22] -> [DMESG-WARN][23] ([i915#180]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-apl1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-apl1/igt@[email protected]
* igt@i915_selftest@live_execlists:
- shard-tglb: [PASS][24] -> [INCOMPLETE][25] ([i915#647])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb2/igt@i915_selftest@live_execlists.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb3/igt@i915_selftest@live_execlists.html
- shard-skl: [PASS][26] -> [DMESG-FAIL][27] ([i915#656])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl10/igt@i915_selftest@live_execlists.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl3/igt@i915_selftest@live_execlists.html
* igt@kms_color@pipe-b-ctm-negative:
- shard-skl: [PASS][28] -> [DMESG-WARN][29] ([i915#109]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl8/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl9/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][30] -> [DMESG-WARN][31] ([i915#180]) +5 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-kbl6/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-kbl2/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][32] -> [INCOMPLETE][33] ([i915#221])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl7/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-snb: [PASS][34] -> [DMESG-WARN][35] ([i915#42])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-snb2/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-snb5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [PASS][36] -> [FAIL][37] ([i915#49]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb3/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][38] -> [INCOMPLETE][39] ([i915#123] / [i915#69])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl2/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl10/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#109441]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@perf_pmu@enable-race-vecs0:
- shard-tglb: [PASS][42] -> [INCOMPLETE][43] ([i915#470] / [i915#472])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb3/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb3/igt@[email protected]
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][44] -> [SKIP][45] ([fdo#109276]) +26 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb1/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb5/igt@[email protected]
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][46] ([fdo#112080]) -> [PASS][47] +11 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb5/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb4/igt@[email protected]
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][48] ([fdo#109276] / [fdo#112080]) -> [PASS][49] +4 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb7/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb1/igt@[email protected]
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][50] ([fdo#110841]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb1/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb6/igt@[email protected]
* igt@gem_ctx_shared@q-smoketest-bsd:
- shard-tglb: [INCOMPLETE][52] ([i915#461]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb4/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb5/igt@[email protected]
* igt@gem_eio@in-flight-10ms:
- shard-tglb: [INCOMPLETE][54] ([i915#435] / [i915#534]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb1/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb5/igt@[email protected]
* igt@gem_exec_parallel@fds:
- shard-tglb: [INCOMPLETE][56] ([i915#470]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb6/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb7/igt@[email protected]
* igt@gem_exec_schedule@pi-distinct-iova-bsd:
- shard-iclb: [SKIP][58] ([i915#677]) -> [PASS][59] +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb6/igt@[email protected]
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][60] ([fdo#112146]) -> [PASS][61] +8 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb4/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb5/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-chain-blt:
- shard-tglb: [INCOMPLETE][62] ([fdo#111606] / [fdo#111677]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb9/igt@[email protected]
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-tglb: [TIMEOUT][64] ([fdo#112126] / [i915#530]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb8/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb8/igt@[email protected]
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [FAIL][66] ([i915#644]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-apl8/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-apl4/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][68] ([i915#69]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl10/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl2/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][70] ([i915#716]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-glk4/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-glk6/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [FAIL][72] ([IGT#5]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl4/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl4/igt@[email protected]
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [DMESG-WARN][74] ([i915#109]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl7/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-tglb: [FAIL][76] ([i915#49]) -> [PASS][77] +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb3/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb3/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][78] ([fdo#108145] / [i915#265]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-skl3/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-skl7/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][80] ([fdo#109441]) -> [PASS][81] +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb6/igt@kms_psr@psr2_primary_mmap_cpu.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][82] ([i915#31]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-apl2/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-apl8/igt@[email protected]
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][84] ([i915#180]) -> [PASS][85] +5 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-kbl1/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-kbl1/igt@[email protected]
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][86] ([fdo#109276]) -> [PASS][87] +27 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb5/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb4/igt@[email protected]
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [FAIL][88] ([IGT#28]) -> [SKIP][89] ([fdo#109276] / [fdo#112080])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb1/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb3/igt@[email protected]
* igt@gem_ctx_isolation@vcs1-nonpriv-switch:
- shard-iclb: [SKIP][90] ([fdo#109276] / [fdo#112080]) -> [FAIL][91] ([IGT#28])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-iclb6/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-iclb1/igt@[email protected]
* igt@gem_exec_create@forked:
- shard-tglb: [INCOMPLETE][92] ([fdo#108838] / [i915#435]) -> [INCOMPLETE][93] ([fdo#108838] / [i915#435] / [i915#472])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb6/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb7/igt@[email protected]
* igt@gem_exec_whisper@normal:
- shard-tglb: [INCOMPLETE][94] ([i915#435]) -> [INCOMPLETE][95] ([i915#435] / [i915#472]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb2/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb8/igt@[email protected]
* igt@gem_tiled_blits@normal:
- shard-hsw: [FAIL][96] ([i915#832]) -> [FAIL][97] ([i915#694])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-hsw7/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-hsw2/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][98] ([i915#468]) -> [FAIL][99] ([i915#454])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb6/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb5/igt@[email protected]
* igt@kms_atomic_transition@6x-modeset-transitions:
- shard-tglb: [SKIP][100] ([fdo#112021]) -> [SKIP][101] ([fdo#112016] / [fdo#112021])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb9/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb1/igt@[email protected]
* igt@perf@gen12-unprivileged-single-ctx-counters:
- shard-tglb: [INCOMPLETE][102] ([i915#756] / [i915#923]) -> [INCOMPLETE][103] ([i915#472] / [i915#756]) +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7690/shard-tglb3/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/shard-tglb7/igt@[email protected]
[IGT#28]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/28
[IGT#5]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/5
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108838]: https://bugs.freedesktop.org/show_bug.cgi?id=108838
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
[fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111764]: https://bugs.freedesktop.org/show_bug.cgi?id=111764
[fdo#112016]: https://bugs.freedesktop.org/show_bug.cgi?id=112016
[fdo#112021]: https://bugs.freedesktop.org/show_bug.cgi?id=112021
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#123]: https://gitlab.freedesktop.org/drm/intel/issues/123
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#221]: https://gitlab.freedesktop.org/drm/intel/issues/221
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#42]: https://gitlab.freedesktop.org/drm/intel/issues/42
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#461]: https://gitlab.freedesktop.org/drm/intel/issues/461
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#534]: https://gitlab.freedesktop.org/drm/intel/issues/534
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#647]: https://gitlab.freedesktop.org/drm/intel/issues/647
[i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656
[i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#756]: https://gitlab.freedesktop.org/drm/intel/issues/756
[i915#832]: https://gitlab.freedesktop.org/drm/intel/issues/832
[i915#923]: https://gitlab.freedesktop.org/drm/intel/issues/923
Participating hosts (11 -> 10)
------------------------------
Missing (1): pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7690 -> Patchwork_16010
CI-20190529: 20190529
CI_DRM_7690: fc0ff49196d0144e8b72406a8ca71a395dbd7040 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5357: a555a4b98f90dab655d24bb3d07e9291a8b8dac8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16010: f96decd69a0ee1bf6a884ff946ff1dbcf0df44f0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16010/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: split up i915_gem_gtt (rev2)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915/gtt: split up i915_gem_gtt (rev2)
URL : https://patchwork.freedesktop.org/series/71678/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip b50ab2add6b6 drm/i915/gtt: split up i915_gem_gtt -:112: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #112: new file mode 100644
-:287: WARNING:MEMORY_BARRIER: memory barrier without comment #287: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:171:
+ mb();
-:290: WARNING:MEMORY_BARRIER: memory barrier without comment #290: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.c:174:
+ mb();
-:618: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #618: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:14:
+ struct mutex flush;
-:623: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #623: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:19:
+ struct mutex pin_mutex;
-:643: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'base' - possible side-effects? #643: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:39:
+#define __to_gen6_ppgtt(base) container_of(base, struct gen6_ppgtt, base)
-:659: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'start' - possible side-effects? #659: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:55:
+#define gen6_for_each_pde(pt, pd, start, length, iter) \
+ for (iter = gen6_pde_index(start); \
+ length > 0 && iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
+ temp = min(temp - start, length); \
+ start += temp, length -= temp; }), ++iter)-:659: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'length' - possible side-effects? #659: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:55:
+#define gen6_for_each_pde(pt, pd, start, length, iter) \
+ for (iter = gen6_pde_index(start); \
+ length > 0 && iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
+ temp = min(temp - start, length); \
+ start += temp, length -= temp; }), ++iter)-:659: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'length' may be better as '(length)' to avoid precedence issues #659: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:55:
+#define gen6_for_each_pde(pt, pd, start, length, iter) \
+ for (iter = gen6_pde_index(start); \
+ length > 0 && iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
+ temp = min(temp - start, length); \
+ start += temp, length -= temp; }), ++iter)-:659: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #659: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:55:
+#define gen6_for_each_pde(pt, pd, start, length, iter) \
+ for (iter = gen6_pde_index(start); \
+ length > 0 && iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
+ temp = min(temp - start, length); \
+ start += temp, length -= temp; }), ++iter)-:663: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #663: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:59:
+ ({ u32 temp = ALIGN(start+1, 1 << GEN6_PDE_SHIFT); \
^
-:667: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'iter' - possible side-effects? #667: FILE: drivers/gpu/drm/i915/gt/gen6_ppgtt.h:63:
+#define gen6_for_all_pdes(pt, pd, iter) \
+ for (iter = 0; \
+ iter < I915_PDES && \
+ (pt = i915_pt_entry(pd, iter), true); \
+ ++iter)
-:810: WARNING:LINE_SPACING: Missing a blank line after declarations #810: FILE: drivers/gpu/drm/i915/gt/gen8_ppgtt.c:124:
+ unsigned int shift = __gen8_pte_shift(vm->top);
+ return (vm->total + (1ull << shift) - 1) >> shift;
-:1310: WARNING:MEMORY_BARRIER: memory barrier without comment #1310: FILE: drivers/gpu/drm/i915/gt/gen8_ppgtt.c:624:
+ wmb();
-:1676: WARNING:LINE_SPACING: Missing a blank line after declarations #1676: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:243:
+ dma_addr_t addr;
+ for_each_sgt_daddr(addr, iter, vma->pages)
-:1695: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1695: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:262:
+ unsigned first_entry = start / I915_GTT_PAGE_SIZE;
-:1696: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1696: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:263:
+ unsigned num_entries = length / I915_GTT_PAGE_SIZE;
-:1808: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1808: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:375:
+ unsigned first_entry = start / I915_GTT_PAGE_SIZE;
-:1809: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1809: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:376:
+ unsigned num_entries = length / I915_GTT_PAGE_SIZE;
-:2343: WARNING:LINE_SPACING: Missing a blank line after declarations #2343: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:910:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= GEN6_PTE_ADDR_ENCODE(addr);
-:2365: WARNING:LINE_SPACING: Missing a blank line after declarations #2365: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:932:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= GEN6_PTE_ADDR_ENCODE(addr);
-:2389: WARNING:LINE_SPACING: Missing a blank line after declarations #2389: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:956:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= GEN6_PTE_ADDR_ENCODE(addr);
-:2405: WARNING:LINE_SPACING: Missing a blank line after declarations #2405: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:972:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= HSW_PTE_ADDR_ENCODE(addr);
-:2418: WARNING:LINE_SPACING: Missing a blank line after declarations #2418: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:985:
+ gen6_pte_t pte = GEN6_PTE_VALID;
+ pte |= HSW_PTE_ADDR_ENCODE(addr);
-:2448: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #2448: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:1015:
+ if (ggtt->mappable_end < (64<<20) || ggtt->mappable_end > (512<<20)) {
^
-:2448: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #2448: FILE: drivers/gpu/drm/i915/gt/intel_ggtt.c:1015:
+ if (ggtt->mappable_end < (64<<20) || ggtt->mappable_end > (512<<20)) {
^
-:3470: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #3470: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:523:
+ * writing this data shouldn't be harmful even in those cases. */
-:3476: WARNING:LONG_LINE_COMMENT: line over 100 characters #3476: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:529:
+ GEN8_PPAT(1, GEN8_PPAT_WC | GEN8_PPAT_LLCELLC) | /* for something pointing to ptes? */
-:3478: WARNING:LONG_LINE_COMMENT: line over 100 characters #3478: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:531:
+ GEN8_PPAT(3, GEN8_PPAT_UC) | /* Uncached objects, mostly for scanout */
-:3618: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #3618: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:70:
+#define GEN6_GTT_ADDR_ENCODE(addr) ((addr) | (((addr) >> 28) & 0xff0))
-:3630: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'pde_shift' may be better as '(pde_shift)' to avoid precedence issues #3630: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:82:
+#define NUM_PTE(pde_shift) (1 << (pde_shift - PAGE_SHIFT))
-:3640: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bits' - possible side-effects? #3640: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:92:
+#define HSW_CACHEABILITY_CONTROL(bits) ((((bits) & 0x7) << 1) | \
+ (((bits) & 0x8) << (11 - 3)))
-:3649: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #3649: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:101:
+#define HSW_GTT_ADDR_ENCODE(addr) ((addr) | (((addr) >> 28) & 0x7f0))
-:3671: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3671: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:123:
+#define GEN8_PPAT_AGE(x) ((x)<<4)
^
-:3672: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3672: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:124:
+#define GEN8_PPAT_LLCeLLC (3<<2)
^
-:3673: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3673: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:125:
+#define GEN8_PPAT_LLCELLC (2<<2)
^
-:3674: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3674: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:126:
+#define GEN8_PPAT_LLC (1<<2)
^
-:3675: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3675: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:127:
+#define GEN8_PPAT_WB (3<<0)
^
-:3676: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3676: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:128:
+#define GEN8_PPAT_WT (2<<0)
^
-:3677: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3677: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:129:
+#define GEN8_PPAT_WC (1<<0)
^
-:3678: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3678: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:130:
+#define GEN8_PPAT_UC (0<<0)
^
-:3679: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #3679: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:131:
+#define GEN8_PPAT_ELLC_OVERRIDE (0<<2)
^
-:3712: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #3712: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:164:
+ spinlock_t lock;
-:3723: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'px' - possible side-effects? #3723: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:175:
+#define px_base(px) \
+ __px_choose_expr(px, struct i915_page_dma *, __x, \
+ __px_choose_expr(px, struct i915_page_scratch *, &__x->base, \
+ __px_choose_expr(px, struct i915_page_table *, &__x->base, \
+ __px_choose_expr(px, struct i915_page_directory *, &__x->pt.base, \
+ (void)0))))
-:3731: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'px' - possible side-effects? #3731: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:183:
+#define px_pt(px) \
+ __px_choose_expr(px, struct i915_page_table *, __x, \
+ __px_choose_expr(px, struct i915_page_directory *, &__x->pt, \
+ (void)0))
-:3760: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #3760: FILE: drivers/gpu/drm/i915/gt/intel_gtt.h:212:
+ spinlock_t lock;
-:4316: WARNING:MEMORY_BARRIER: memory barrier without comment #4316: FILE: drivers/gpu/drm/i915/gt/intel_ppgtt.c:181:
+ wmb();
-:5070: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst #5070: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:68:
+ udelay(10);
-:8995: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #8995: FILE: drivers/gpu/drm/i915/i915_vma_types.h:126:
+ BUILD_BUG_ON(sizeof(struct intel_rotation_info) != 8*sizeof(unsigned int));
^
-:8997: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #8997: FILE: drivers/gpu/drm/i915/i915_vma_types.h:128:
+ BUILD_BUG_ON(sizeof(struct intel_remapped_info) != 9*sizeof(unsigned int));
^
total: 0 errors, 19 warnings, 31 checks, 9335 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: split up i915_gem_gtt (rev2)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915/gtt: split up i915_gem_gtt (rev2)
URL : https://patchwork.freedesktop.org/series/71678/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7695 -> Patchwork_16012
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/index.html
Known issues
------------
Here are the changes found in Patchwork_16012 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-lmem: [PASS][1] -> [DMESG-WARN][2] ([i915#889]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-skl-lmem/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-skl-lmem/igt@[email protected]
* igt@i915_selftest@live_active:
- fi-icl-y: [PASS][3] -> [DMESG-FAIL][4] ([i915#765])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-icl-y/igt@i915_selftest@live_active.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-icl-y/igt@i915_selftest@live_active.html
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [PASS][5] -> [DMESG-FAIL][6] ([i915#725])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-ivb-3770/igt@i915_selftest@live_blt.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-ivb-3770/igt@i915_selftest@live_blt.html
- fi-hsw-4770: [PASS][7] -> [DMESG-FAIL][8] ([i915#770])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-hsw-4770/igt@i915_selftest@live_blt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-hsw-4770/igt@i915_selftest@live_blt.html
* igt@i915_selftest@live_gt_lrc:
- fi-skl-6600u: [PASS][9] -> [DMESG-FAIL][10] ([i915#889]) +7 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-skl-6600u/igt@i915_selftest@live_gt_lrc.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-skl-6600u/igt@i915_selftest@live_gt_lrc.html
* igt@i915_selftest@live_late_gt_pm:
- fi-skl-6600u: [PASS][11] -> [DMESG-WARN][12] ([i915#889]) +23 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-skl-6600u/igt@i915_selftest@live_late_gt_pm.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-skl-6600u/igt@i915_selftest@live_late_gt_pm.html
* igt@i915_selftest@live_sanitycheck:
- fi-skl-lmem: [PASS][13] -> [INCOMPLETE][14] ([i915#198])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-skl-lmem/igt@i915_selftest@live_sanitycheck.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-skl-lmem/igt@i915_selftest@live_sanitycheck.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [PASS][15] -> [FAIL][16] ([fdo#111407])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-kbl-7500u/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-kbl-7500u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- fi-byt-n2820: [FAIL][17] ([i915#694]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-byt-n2820/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-byt-n2820/igt@[email protected]
* igt@i915_selftest@live_blt:
- fi-bsw-nick: [DMESG-FAIL][19] ([i915#723]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-bsw-nick/igt@i915_selftest@live_blt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-bsw-nick/igt@i915_selftest@live_blt.html
#### Warnings ####
* igt@runner@aborted:
- fi-kbl-8809g: [FAIL][21] ([i915#192] / [i915#193] / [i915#194]) -> [FAIL][22] ([i915#858])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/fi-kbl-8809g/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/fi-kbl-8809g/igt@[email protected]
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[i915#192]: https://gitlab.freedesktop.org/drm/intel/issues/192
[i915#193]: https://gitlab.freedesktop.org/drm/intel/issues/193
[i915#194]: https://gitlab.freedesktop.org/drm/intel/issues/194
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#723]: https://gitlab.freedesktop.org/drm/intel/issues/723
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#765]: https://gitlab.freedesktop.org/drm/intel/issues/765
[i915#770]: https://gitlab.freedesktop.org/drm/intel/issues/770
[i915#858]: https://gitlab.freedesktop.org/drm/intel/issues/858
[i915#889]: https://gitlab.freedesktop.org/drm/intel/issues/889
Participating hosts (53 -> 44)
------------------------------
Missing (9): fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-skl-6770hq fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7695 -> Patchwork_16012
CI-20190529: 20190529
CI_DRM_7695: 8df346a062d56d97ab53555d3f5829c26f950233 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5358: c6fc013f414b806175dc4143c58ab445e5235ea5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16012: b50ab2add6b64821d1126db93f7565398bc228e1 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b50ab2add6b6 drm/i915/gtt: split up i915_gem_gtt
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gtt: split up i915_gem_gtt (rev2)
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: drm/i915/gtt: split up i915_gem_gtt (rev2)
URL : https://patchwork.freedesktop.org/series/71678/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7695_full -> Patchwork_16012_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_16012_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_16012_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_16012_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@smoketest:
- shard-tglb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb4/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_16012_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb5/igt@[email protected]
* igt@gem_ctx_persistence@rcs0-mixed-process:
- shard-tglb: [PASS][5] -> [FAIL][6] ([i915#679])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb5/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb5/igt@[email protected]
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#110841])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb2/igt@[email protected]
* igt@gem_ctx_shared@q-smoketest-bsd:
- shard-tglb: [PASS][9] -> [INCOMPLETE][10] ([i915#461])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb5/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb3/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][11] -> [INCOMPLETE][12] ([i915#469])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb9/igt@[email protected]
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#112146]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb5/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb2/igt@[email protected]
* igt@gem_exec_nop@basic-series:
- shard-tglb: [PASS][15] -> [INCOMPLETE][16] ([i915#435] / [i915#472])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb4/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109276]) +11 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb6/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-chain-blt:
- shard-tglb: [PASS][19] -> [INCOMPLETE][20] ([fdo#111606] / [fdo#111677] / [i915#472])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb1/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb8/igt@[email protected]
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-glk: [PASS][21] -> [TIMEOUT][22] ([i915#530])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-glk8/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-glk3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
- shard-hsw: [PASS][23] -> [TIMEOUT][24] ([i915#530])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-hsw7/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-hsw2/igt@[email protected]
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-hsw: [PASS][25] -> [INCOMPLETE][26] ([i915#530] / [i915#61])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-hsw1/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-hsw8/igt@[email protected]
* igt@gem_sync@basic-all:
- shard-tglb: [PASS][27] -> [INCOMPLETE][28] ([i915#470] / [i915#472])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb7/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb7/igt@[email protected]
* igt@gem_sync@basic-store-all:
- shard-tglb: [PASS][29] -> [INCOMPLETE][30] ([i915#472])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb7/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb3/igt@[email protected]
* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [PASS][31] -> [DMESG-WARN][32] ([i915#180]) +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-kbl4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-kbl1/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][33] -> [FAIL][34] ([i915#454])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb8/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb3/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: [PASS][35] -> [INCOMPLETE][36] ([fdo#103665])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-kbl3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-kbl4/igt@[email protected]
* igt@kms_color@pipe-b-ctm-0-25:
- shard-skl: [PASS][37] -> [DMESG-WARN][38] ([i915#109])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-skl10/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-skl4/igt@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +2 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-apl7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-apl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-pri-indfb-multidraw:
- shard-tglb: [PASS][41] -> [FAIL][42] ([i915#49]) +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb3/igt@[email protected]
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][43] -> [SKIP][44] ([fdo#109441]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb2/igt@kms_psr@psr2_basic.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb1/igt@kms_psr@psr2_basic.html
* igt@perf_pmu@init-busy-vcs1:
- shard-iclb: [PASS][45] -> [SKIP][46] ([fdo#112080]) +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb4/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb6/igt@[email protected]
#### Possible fixes ####
* igt@gem_blits@basic:
- shard-kbl: [DMESG-WARN][47] ([i915#836]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-kbl2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-kbl2/igt@[email protected]
* igt@gem_busy@extended-parallel-vcs1:
- shard-iclb: [SKIP][49] ([fdo#112080]) -> [PASS][50] +8 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb5/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb2/igt@[email protected]
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][51] ([i915#180]) -> [PASS][52] +9 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-kbl1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-kbl4/igt@[email protected]
* igt@gem_ctx_isolation@vcs1-clean:
- shard-iclb: [SKIP][53] ([fdo#109276] / [fdo#112080]) -> [PASS][54] +5 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb2/igt@[email protected]
* igt@gem_exec_balancer@nop:
- shard-tglb: [INCOMPLETE][55] ([fdo#111736] / [i915#472]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb2/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb9/igt@[email protected]
* igt@gem_exec_balancer@smoke:
- shard-tglb: [INCOMPLETE][57] ([fdo#111593] / [i915#472]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb4/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb5/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-contexts-chain-render:
- shard-tglb: [INCOMPLETE][59] ([fdo#111677] / [i915#472]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb1/igt@[email protected]
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][61] ([fdo#112146]) -> [PASS][62] +5 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb4/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb5/igt@[email protected]
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][63] ([i915#530]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb6/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb8/igt@[email protected]
* igt@gem_ppgtt@blt-vs-render-ctxn:
- shard-tglb: [INCOMPLETE][65] ([i915#470]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb9/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb9/igt@[email protected]
* igt@gem_ppgtt@flink-and-close-vma-leak:
- shard-apl: [FAIL][67] ([i915#644]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-apl4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-apl1/igt@[email protected]
* igt@i915_selftest@live_hangcheck:
- shard-tglb: [INCOMPLETE][69] ([i915#435]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb3/igt@i915_selftest@live_hangcheck.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb9/igt@i915_selftest@live_hangcheck.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][71] ([i915#180]) -> [PASS][72] +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-apl6/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-apl8/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-256x85-random:
- shard-skl: [FAIL][73] ([i915#54]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-skl10/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-skl5/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][75] ([i915#72]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-glk5/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-glk3/igt@[email protected]
* igt@kms_flip@flip-vs-panning-interruptible:
- shard-skl: [DMESG-WARN][77] ([i915#109]) -> [PASS][78] +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-skl1/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-skl6/igt@[email protected]
* igt@kms_flip_tiling@flip-changes-tiling-yf:
- shard-skl: [FAIL][79] ([i915#699]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-skl4/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-skl2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
- shard-tglb: [FAIL][81] ([i915#49]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][83] ([fdo#108145] / [i915#265]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-skl10/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-skl5/igt@[email protected]
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][85] ([fdo#109441]) -> [PASS][86] +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb5/igt@kms_psr@psr2_suspend.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-skl: [INCOMPLETE][87] ([i915#69]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-skl9/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-skl7/igt@[email protected]
* igt@prime_busy@after-bsd2:
- shard-iclb: [SKIP][89] ([fdo#109276]) -> [PASS][90] +4 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-iclb8/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-iclb2/igt@[email protected]
#### Warnings ####
* igt@gem_ctx_isolation@vcs2-dirty-switch:
- shard-tglb: [SKIP][91] ([fdo#111912] / [fdo#112080]) -> [SKIP][92] ([fdo#112080])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb4/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb9/igt@[email protected]
* igt@i915_pm_dc@dc6-psr:
- shard-tglb: [SKIP][93] ([i915#468]) -> [FAIL][94] ([i915#454])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-tglb9/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-tglb7/igt@[email protected]
* igt@i915_selftest@live_blt:
- shard-hsw: [DMESG-FAIL][95] ([i915#725]) -> [DMESG-FAIL][96] ([i915#553] / [i915#725])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7695/shard-hsw8/igt@i915_selftest@live_blt.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/shard-hsw7/igt@i915_selftest@live_blt.html
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[fdo#111606]: https://bugs.freedesktop.org/show_bug.cgi?id=111606
[fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#111912]: https://bugs.freedesktop.org/show_bug.cgi?id=111912
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#435]: https://gitlab.freedesktop.org/drm/intel/issues/435
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#461]: https://gitlab.freedesktop.org/drm/intel/issues/461
[i915#468]: https://gitlab.freedesktop.org/drm/intel/issues/468
[i915#469]: https://gitlab.freedesktop.org/drm/intel/issues/469
[i915#470]: https://gitlab.freedesktop.org/drm/intel/issues/470
[i915#472]: https://gitlab.freedesktop.org/drm/intel/issues/472
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#644]: https://gitlab.freedesktop.org/drm/intel/issues/644
[i915#679]: https://gitlab.freedesktop.org/drm/intel/issues/679
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#699]: https://gitlab.freedesktop.org/drm/intel/issues/699
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#836]: https://gitlab.freedesktop.org/drm/intel/issues/836
Participating hosts (11 -> 10)
------------------------------
Missing (1): pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7695 -> Patchwork_16012
CI-20190529: 20190529
CI_DRM_7695: 8df346a062d56d97ab53555d3f5829c26f950233 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5358: c6fc013f414b806175dc4143c58ab445e5235ea5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_16012: b50ab2add6b64821d1126db93f7565398bc228e1 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16012/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · Matthew Auld
Attempt to split i915_gem_gtt.[ch] into more manageable chunks.
drivers/gpu/drm/i915/gt/intel_gtt.c new file +2
-0+void clear_pages (struct i915_vma *vma) +{
drivers/gpu/drm/i915/gt/intel_gtt.c line 272
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_gtt.c new file +10
-0+GEM_BUG_ON (!vma->pages); + +if (vma->pages != vma->obj->mm.pages) { +sg_free_table (vma->pages); +kfree (vma->pages); + } + vma->pages =NULL ; + +memset (&vma->page_sizes,0 ,sizeof (vma->page_sizes)); +}
We probably want to add a prefix now that the function is exported.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2021-01-26 17:13:24)
Quoted 19 lines · Matthew Auld
Quoted 4 lines
Attempt to split i915_gem_gtt.[ch] into more manageable chunks.
drivers/gpu/drm/i915/gt/intel_gtt.c new file +2
-0+void clear_pages (struct i915_vma *vma) +{drivers/gpu/drm/i915/gt/intel_gtt.c line 272
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_gtt.c new file +10
-0+GEM_BUG_ON (!vma->pages); + +if (vma->pages != vma->obj->mm.pages) { +sg_free_table (vma->pages); +kfree (vma->pages); + } + vma->pages =NULL ; + +memset (&vma->page_sizes,0 ,sizeof (vma->page_sizes)); +}We probably want to add a prefix now that the function is exported.
Or follow through on eliminating the callback.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx