Skip to contentSkip to conversation

ARM: dts: imx6ul-14x14-evk: Pass the "broken-cd" property

PATCH Applied Fabio Estevam 2 participants 2 messages Jan 7, 2020 – Jan 9, 2020

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx6ul-14x14-evk: Pass the "broken-cd" property

imx6ul-14x14-evk does not have a GPIO dedicated for reading the card detect pin on the eSDHC2 micro-SD port.

Pass the "broken-cd" property to describe the absence of the card detect GPIO so that polling must be used.

According to Documentation/devicetree/bindings/mmc/mmc-controller.yaml:

broken-cd:
$ref: /schemas/types.yaml#/definitions/flag description:
There is no card detection available; polling must be used.

Even though no error is oberved in the kernel, the lack of the 'broken-cd' property caused the micro-SD to not be detected in U-Boot, so let's improve the device tree description to make it more accurate.

---
 arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi +1 -0
index 212144511b66..265bf4108cb6 100644
@@ -327,6 +327,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usdhc2>;
 	no-1-8-v;
+	broken-cd;
 	keep-power-in-suspend;
 	wakeup-source;
 	status = "okay";
Signature · 7 lines
2.17.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Applied
#1 lore raw
Quoted 13 lines · Fabio Estevam

imx6ul-14x14-evk does not have a GPIO dedicated for reading the card detect pin on the eSDHC2 micro-SD port.

Pass the "broken-cd" property to describe the absence of the card detect GPIO so that polling must be used.

According to Documentation/devicetree/bindings/mmc/mmc-controller.yaml:

broken-cd:
$ref: /schemas/types.yaml#/definitions/flag description:
There is no card detection available; polling must be used.

Quoted 5 lines

Even though no error is oberved in the kernel, the lack of the 'broken-cd' property caused the micro-SD to not be detected in U-Boot, so let's improve the device tree description to make it more accurate.

Applied, thanks.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel