Skip to contentSkip to conversation

reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate

PATCH In review John Stultz 3 participants 4 messages Jan 7, 2020 Reset controller framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 reset: Kconfig: Set CONFIG_RESET_QCOM_AOSS as tristate

Allow CONFIG_RESET_QCOM_AOSS to be set as as =m to allow for the driver to be loaded from a modules.

Cc Todd Kjos <[email protected]>
Cc Alistair Delva <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Amit Pundir <[email protected]>
Cc Philipp Zabel <[email protected]>
---
 drivers/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/reset/Kconfig +1 -1
index 3ad7817ce1f0..45e70524af36 100644
@@ -99,7 +99,7 @@ config RESET_PISTACHIO
 	  This enables the reset driver for ImgTec Pistachio SoCs.
 
 config RESET_QCOM_AOSS
-	bool "Qcom AOSS Reset Driver"
+	tristate "Qcom AOSS Reset Driver"
 	depends on ARCH_QCOM || COMPILE_TEST
 	help
 	  This enables the AOSS (always on subsystem) reset driver
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · John Stultz

Allow CONFIG_RESET_QCOM_AOSS to be set as as =m to allow for the driver to be loaded from a modules.

Cc Todd Kjos <[email protected]>
Cc Alistair Delva <[email protected]>
Cc Bjorn Andersson <[email protected]>
Quoted 23 lines
Cc Amit Pundir <[email protected]>
Cc Philipp Zabel <[email protected]>
---
 drivers/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/reset/Kconfig +1 -1
index 3ad7817ce1f0..45e70524af36 100644
@@ -99,7 +99,7 @@ config RESET_PISTACHIO
 	  This enables the reset driver for ImgTec Pistachio SoCs.
 
 config RESET_QCOM_AOSS
-	bool "Qcom AOSS Reset Driver"
+	tristate "Qcom AOSS Reset Driver"
 	depends on ARCH_QCOM || COMPILE_TEST
 	help
 	  This enables the AOSS (always on subsystem) reset driver
Signature · 1 line
2.17.1
maintainer
#2 lore raw
In reply to John Stultz
Quoted 18 lines · John Stultz

Allow CONFIG_RESET_QCOM_AOSS to be set as as =m to allow for the driver to be loaded from a modules.

Cc Todd Kjos <[email protected]>
Cc Alistair Delva <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Amit Pundir <[email protected]>
Cc Philipp Zabel <[email protected]>
---
 drivers/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/reset/Kconfig +0 -0
index 3ad7817ce1f0..45e70524af36 100644

drivers/reset/Kconfig config RESET_PISTACHIO · line 102

Quoted 5 lines
drivers/reset/Kconfig +1 -1
@@ -99,7 +99,7 @@ config RESET_PISTACHIO
 	  This enables the reset driver for ImgTec Pistachio SoCs.
 
 config RESET_QCOM_AOSS
-	bool "Qcom AOSS Reset Driver"
+	tristate "Qcom AOSS Reset Driver"

This doesn't seem right on its own, the driver still uses builtin_platform_driver().

regards
Philipp

#3 lore raw
Quoted 21 lines · Philipp Zabel
Quoted 20 lines · John Stultz

Allow CONFIG_RESET_QCOM_AOSS to be set as as =m to allow for the driver to be loaded from a modules.

Cc Todd Kjos <[email protected]>
Cc Alistair Delva <[email protected]>
Cc Bjorn Andersson <[email protected]>
Cc Amit Pundir <[email protected]>
Cc Philipp Zabel <[email protected]>
---
 drivers/reset/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/reset/Kconfig +0 -0
index 3ad7817ce1f0..45e70524af36 100644
@@ -99,7 +99,7 @@ config RESET_PISTACHIO
        This enables the reset driver for ImgTec Pistachio SoCs.
 
Quoted 6 lines

drivers/reset/Kconfig config RESET_PISTACHIO · line 102

Quoted 3 lines
drivers/reset/Kconfig +1 -1
 config RESET_QCOM_AOSS
-     bool "Qcom AOSS Reset Driver"
+     tristate "Qcom AOSS Reset Driver"

This doesn't seem right on its own, the driver still uses builtin_platform_driver().

Huh. Thanks for pointing that out!
It seems like it was working fine as a module with just the kconfig change, but let me double check this and I'll revise with a follow-on patch to address this bit.

Very much appreciate the review!

thanks
-john