locking/qspinlock: Fix inaccessible URL of MCS lock paper
Waiman Long
reviewerPATCH 1/1 locking/qspinlock: Fix inaccessible URL of MCS lock paper
It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to one that is still accessible.
--- kernel/locking/qspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/locking/qspinlock.c +1 -1
@@ -34,7 +34,7 @@* MCS lock. The paper below provides a good description for this kind * of lock. * -* http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf +* https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf * * This queued spinlock implementation is based on the MCS lock, however to make * it fit the 4 bytes we assume spinlock_t to be, and preserve its existing
Signature · 1 line
2.18.1
Peter Zijlstra
maintainerQuoted 14 lines · Waiman Long
It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to one that is still accessible.
Signed-off-by Waiman Long <[email protected]>--- kernel/locking/qspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/locking/qspinlock.c +0
-0
kernel/locking/qspinlock.c line 37
Quoted 5 lines
kernel/locking/qspinlock.c +1
-1@@ -34,7 +34,7 @@* MCS lock. The paper below provides a good description for this kind * of lock. * -* http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf +* https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf
Do we want to stick a copy of the paper in our bugzilla and link that instead? ISTR we do something similar elsewhere, but I'm having trouble finding it.
Thomas, Konstantin?
Peter Zijlstra
maintainerQuoted 25 lines · Peter Zijlstra
Quoted 14 lines · Waiman Long
It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to one that is still accessible.
Signed-off-by Waiman Long <[email protected]>--- kernel/locking/qspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/locking/qspinlock.c +0
-0kernel/locking/qspinlock.c line 37
Quoted 5 lines
kernel/locking/qspinlock.c +1
-1@@ -34,7 +34,7 @@* MCS lock. The paper below provides a good description for this kind * of lock. * -* http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf +* https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf Do we want to stick a copy of the paper in our bugzilla and link that instead? ISTR we do something similar elsewhere, but I'm having trouble finding it.
Quoted 1 line
Thomas, Konstantin?
Boris provided an example from commit:
018ebca8bd70 ("x86/cpufeatures: Enable a new AVX512 CPU feature")
That puts a copy of the relevant Intel document here:
Waiman Long
reviewerQuoted 25 lines · Peter Zijlstra
Quoted 24 lines · Peter Zijlstra
Quoted 14 lines · Waiman Long
It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to one that is still accessible.
Signed-off-by Waiman Long <[email protected]>--- kernel/locking/qspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/locking/qspinlock.c +0
-0kernel/locking/qspinlock.c line 37
Quoted 5 lines
kernel/locking/qspinlock.c +1
-1@@ -34,7 +34,7 @@* MCS lock. The paper below provides a good description for this kind * of lock. * -* http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf +* https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf Do we want to stick a copy of the paper in our bugzilla and link that instead? ISTR we do something similar elsewhere, but I'm having trouble finding it.
Quoted 9 lines
Quoted 1 line
Thomas, Konstantin?
Boris provided an example from commit:
018ebca8bd70("x86/cpufeatures: Enable a new AVX512 CPU feature")That puts a copy of the relevant Intel document here:
OK, that sounds good. I will put a copy of the paper in the BZ and linked it there.
Thanks,
Longman
Will Deacon
maintainerQuoted 29 lines · Waiman Long
Quoted 28 lines · Peter Zijlstra
Quoted 24 lines · Peter Zijlstra
Quoted 14 lines · Waiman Long
It turns out that the URL of the MCS lock paper listed in the source code is no longer accessible. I did got question about where the paper was. This patch updates the URL to one that is still accessible.
Signed-off-by Waiman Long <[email protected]>--- kernel/locking/qspinlock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/locking/qspinlock.c +0
-0kernel/locking/qspinlock.c line 37
Quoted 5 lines
kernel/locking/qspinlock.c +1
-1@@ -34,7 +34,7 @@* MCS lock. The paper below provides a good description for this kind * of lock. * -* http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf +* https://www.cs.rochester.edu/u/scott/papers/1991_TOCS_synch.pdf Do we want to stick a copy of the paper in our bugzilla and link that instead? ISTR we do something similar elsewhere, but I'm having trouble finding it.
Quoted 1 line
Thomas, Konstantin?
Boris provided an example from commit:
Quoted 8 lines
Quoted 6 lines
018ebca8bd70("x86/cpufeatures: Enable a new AVX512 CPU feature")That puts a copy of the relevant Intel document here:
OK, that sounds good. I will put a copy of the paper in the BZ and linked it there.
Thanks. When you update the link in the comment, please can you also include the title of the paper. i.e.
The paper below ("Algorithms for Scalable Synchronization on Shared-Memory Multiprocessors by Mellor-Crummey and Scott") ...
That makes the thing a lot more searchable in case bugzilla is getting DoS'd or whatnot.
Will