Skip to contentSkip to conversation

kallsyms: work around bogus -Wrestrict warning

PATCH In review Arnd Bergmann 4 participants 6 messages Jan 7, 2020 – Jan 9, 2020 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kallsyms: work around bogus -Wrestrict warning

gcc -O3 produces some really odd warnings for this file:

kernel/kallsyms.c: In function 'sprint_symbol':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
strcpy(buffer, name);
^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_symbol_no_offset':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
strcpy(buffer, name);
^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_backtrace':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
strcpy(buffer, name);
^~~~~~~~~~~~~~~~~~~~

This obviously cannot be since it is preceded by an 'if (name != buffer)' check.

Using sprintf() instead of strcpy() is a bit wasteful but is the best workaround I could come up with.

Fixes mmtom ("init/Kconfig: enable -O3 for all arches")
---
 kernel/kallsyms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/kallsyms.c +1 -1
index d812b90f4c86..726b8eeb223e 100644
@@ -366,7 +366,7 @@ static int __sprint_symbol(char *buffer, unsigned long address,
 		return sprintf(buffer, "0x%lx", address - symbol_offset);
 
 	if (name != buffer)
-		strcpy(buffer, name);
+		sprintf(buffer, "%s", name);
 	len = strlen(buffer);
 	offset -= symbol_offset;
 
Signature · 1 line
2.20.0
maintainer
#1 lore raw
Quoted 26 lines · On Tue, 7 Jan 2020 22:40:26 +0100 Arnd Bergmann <[email protected]> wrote:

gcc -O3 produces some really odd warnings for this file:

kernel/kallsyms.c: In function 'sprint_symbol':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]

   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_symbol_no_offset':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_backtrace':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~

This obviously cannot be since it is preceded by an 'if (name != buffer)' check.

Using sprintf() instead of strcpy() is a bit wasteful but is the best workaround I could come up with.

...

kernel/kallsyms.c static int __sprint_symbol(char *buffer, unsigned long address, · line 371

Quoted 7 lines
kernel/kallsyms.c +1 -1
@@ -366,7 +366,7 @@ static int __sprint_symbol(char *buffer, unsigned long address,
 		return sprintf(buffer, "0x%lx", address - symbol_offset);
 
 	if (name != buffer)
-		strcpy(buffer, name);
+		sprintf(buffer, "%s", name);
 	len = strlen(buffer);
 	offset -= symbol_offset;

gee, is that even worth "fixing"? Oleksandr, I've seen a couple of these false positives. Do we know if anyone is taking them to the gcc developers?

#2 lore raw

Hi.

Quoted 3 lines · Andrew Morton

gee, is that even worth "fixing"? Oleksandr, I've seen a couple of these false positives. Do we know if anyone is taking them to the gcc developers?

I'm not aware of such an effort. I tend to blame compiler as an option of last resort, but if Arnd gathers enough examples (since he's working on fixing/working around those), it would be reasonable to suggest him to hand over those findings to gcc bugtracker.

Signature · 3 lines
  Best regards,
    Oleksandr Natalenko (post-factum)
    Senior Software Maintenance Engineer
#3 lore raw
In reply to Arnd Bergmann

Hi Arnd,

Quoted 15 lines · On Tue, 7 Jan 2020 22:40:26 +0100 Arnd Bergmann <[email protected]> wrote:

gcc -O3 produces some really odd warnings for this file:

kernel/kallsyms.c: In function 'sprint_symbol':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]

   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_symbol_no_offset':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_backtrace':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
Quoted 2 lines

This obviously cannot be since it is preceded by an 'if (name != buffer)' check.

Hmm, this looks like a bug in gcc.

Quoted 15 lines

Using sprintf() instead of strcpy() is a bit wasteful but is the best workaround I could come up with.

Fixes mmtom ("init/Kconfig: enable -O3 for all arches")
---
 kernel/kallsyms.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/kallsyms.c +0 -0
index d812b90f4c86..726b8eeb223e 100644

kernel/kallsyms.c static int __sprint_symbol(char *buffer, unsigned long address, · line 369

Quoted 5 lines
kernel/kallsyms.c +1 -1
@@ -366,7 +366,7 @@ static int __sprint_symbol(char *buffer, unsigned long address,
 		return sprintf(buffer, "0x%lx", address - symbol_offset);
 
 	if (name != buffer)
-		strcpy(buffer, name);
+		sprintf(buffer, "%s", name);

BTW, this seems not happen. kallsyms_lookup() (and it's subfunctions) always stores the result into buffer unless name == NULL. Maybe we can remove these 2 lines?
(and add a comment line for kallsyms_lookup() so that it guarantees the
symbol name always stored in namebuf argument)

Thank you,

Signature · 1 line
Masami Hiramatsu <[email protected]>
maintainer
#4 lore raw
Quoted 20 lines · On Wed, 8 Jan 2020 10:26:02 +0900 Masami Hiramatsu <[email protected]> wrote:

Hi Arnd,

Quoted 15 lines · On Tue, 7 Jan 2020 22:40:26 +0100 Arnd Bergmann <[email protected]> wrote:

gcc -O3 produces some really odd warnings for this file:

kernel/kallsyms.c: In function 'sprint_symbol':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]

   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_symbol_no_offset':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_backtrace':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
Quoted 4 lines
Quoted 2 lines

This obviously cannot be since it is preceded by an 'if (name != buffer)' check.

Hmm, this looks like a bug in gcc.

Yes, we're getting a lot of such reports. I don't think current gcc is ready for this patch so I'll drop it, sorry.

#5 lore raw
Quoted 23 lines · Andrew Morton
Quoted 20 lines · On Wed, 8 Jan 2020 10:26:02 +0900 Masami Hiramatsu <[email protected]> wrote:

Hi Arnd,

Quoted 15 lines · On Tue, 7 Jan 2020 22:40:26 +0100 Arnd Bergmann <[email protected]> wrote:

gcc -O3 produces some really odd warnings for this file:

kernel/kallsyms.c: In function 'sprint_symbol':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]

   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_symbol_no_offset':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
kernel/kallsyms.c: In function 'sprint_backtrace':
kernel/kallsyms.c:369:3: error: 'strcpy' source argument is the same as destination [-Werror=restrict]
   strcpy(buffer, name);
   ^~~~~~~~~~~~~~~~~~~~
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

This obviously cannot be since it is preceded by an 'if (name != buffer)' check.

Hmm, this looks like a bug in gcc.

Yes, we're getting a lot of such reports. I don't think current gcc is ready for this patch so I'll drop it, sorry.

I've been building with gcc-8 and got around 20 false positive warnings, three real bugs
and a few files that introduce increased stack usage. I have sent patches for every one
of these and have a clean randconfig builds again on arm, arm64 and x86 (a few thousand
so far).

Most of the false-positive warnings are for understandable reasons and easy to work around, the one above is probably the most blatant screwup by gcc.

My feeling is that we can deal with the warnings here and I wouldn't mind getting
it enabled in mainline from that perspective, but there are two caveats:

- v5.6 is probably too early since we're close to the merge window and a lot of my fixups have not been merged yet

- I have no good estimate of how many runtime failures there will be. Oleksandr hasn't found any issues after running with -O3 kernels for a longer time, but any significant change to the toolchain likely causes problems for somebody.

Arnd