drm/sun4i: backend: Make sure we enforce the clock rate
PATCH v2 1/2 drm/sun4i: backend: Make sure we enforce the clock rate
The backend needs to run at 300MHz to be functional. This was done so far using assigned-clocks in the device tree, but that is easy to forget, and dosen't provide any other guarantee than the rate is going to be roughly the one requested at probe time.
Therefore it's pretty fragile, so let's just use the exclusive clock API to enforce it.
---
Changes from v1:
- Add test on the clk_set_rate_exclusive return value
--- drivers/gpu/drm/sun4i/sun4i_backend.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/gpu/drm/sun4i/sun4i_backend.c +9 -0
@@ -856,6 +856,13 @@ static int sun4i_backend_bind(struct device *dev, struct device *master, ret =PTR_ERR (backend->mod_clk); goto err_disable_bus_clk; } + + ret =clk_set_rate_exclusive (backend->mod_clk,300000000 ); +if (ret) { +dev_err (dev,"Couldn't set the module clock frequency\n" ); + goto err_disable_bus_clk; + } +clk_prepare_enable (backend->mod_clk); backend->ram_clk =devm_clk_get (dev,"ram" );
@@ -932,6 +939,7 @@ static int sun4i_backend_bind(struct device *dev, struct device *master, err_disable_ram_clk:clk_disable_unprepare (backend->ram_clk); err_disable_mod_clk: +clk_rate_exclusive_put (backend->mod_clk);clk_disable_unprepare (backend->mod_clk); err_disable_bus_clk:clk_disable_unprepare (backend->bus_clk);
@@ -952,6 +960,7 @@ static void sun4i_backend_unbind(struct device *dev, struct device *master,sun4i_backend_free_sat (dev);clk_disable_unprepare (backend->ram_clk); +clk_rate_exclusive_put (backend->mod_clk);clk_disable_unprepare (backend->mod_clk);clk_disable_unprepare (backend->bus_clk);reset_control_assert (backend->reset);
Signature · 6 lines
2.24.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
PATCH v2 2/2 drm/sun4i: drc: Make sure we enforce the clock rate
The DRC needs to run at 300MHz to be functional. This was done so far using assigned-clocks in the device tree, but that is easy to forget, and dosen't provide any other guarantee than the rate is going to be roughly the one requested at probe time.
Therefore it's pretty fragile, so let's just use the exclusive clock API to enforce it.
---
Changes from v1:
- Add test on the clk_set_rate_exclusive return value
--- drivers/gpu/drm/sun4i/sun6i_drc.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/sun4i/sun6i_drc.c +8 -0
@@ -56,6 +56,13 @@ static int sun6i_drc_bind(struct device *dev, struct device *master, ret =PTR_ERR (drc->mod_clk); goto err_disable_bus_clk; } + + ret =clk_set_rate_exclusive (drc->mod_clk,300000000 ); +if (ret) { +dev_err (dev,"Couldn't set the module clock frequency\n" ); + goto err_disable_bus_clk; + } +clk_prepare_enable (drc->mod_clk);return 0 ;
@@ -72,6 +79,7 @@ static void sun6i_drc_unbind(struct device *dev, struct device *master, {struct sun6i_drc *drc =dev_get_drvdata (dev); +clk_rate_exclusive_put (drc->mod_clk);clk_disable_unprepare (drc->mod_clk);clk_disable_unprepare (drc->bus_clk);reset_control_assert (drc->reset);
Signature · 6 lines
2.24.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH v2 2/2] drm/sun4i: drc: Make sure we enforce the clock rate
Quoted 10 lines · Maxime Ripard
The DRC needs to run at 300MHz to be functional. This was done so far using assigned-clocks in the device tree, but that is easy to forget, and dosen't provide any other guarantee than the rate is going to be roughly the one requested at probe time.
Therefore it's pretty fragile, so let's just use the exclusive clock API to enforce it.
Signed-off-by Maxime Ripard <[email protected]>
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maxime Ripard
AppliedRe: [PATCH v2 2/2] drm/sun4i: drc: Make sure we enforce the clock rate
Quoted 7 lines · Chen-Yu Tsai
Quoted 6 lines · Maxime Ripard
The DRC needs to run at 300MHz to be functional. This was done so far using assigned-clocks in the device tree, but that is easy to forget, and dosen't provide any other guarantee than the rate is going to be roughly the one requested at probe time.
Quoted 6 lines
Quoted 4 lines
Therefore it's pretty fragile, so let's just use the exclusive clock API to enforce it.
Signed-off-by Maxime Ripard <[email protected]>Reviewed-by Chen-Yu Tsai <[email protected]>
APplied both, thanks!
Maxime
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 10 lines · Maxime Ripard
The backend needs to run at 300MHz to be functional. This was done so far using assigned-clocks in the device tree, but that is easy to forget, and dosen't provide any other guarantee than the rate is going to be roughly the one requested at probe time.
Therefore it's pretty fragile, so let's just use the exclusive clock API to enforce it.
Signed-off-by Maxime Ripard <[email protected]>
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel