drm: msm: Quiet down plane errors in atomic_check
Subsystems (2)
PATCH 1/1 drm: msm: Quiet down plane errors in atomic_check
With the db845c running AOSP, I see the following error on every
frame on the home screen:
[drm:dpu_plane_atomic_check:915] [dpu error]plane33 invalid src 2880x1620+0+470 line:2560
This is due to the error paths in atomic_check using DPU_ERROR_PLANE(), and the drm_hwcomposer using atomic_check to decide how to composite the frame (thus it expects to see atomic_check to fail).
In order to avoid spamming the logs, this patch converts the DPU_ERROR_PLANE() calls to DPU_DEBUG_PLANE() calls in atomic_check.
Cc Todd Kjos <[email protected]>
Cc Alistair Delva <[email protected]>
Cc Amit Pundir <[email protected]>
Cc Rob Clark <[email protected]>
Cc Sean Paul <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Signed-off-by John Stultz <[email protected]>
--- drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c +6 -6
@@ -858,7 +858,7 @@ static int dpu_plane_atomic_check(struct drm_plane *plane, pdpu->pipe_sblk->maxupscale <<16 , true, true);if (ret) { -DPU_ERROR_PLANE (pdpu,"Check plane state failed (%d)\n" , ret); +DPU_DEBUG_PLANE (pdpu,"Check plane state failed (%d)\n" , ret);return ret; }if (!state->visible)
@@ -884,13 +884,13 @@ static int dpu_plane_atomic_check(struct drm_plane *plane, (!(pdpu->features & DPU_SSPP_SCALER) || !(pdpu->features & (BIT(DPU_SSPP_CSC) | BIT(DPU_SSPP_CSC_10BIT))))) { -DPU_ERROR_PLANE (pdpu, +DPU_DEBUG_PLANE (pdpu,"plane doesn't have scaler/csc for yuv\n" );return -EINVAL ;/* check src bounds */ } else if (!dpu_plane_validate_src(&src, &fb_rect, min_src_size)) { -DPU_ERROR_PLANE (pdpu,"invalid source " DRM_RECT_FMT "\n" , +DPU_DEBUG_PLANE (pdpu,"invalid source " DRM_RECT_FMT "\n" ,DRM_RECT_ARG (&src));return -E2BIG ;
@@ -899,19 +899,19 @@ static int dpu_plane_atomic_check(struct drm_plane *plane, (src.x1 & 0x1 || src.y1 & 0x1 || drm_rect_width(&src) & 0x1 || drm_rect_height(&src) & 0x1)) { -DPU_ERROR_PLANE (pdpu,"invalid yuv source " DRM_RECT_FMT "\n" , +DPU_DEBUG_PLANE (pdpu,"invalid yuv source " DRM_RECT_FMT "\n" ,DRM_RECT_ARG (&src));return -EINVAL ;/* min dst support */ } else if (drm_rect_width(&dst) < 0x1 || drm_rect_height(&dst) < 0x1) { -DPU_ERROR_PLANE (pdpu,"invalid dest rect " DRM_RECT_FMT "\n" , +DPU_DEBUG_PLANE (pdpu,"invalid dest rect " DRM_RECT_FMT "\n" ,DRM_RECT_ARG (&dst));return -EINVAL ;/* check decimated source width */ } else if (drm_rect_width(&src) > max_linewidth) { -DPU_ERROR_PLANE (pdpu,"invalid src " DRM_RECT_FMT " line:%u\n" , +DPU_DEBUG_PLANE (pdpu,"invalid src " DRM_RECT_FMT " line:%u\n" ,DRM_RECT_ARG (&src), max_linewidth);return -E2BIG ; }
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel