package/bustle: select dbus instead of depending on it
PATCH 1/2 package/bustle: select dbus instead of depending on it
--- package/bustle/Config.in | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
package/bustle/Config.in +3 -4
@@ -1,9 +1,9 @@ config BR2_PACKAGE_BUSTLE bool "bustle" depends on BR2_USE_WCHAR # libglib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 - depends on BR2_USE_MMU # libglib2 - depends on BR2_PACKAGE_DBUS # runtime + depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2 + depends on BR2_USE_MMU # dbus, libglib2 + select BR2_PACKAGE_DBUS # runtime select BR2_PACKAGE_LIBPCAP select BR2_PACKAGE_LIBGLIB2 help
@@ -22,5 +22,4 @@ config BR2_PACKAGE_BUSTLE comment "bustle needs a toolchain w/ wchar, threads" depends on BR2_USE_MMU - depends on BR2_PACKAGE_DBUS depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.24.0
PATCH 2/2 package/bustle: bump to version 0.7.5
- Switch homepage to https://gitlab.freedesktop.org/bustle/bustle/
- Switch site to
https://www.freedesktop.org/software/bustle/$(BUSTLE_VERSION)
- Add hash for license file
--- package/bustle/Config.in | 2 +- package/bustle/bustle.hash | 3 ++- package/bustle/bustle.mk | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-)
package/bustle/Config.in +1 -1
@@ -18,7 +18,7 @@ config BR2_PACKAGE_BUSTLE This only installs the command line bustle-pcap tool, not the graphical viewer. - http://www.willthompson.co.uk/bustle/ + https://gitlab.freedesktop.org/bustle/bustle/ comment "bustle needs a toolchain w/ wchar, threads" depends on BR2_USE_MMU
package/bustle/bustle.hash +2 -1
@@ -1,2 +1,3 @@ # Locally calculated -sha256 921c2cbbb957dcb02c3aa8fd1eeff3534cb437fa9eeca1c25206ad1e741a3f14 bustle-0.5.4.tar.gz +sha256 7760a695b25cb264e7342f353dcdc6d2b7faeacdcd85dd14e03c61b18e791664 bustle-0.7.5.tar.gz +sha256 a6d6109e5b086de8e852e451b91b08b323302f55b6975d506c64c43bb094be38 LICENSE
package/bustle/bustle.mk +2 -2
@@ -4,8 +4,8 @@ # ################################################################################ -BUSTLE_VERSION = 0.5.4 -BUSTLE_SITE = http://www.willthompson.co.uk/bustle/releases/$(BUSTLE_VERSION) +BUSTLE_VERSION = 0.7.5 +BUSTLE_SITE = https://www.freedesktop.org/software/bustle/$(BUSTLE_VERSION) BUSTLE_LICENSE = LGPL-2.1+ BUSTLE_LICENSE_FILES = LICENSE BUSTLE_DEPENDENCIES = libglib2 libpcap host-pkgconf
Signature · 1 line
2.24.0
Thomas Petazzoni
AppliedPATCH 2/2 package/bustle: bump to version 0.7.5
Quoted 11 lines · On Sat, 4 Jan 2020 19:45:13 +0100 Fabrice Fontaine…
- Switch homepage to https://gitlab.freedesktop.org/bustle/bustle/
- Switch site to
https://www.freedesktop.org/software/bustle/$(BUSTLE_VERSION)
- Add hash for license fileSigned-off-by Fabrice Fontaine <[email protected]>--- package/bustle/Config.in | 2 +- package/bustle/bustle.hash | 3 ++- package/bustle/bustle.mk | 4 ++-- 3 files changed, 5 insertions(+), 4 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/2 package/bustle: select dbus instead of depending on it
In reply to Fabrice FontaineQuoted 1 line · On Sat, 4 Jan 2020 19:45:12 +0100 Fabrice Fontaine…
Signed-off-by Fabrice Fontaine <[email protected]>
I agree that in general we prefer to use "select" for non-obvious dependencies. But here, the dependency is obvious, and in fact "bustle" is completely useless if you don't use D-Bus: you will only want to even consider enabling bustle if you're already using D-Bus, and want to debug some stuff.
So I think it is a case where a "depends on" dependency makes a lot of sense, very much like Python modules all "depends on" the Python interpreter being present, rather than selecting it.
So I've mark the patch as Rejected in patchwork.
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com