Skip to contentSkip to conversation

package/exim: fix host build

PATCH New Bernd Kuhls 3 participants 3 messages Jan 4, 2020 – Jan 8, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/exim: fix host build

Fixes:
http://autobuild.buildroot.net/results/5a7/5a765f0e65e20266c7203412a46c684a40b66ea3/

---
Locally I cannot reproduce the problem, hopefully this patch will fix the problem.

 package/exim/exim.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/exim/exim.mk +1 -1
index 118ee4a1a4..1f814ef195 100644
@@ -125,7 +125,7 @@ define EXIM_BUILD_CMDS
 	$(HOST_MAKE_ENV) $(MAKE1) -C $(@D)/build-br macro_predef \
 		CC=$(HOSTCC) \
 		LNCC=$(HOSTCC) \
-		CFLAGS="$(HOST_CFLAGS)" \
+		CFLAGS="-std=c99 $(HOST_CFLAGS)" \
 		LFLAGS="-fPIC $(HOST_LDFLAGS)"
 	$(TARGET_MAKE_ENV) build=br $(MAKE1) -C $(@D) $(EXIM_STATIC_FLAGS)
 endef
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/exim: fix host build

Hi Bernd,

Quoted 7 lines · Bernd Kuhls

Fixes:
http://autobuild.buildroot.net/results/5a7/5a765f0e65e20266c7203412a46c684a40b66ea3/

---
Locally I cannot reproduce the problem, hopefully this patch will fix the problem.

I also tried to reproduce the issue locally, but on my host (Ubuntu 18.04) all the builds succeed.

package/exim/exim.mk define EXIM_BUILD_CMDS · line 128

Quoted 13 lines
 package/exim/exim.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/exim/exim.mk +1 -1
index 118ee4a1a4..1f814ef195 100644
@@ -125,7 +125,7 @@ define EXIM_BUILD_CMDS
 	$(HOST_MAKE_ENV) $(MAKE1) -C $(@D)/build-br macro_predef \
 		CC=$(HOSTCC) \
 		LNCC=$(HOSTCC) \
-		CFLAGS="$(HOST_CFLAGS)" \
+		CFLAGS="-std=c99 $(HOST_CFLAGS)" \

Applying your patch the builds still work, as expected. Then I tried to pass -std=c90 instead of c99, and bang, they started failing! So I also assume your patch solves the failure.

Signature · 1 line
Luca
#2 lore raw

PATCH 1/1 package/exim: fix host build

In reply to Bernd Kuhls
Quoted 7 lines · On Sat, 4 Jan 2020 22:34:59 +0100 Bernd Kuhls <[email protected]> wrote:

Fixes:
http://autobuild.buildroot.net/results/5a7/5a765f0e65e20266c7203412a46c684a40b66ea3/

---
Locally I cannot reproduce the problem, hopefully this patch will fix the problem.

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com