Skip to contentSkip to conversation

fs: omfs: use kmemdup

PATCH New Chen Zhou 1 participant 1 message Jan 8, 2020 Omfs filesystem

lore
Share & tools
lore

Chen Zhou

author
#0 lore raw

PATCH 1/1 fs: omfs: use kmemdup

Fix memdup.cocci warnings:
./fs/omfs/inode.c:366:9-16: WARNING opportunity for kmemdup

Use kmemdup rather than duplicating its implementation.

---
 fs/omfs/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/omfs/inode.c +1 -2
index b76ec6b..8867cef 100644
@@ -363,12 +363,11 @@ static int omfs_get_imap(struct super_block *sb)
 		bh = sb_bread(sb, block++);
 		if (!bh)
 			goto nomem_free;
-		*ptr = kmalloc(sb->s_blocksize, GFP_KERNEL);
+		*ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL);
 		if (!*ptr) {
 			brelse(bh);
 			goto nomem_free;
 		}
-		memcpy(*ptr, bh->b_data, sb->s_blocksize);
 		if (count < sb->s_blocksize)
 			memset((void *)*ptr + count, 0xff,
 				sb->s_blocksize - count);
Signature · 1 line
2.7.4