display/gtk: get proper refreshrate
PATCH v4 1/1 display/gtk: get proper refreshrate
From: Nikola Pavlica <[email protected]>
Hi,
QEMU mailing list.
This is the fourth revision of the patch involving the GTK display output getting the proper refresh rate for your particular display output.
Because some VMs in QEMU can get GPU virtualization (using technologies such as iGVT-g, as mentioned previously), they could produce a video output that had a higher display refresh rate than of what the GTK display was displaying. (fxp. Playing a video game inside of a Windows VM at 60 Hz, while the output stood locked at 33 Hz because of defaults set in include/ui/console.h)
Since QEMU does indeed have internal systems for determining frame times as defined in ui/console.c.
The code checks for a variable called update_interval that it later uses for time calculation. This variable, however, isn't defined anywhere in ui/gtk.c and instead ui/console.c just sets it to GUI_REFRESH_INTERVAL_DEFAULT which is 30
update_interval represents the number of milliseconds per display refresh, and by doing some math we get that 1000/30 = 33.33... Hz
This creates the mentioned problem and what this patch does is that it checks for the display refresh rate reported by GTK itself (we can take this as a safe value) and just converts it back to a number of milliseconds per display refresh.
Explinations of each revision:
v1: initial patch
v2: moved code to a more appropriate place and reduced overhead and memory usage (by not creating a new GdkDisplay)
v3: removed magic value and turned it into something more readable and added checks for an error state where GTK was unable to get the refresh rate, in which case we use the already existing default
v4: fixed wrapping and repositioned variable names
--- include/ui/gtk.h | 2 ++ ui/gtk.c | 10 ++++++++++ 2 files changed, 12 insertions(+)
include/ui/gtk.h +2 -0
@@ -28,6 +28,8 @@#include "ui/egl-context.h" #endif +#define MILLISEC_PER_SEC 1000000 +typedef struct GtkDisplayState GtkDisplayState ; typedef struct VirtualGfxConsole {
ui/gtk.c +10 -0
@@ -1966,6 +1966,10 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc, GSList *group, GtkWidget *view_menu) {bool zoom_to_fit = false; +int refresh_rate_millihz; +GdkDisplay *dpy =gtk_widget_get_display (s->window); +GdkWindow *win =gtk_widget_get_window (s->window); +GdkMonitor *monitor =gdk_display_get_monitor_at_window (dpy, win); vc->label =qemu_console_get_label (con); vc->s = s;
@@ -2026,6 +2030,12 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc, vc->gfx.kbd =qkbd_state_init (con); vc->gfx.dcl.con = con; + + refresh_rate_millihz =gdk_monitor_get_refresh_rate (monitor); +if (refresh_rate_millihz) { + vc->gfx.dcl.update_interval =MILLISEC_PER_SEC / refresh_rate_millihz; + } +register_displaychangelistener (&vc->gfx.dcl);gd_connect_vc_gfx_signals (vc);
Signature · 1 line
2.24.1
Quoted 1 line · On 1/8/20 12:20 PM, [email protected] wrote:
From: Nikola Pavlica <[email protected]>
Assuming Gerd can
[cut this ...
Quoted 7 lines
Hi,
QEMU mailing list.This is the fourth revision of the patch involving the GTK display output getting the proper refresh rate for your particular display output.
... until here]
Quoted 15 lines
Because some VMs in QEMU can get GPU virtualization (using technologies such as iGVT-g, as mentioned previously), they could produce a video output that had a higher display refresh rate than of what the GTK display was displaying. (fxp. Playing a video game inside of a Windows VM at 60 Hz, while the output stood locked at 33 Hz because of defaults set in
include/ui/console.h)Since QEMU does indeed have internal systems for determining frame times as defined in
ui/console.c.
The code checks for a variable calledupdate_intervalthat it later uses for time calculation. This variable, however, isn't defined anywhere inui/gtk.cand insteadui/console.cjust sets it toGUI_REFRESH_INTERVAL_DEFAULTwhich is 30
Quoted 7 lines
update_intervalrepresents the number of milliseconds per display refresh, and by doing some math we get that 1000/30 = 33.33... HzThis creates the mentioned problem and what this patch does is that it checks for the display refresh rate reported by GTK itself (we can take this as a safe value) and just converts it back to a number of milliseconds per display refresh.
[And cut this...
Quoted 9 lines
Explinations of each revision:
v1: initial patch
v2: moved code to a more appropriate place and reduced overhead and memory usage (by not creating a new GdkDisplay)
v3: removed magic value and turned it into something more readable and added checks for an error state where GTK was unable to get the refresh rate, in which case we use the already existing default
v4: fixed wrapping and repositioned variable names
... until here]
Then:
Quoted 49 lines
Signed-off-by Nikola Pavlica <[email protected]>--- include/ui/gtk.h | 2 ++ ui/gtk.c | 10 ++++++++++ 2 files changed, 12 insertions(+)include/ui/gtk.h +2
-0@@ -28,6 +28,8 @@#include "ui/egl-context.h" #endif +#define MILLISEC_PER_SEC 1000000 +typedef struct GtkDisplayState GtkDisplayState ; typedef struct VirtualGfxConsole {ui/gtk.c +10
-0@@ -1966,6 +1966,10 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc, GSList *group, GtkWidget *view_menu) {bool zoom_to_fit = false; +int refresh_rate_millihz; +GdkDisplay *dpy =gtk_widget_get_display (s->window); +GdkWindow *win =gtk_widget_get_window (s->window); +GdkMonitor *monitor =gdk_display_get_monitor_at_window (dpy, win); vc->label =qemu_console_get_label (con); vc->s = s;@@ -2026,6 +2030,12 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s, VirtualConsole *vc, vc->gfx.kbd =qkbd_state_init (con); vc->gfx.dcl.con = con; + + refresh_rate_millihz =gdk_monitor_get_refresh_rate (monitor); +if (refresh_rate_millihz) { + vc->gfx.dcl.update_interval =MILLISEC_PER_SEC / refresh_rate_millihz; + } +register_displaychangelistener (&vc->gfx.dcl);gd_connect_vc_gfx_signals (vc);