Skip to contentSkip to conversation

thunderbolt: Fix and MAINTAINERS update

PATCH New Mika Westerberg 1 participant 3 messages Jan 8, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover thunderbolt: Fix and MAINTAINERS update

Hi,

The first patch fixes an issue reported by Dan Carpenter and the second updates MAINTAINERS to use linux-usb as mailing list for Thunderbolt and USB4 related patches.

Greg, can you pick these to your usb-next branch if there are no objections?

Mika Westerberg (2):
thunderbolt: Fix xhci check in usb4_switch_setup()
MAINTAINERS: Use linux-usb mailing list for Thunderbolt and USB4 patches

 MAINTAINERS                | 1 +
 drivers/thunderbolt/usb4.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.24.1
#1 lore raw

PATCH 1/2 thunderbolt: Fix xhci check in usb4_switch_setup()

The code tried to check whether xhci variable has ROUTER_CS_6_HCI bit set but since xhci type is bool and it already holds true or false based on that very bit, fix the check to use the variable directly.

Fixes b04079837b20 ("thunderbolt: Add initial support for USB4")
---
 drivers/thunderbolt/usb4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/usb4.c +1 -1
index dbe7ecce4505..b341fc60c4ba 100644
@@ -239,7 +239,7 @@ int usb4_switch_setup(struct tb_switch *sw)
 		 * and the parent does not have any USB3 dowstream
 		 * adapters (so we cannot do USB 3.x tunneling).
 		 */
-		if (xhci & ROUTER_CS_6_HCI)
+		if (xhci)
 			val |= ROUTER_CS_5_HCO;
 	}
 
Signature · 1 line
2.24.1
#2 lore raw

PATCH 2/2 MAINTAINERS: Use linux-usb mailing list for Thunderbolt and USB4 patches

In reply to Mika Westerberg

Now that Thunderbolt public specification is called USB4 and is coming from USB IF it makes sense to use linux-usb as mailing list for patches touching this driver.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index 8982c6e013b3..57cdf745e92e 100644
@@ -16375,6 +16375,7 @@ M:	Andreas Noever <[email protected]>
 M:	Michael Jamet <[email protected]>
 M:	Mika Westerberg <[email protected]>
 M:	Yehezkel Bernat <[email protected]>
+L:	[email protected]
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git
 S:	Maintained
 F:	Documentation/admin-guide/thunderbolt.rst
Signature · 1 line
2.24.1