Skip to contentSkip to conversation

virtiofsd: Enable xattr support by default

PATCH In review Vivek Goyal 3 participants 4 messages Jan 8, 2020 – Jan 9, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtiofsd: Enable xattr support by default

Enable xattr support by default. Currently it is disabled by defaut and that makes getfattr/setfattr fail in guest.

---
 contrib/virtiofsd/passthrough_ll.c |    1 +
 1 file changed, 1 insertion(+)
contrib/virtiofsd/passthrough_ll.c +1 -0
Index: qemu/contrib/virtiofsd/passthrough_ll.c
===================================================================
@@ -3096,6 +3096,7 @@ int main(int argc, char *argv[])
 	                      .writeback = 0,
 			      .posix_lock = 1,
 	                      .proc_self_fd = -1,
+			      .xattr = 1,
 	};
 	struct lo_map_elem *root_elem;
 	int ret = -1;
#1 lore raw
Quoted 3 lines · Vivek Goyal

Enable xattr support by default. Currently it is disabled by defaut and that makes getfattr/setfattr fail in guest.

I think the reason this was disabled by default is that it's a significant performance hit for "ls" due to missing xattr caching. Not sure how much it affects other workloads.

Thanks,
Miklos

#2 lore raw
Quoted 9 lines · Miklos Szeredi
Quoted 3 lines · Vivek Goyal

Enable xattr support by default. Currently it is disabled by defaut and that makes getfattr/setfattr fail in guest.

I think the reason this was disabled by default is that it's a significant performance hit for "ls" due to missing xattr caching. Not sure how much it affects other workloads.

Aha... so this is intentional and not just an oversight. So maybe we can leave it disabled by default for now and let people enable it as need be (-o xattr).

Thanks
Vivek

#3 lore raw
Quoted 6 lines · Vivek Goyal
Quoted 5 lines · Miklos Szeredi
Quoted 3 lines · Vivek Goyal

Enable xattr support by default. Currently it is disabled by defaut and that makes getfattr/setfattr fail in guest.

Quoted 8 lines
Quoted 4 lines

I think the reason this was disabled by default is that it's a significant performance hit for "ls" due to missing xattr caching. Not sure how much it affects other workloads.

Aha... so this is intentional and not just an oversight. So maybe we can leave it disabled by default for now and let people enable it as need be (-o xattr).

I've added this issue to the virtio-fs issue tracker:

https://gitlab.com/virtio-fs/qemu/issues/15

Stefan