Skip to contentSkip to conversation

hw/smbios/smbios: Remove unused include

PATCH Applied Philippe Mathieu-Daudé 3 participants 3 messages Jan 9, 2020 – Feb 6, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/smbios/smbios: Remove unused include

Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.

---
 hw/smbios/smbios.c | 1 -
 1 file changed, 1 deletion(-)
hw/smbios/smbios.c +0 -1
index ded5f1f4e2..1a0f461541 100644
@@ -24,7 +24,6 @@
 #include "qemu/option.h"
 #include "sysemu/sysemu.h"
 #include "qemu/uuid.h"
-#include "sysemu/cpus.h"
 #include "hw/firmware/smbios.h"
 #include "hw/loader.h"
 #include "hw/boards.h"
Signature · 1 line
2.21.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Philippe Mathieu-Daudé

Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.

Quoted 18 lines
---
 hw/smbios/smbios.c | 1 -
 1 file changed, 1 deletion(-)
hw/smbios/smbios.c +0 -1
index ded5f1f4e2..1a0f461541 100644
@@ -24,7 +24,6 @@
 #include "qemu/option.h"
 #include "sysemu/sysemu.h"
 #include "qemu/uuid.h"
-#include "sysemu/cpus.h"
 #include "hw/firmware/smbios.h"
 #include "hw/loader.h"
 #include "hw/boards.h"
Signature · 1 line
2.21.1
#2 lore raw
In reply to Philippe Mathieu-Daudé

Le 09/01/2020 à 12:25, Philippe Mathieu-Daudé a écrit :

Quoted 13 lines

Nothing from "sysemu/cpus.h" is used by smbios.c, remove the include.

---
 hw/smbios/smbios.c | 1 -
 1 file changed, 1 deletion(-)
hw/smbios/smbios.c +0 -0
index ded5f1f4e2..1a0f461541 100644

hw/smbios/smbios.c line 29

Quoted 7 lines
hw/smbios/smbios.c +0 -1
@@ -24,7 +24,6 @@
 #include "qemu/option.h"
 #include "sysemu/sysemu.h"
 #include "qemu/uuid.h"
-#include "sysemu/cpus.h"
 #include "hw/firmware/smbios.h"
 #include "hw/loader.h"
 #include "hw/boards.h"

Applied to my trivial-patches branch.

Thanks,
Laurent