Skip to contentSkip to conversation

reiserfs broke between 4.9.205 and 4.9.208

DISCUSSION Michael Brunnbauer 4 participants 8 messages Jan 8, 2020 – Jan 15, 2020

lore
Share & tools
lore
#0 lore raw

hi

after upgrading from 4.9.205 to 4.9.208, I get errors on two different reiserfs filesystems when doing cp -a (the chown part seems to fail) and on other occasions:

kernel: REISERFS warning (device sda1): jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-95)

kernel: REISERFS warning (device sdc1): jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-95)

This behaviour disappeared after a downgrade to 4.9.205.

I understand there have been changes to the file system code but I'm not sure they affect reiserfs, e.g.

https://bugzilla.kernel.org/show_bug.cgi?id=205433

Any Idea?

Regards,

Michael Brunnbauer

Signature · 13 lines
++  Michael Brunnbauer
++  netEstate GmbH
++  Geisenhausener Straße 11a
++  81379 München
++  Tel +49 89 32 19 77 80
++  Fax +49 89 32 19 77 89 
++  E-Mail [email protected]
++  https://www.netestate.de/
++
++  Sitz: München, HRB Nr.142452 (Handelsregister B München)
++  USt-IdNr. DE221033342
++  Geschäftsführer: Michael Brunnbauer, Franz Brunnbauer
++  Prokurist: Dipl. Kfm. (Univ.) Markus Hendel
#1 lore raw
Quoted 16 lines · Michael Brunnbauer

hi

after upgrading from 4.9.205 to 4.9.208, I get errors on two different reiserfs filesystems when doing cp -a (the chown part seems to fail) and on other occasions:

kernel: REISERFS warning (device sda1): jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-95)

kernel: REISERFS warning (device sdc1): jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-95)

This behaviour disappeared after a downgrade to 4.9.205.

I understand there have been changes to the file system code but I'm not sure they affect reiserfs, e.g.

Quoted 8 lines

https://bugzilla.kernel.org/show_bug.cgi?id=205433

Any Idea?

Regards,

Michael Brunnbauer

Looks to me like 4.9.207 contains reiserfs changes.

Adding CC's.

Signature · 1 line
~Randy
#2 lore raw

Hello,

Quoted 18 lines · Randy Dunlap
Quoted 17 lines · Michael Brunnbauer

after upgrading from 4.9.205 to 4.9.208, I get errors on two different reiserfs filesystems when doing cp -a (the chown part seems to fail) and on other occasions:

kernel: REISERFS warning (device sda1): jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-95)

kernel: REISERFS warning (device sdc1): jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-95)

This behaviour disappeared after a downgrade to 4.9.205.

I understand there have been changes to the file system code but I'm not sure they affect reiserfs, e.g.

https://bugzilla.kernel.org/show_bug.cgi?id=205433

Any Idea?

Quoted 8 lines
Quoted 4 lines

Regards,

Michael Brunnbauer

Looks to me like 4.9.207 contains reiserfs changes.

Adding CC's.

Looks like a regression from commit 60e4cf67a582 "reiserfs: fix extended attributes on the root directory". We are getting -EOPNOTSUPP from reiserfs_for_each_xattr() likely originally from open_xa_root(). Previously we were returning -ENODATA from there which error reiserfs_for_each_xattr() converted to 0. I don't understand reiserfs xattrs enough to quickly tell what should actually be happening after the Jeff's change - naively I'd think we should just silence the bogus warning in case of EOPNOTSUPP. Jeff, can you have a look?

Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it just that the kernel is spewing these annoying warnings? Because from the code reading I'd think that it is only the kernel spewing errors but userspace should be fine...

Honza

Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
#3 lore raw

Hello Jan,

Quoted 4 lines · Jan Kara

Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it just that the kernel is spewing these annoying warnings? Because from the code reading I'd think that it is only the kernel spewing errors but userspace should be fine...

Yes, 'cp -a' returns errors and files are owned by root instead of the correct user after copying as root.

Regards,

Michael Brunnbauer

Signature · 13 lines
++  Michael Brunnbauer
++  netEstate GmbH
++  Geisenhausener Straße 11a
++  81379 München
++  Tel +49 89 32 19 77 80
++  Fax +49 89 32 19 77 89 
++  E-Mail [email protected]
++  https://www.netestate.de/
++
++  Sitz: München, HRB Nr.142452 (Handelsregister B München)
++  USt-IdNr. DE221033342
++  Geschäftsführer: Michael Brunnbauer, Franz Brunnbauer
++  Prokurist: Dipl. Kfm. (Univ.) Markus Hendel
#4 lore raw

hi all,

is this been looked into? Do you need more information?

Regards,

Michael Brunnbauer

Quoted 30 lines · Michael Brunnbauer

Hello Jan,

Quoted 4 lines · Jan Kara

Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it just that the kernel is spewing these annoying warnings? Because from the code reading I'd think that it is only the kernel spewing errors but userspace should be fine...

Yes, 'cp -a' returns errors and files are owned by root instead of the correct user after copying as root.

Regards,

Michael Brunnbauer

Signature · 13 lines
++  Michael Brunnbauer
++  netEstate GmbH
++  Geisenhausener Straße 11a
++  81379 München
++  Tel +49 89 32 19 77 80
++  Fax +49 89 32 19 77 89 
++  E-Mail [email protected]
++  https://www.netestate.de/
++
++  Sitz: München, HRB Nr.142452 (Handelsregister B München)
++  USt-IdNr. DE221033342
++  Geschäftsführer: Michael Brunnbauer, Franz Brunnbauer
++  Prokurist: Dipl. Kfm. (Univ.) Markus Hendel
Signature · 13 lines
++  Michael Brunnbauer
++  netEstate GmbH
++  Geisenhausener Straße 11a
++  81379 München
++  Tel +49 89 32 19 77 80
++  Fax +49 89 32 19 77 89 
++  E-Mail [email protected]
++  https://www.netestate.de/
++
++  Sitz: München, HRB Nr.142452 (Handelsregister B München)
++  USt-IdNr. DE221033342
++  Geschäftsführer: Michael Brunnbauer, Franz Brunnbauer
++  Prokurist: Dipl. Kfm. (Univ.) Markus Hendel
#5 lore raw

Hi Michael -

It looks like something must've gone sideways with the backport since 5.5-rc6 works as expected. I'll dig into it a bit.

-Jeff

Quoted 25 lines · Michael Brunnbauer

hi all,

is this been looked into? Do you need more information?

Regards,

Michael Brunnbauer

Quoted 15 lines · Michael Brunnbauer

Hello Jan,

Quoted 4 lines · Jan Kara

Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it just that the kernel is spewing these annoying warnings? Because from the code reading I'd think that it is only the kernel spewing errors but userspace should be fine...

Yes, 'cp -a' returns errors and files are owned by root instead of the correct user after copying as root.

Regards,

Michael Brunnbauer

Signature · 2 lines
Jeff Mahoney
Director, SUSE Labs Data & Performance
#6 lore raw

Nevermind. I just wasn't reproducing properly. Jan's analysis is right. The -EOPNOTSUPP change is required so that we get the right error when explicit xattr operations are performed on a file system without them. Prior to this change, we'd get -EOPNOTSUPP by sb->s_xattr being NULL.

reiserfs_for_each_xattr needs to handle this the same way we already handle -ENODATA.

-Jeff

Quoted 35 lines · Jeff Mahoney

Hi Michael -

It looks like something must've gone sideways with the backport since 5.5-rc6 works as expected. I'll dig into it a bit.

-Jeff

Quoted 25 lines · Michael Brunnbauer

hi all,

is this been looked into? Do you need more information?

Regards,

Michael Brunnbauer

Quoted 15 lines · Michael Brunnbauer

Hello Jan,

Quoted 4 lines · Jan Kara

Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it just that the kernel is spewing these annoying warnings? Because from the code reading I'd think that it is only the kernel spewing errors but userspace should be fine...

Yes, 'cp -a' returns errors and files are owned by root instead of the correct user after copying as root.

Regards,

Michael Brunnbauer

Signature · 2 lines
Jeff Mahoney
Director, SUSE Labs Data & Performance
#7 lore raw
In reply to Jan Kara
Quoted 40 lines · Jan Kara

Hello,

Quoted 18 lines · Randy Dunlap
Quoted 17 lines · Michael Brunnbauer

after upgrading from 4.9.205 to 4.9.208, I get errors on two different reiserfs filesystems when doing cp -a (the chown part seems to fail) and on other occasions:

kernel: REISERFS warning (device sda1): jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-95)

kernel: REISERFS warning (device sdc1): jdm-20004 reiserfs_delete_xattrs: Couldn't delete all xattrs (-95)

This behaviour disappeared after a downgrade to 4.9.205.

I understand there have been changes to the file system code but I'm not sure they affect reiserfs, e.g.

https://bugzilla.kernel.org/show_bug.cgi?id=205433

Any Idea?

Quoted 8 lines
Quoted 4 lines

Regards,

Michael Brunnbauer

Looks to me like 4.9.207 contains reiserfs changes.

Adding CC's.

Looks like a regression from commit 60e4cf67a582 "reiserfs: fix extended attributes on the root directory". We are getting -EOPNOTSUPP from reiserfs_for_each_xattr() likely originally from open_xa_root(). Previously we were returning -ENODATA from there which error reiserfs_for_each_xattr() converted to 0. I don't understand reiserfs xattrs enough to quickly tell what should actually be happening after the Jeff's change - naively I'd think we should just silence the bogus warning in case of EOPNOTSUPP. Jeff, can you have a look?

Quoted 4 lines

Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it just that the kernel is spewing these annoying warnings? Because from the code reading I'd think that it is only the kernel spewing errors but userspace should be fine...

This error occurs when extended attributes are not enabled on the file system *and* the module is not built with extended attributes enabled. I've sent out the fix for it just now.

-Jeff

Signature · 2 lines
Jeff Mahoney
Director, SUSE Labs Data & Performance