Add new series Micron SPI NAND devices
Subsystems (2)
cover Add new series Micron SPI NAND devices
From: Shivamurthy Shastri <[email protected]>
This patch is for the new series of Micron SPI NAND devices and the below datasheet links are for the new devices.
M78A:
[1] https://www.micron.com/~/media/documents/products/data-sheet/nand-flash/70-series/m78a_1gb_3v_nand_spi.pdf
[2] https://www.micron.com/~/media/documents/products/data-sheet/nand-flash/70-series/m78a_1gb_1_8v_nand_spi.pdf
M79A:
[3] https://www.micron.com/~/media/documents/products/data-sheet/nand-flash/70-series/m79a_2gb_1_8v_nand_spi.pdf
[4] https://www.micron.com/~/media/documents/products/data-sheet/nand-flash/70-series/m79a_ddp_4gb_3v_nand_spi.pdf
M70A:
[5] https://www.micron.com/~/media/documents/products/data-sheet/nand-flash/70-series/m70a_4gb_3v_nand_spi.pdf
[6] https://www.micron.com/~/media/documents/products/data-sheet/nand-flash/70-series/m70a_4gb_1_8v_nand_spi.pdf
[7] https://www.micron.com/~/media/documents/products/data-sheet/nand-flash/70-series/m70a_ddp_8gb_3v_nand_spi.pdf
[8] https://www.micron.com/~/media/documents/products/data-sheet/nand-flash/70-series/m70a_ddp_8gb_1_8v_nand_spi.pdf
Shivamurthy Shastri (1):
mtd: spinand: Add support for new Micron SPI NAND devices
drivers/mtd/nand/spi/micron.c | 129 +++++++++++++++++++++++++++++++--- 1 file changed, 118 insertions(+), 11 deletions(-)
Signature · 1 line
2.17.1
PATCH 1/1 mtd: spinand: Add support for new Micron SPI NAND devices
From: Shivamurthy Shastri <[email protected]>
Add device table for new Micron SPI NAND devices. While at it, add support to the multi-die selection. Also, generalize the OOB layout structure and function names.
--- drivers/mtd/nand/spi/micron.c | 135 ++++++++++++++++++++++++++++++---- 1 file changed, 121 insertions(+), 14 deletions(-)
drivers/mtd/nand/spi/micron.c +121 -14
@@ -34,38 +34,38 @@ static SPINAND_OP_VARIANTS(update_cache_variants,SPINAND_PROG_LOAD_X4 (false,0 ,NULL ,0 ), SPINAND_PROG_LOAD(false, 0, NULL, 0)); -static int mt29f2g01abagd_ooblayout_ecc (struct mtd_info *mtd,int section, -struct mtd_oob_region *region) +static int micron_8_ooblayout_ecc (struct mtd_info *mtd,int section, +struct mtd_oob_region *region) {if (section)return -ERANGE ; - region->offset =64 ; - region->length =64 ; + region->offset = mtd->oobsize /2 ; + region->length = mtd->oobsize /2 ;return 0 ; } -static int mt29f2g01abagd_ooblayout_free (struct mtd_info *mtd,int section, -struct mtd_oob_region *region) +static int micron_8_ooblayout_free (struct mtd_info *mtd,int section, +struct mtd_oob_region *region) {if (section)return -ERANGE ;/* Reserve 2 bytes for the BBM. */ region->offset =2 ; - region->length =62 ; + region->length = (mtd->oobsize /2 ) -2 ;return 0 ; } -static const struct mtd_ooblayout_ops mt29f2g01abagd_ooblayout = { - .ecc = mt29f2g01abagd_ooblayout_ecc, - .free = mt29f2g01abagd_ooblayout_free, +static const struct mtd_ooblayout_ops micron_8_ooblayout = { + .ecc = micron_8_ooblayout_ecc, + .free = micron_8_ooblayout_free, }; -static int mt29f2g01abagd_ecc_get_status (struct spinand_device *spinand, -u8 status) +static int micron_8_ecc_get_status (struct spinand_device *spinand, +u8 status) {switch (status &MICRON_STATUS_ECC_MASK ) {case STATUS_ECC_NO_BITFLIPS :
@@ -90,7 +90,20 @@ static int mt29f2g01abagd_ecc_get_status(struct spinand_device *spinand,return -EINVAL ; } +static int micron_select_target (struct spinand_device *spinand, +unsigned int target) +{ +struct spi_mem_op op =SPINAND_SET_FEATURE_OP (0xd0 , + spinand->scratchbuf); + +if (target ==1 ) + *spinand->scratchbuf =0x40 ; + +return spi_mem_exec_op (spinand->spimem, &op); +} +static const struct spinand_info micron_spinand_table[] = { +/* M79A 2Gb 3.3V */ SPINAND_INFO("MT29F2G01ABAGD", 0x24, NAND_MEMORG(1, 2048, 128, 64, 2048, 40, 2, 1, 1), NAND_ECCREQ(8, 512),
@@ -98,8 +111,91 @@ static const struct spinand_info micron_spinand_table[] = { &write_cache_variants, &update_cache_variants), 0, - SPINAND_ECCINFO(&mt29f2g01abagd_ooblayout, - mt29f2g01abagd_ecc_get_status)), + SPINAND_ECCINFO(µn_8_ooblayout, + micron_8_ecc_get_status)), +/* M79A 2Gb 1.8V */ +SPINAND_INFO ("MT29F2G01ABBGD" ,0x25 , +NAND_MEMORG (1 ,2048 ,128 ,64 ,2048 ,40 ,2 ,1 ,1 ), +NAND_ECCREQ (8 ,512 ), +SPINAND_INFO_OP_VARIANTS (&read_cache_variants, + &write_cache_variants, + &update_cache_variants), +0 , +SPINAND_ECCINFO (µn_8_ooblayout, + micron_8_ecc_get_status)), +/* M78A 1Gb 3.3V */ +SPINAND_INFO ("MT29F1G01ABAFD" ,0x14 , +NAND_MEMORG (1 ,2048 ,128 ,64 ,1024 ,20 ,1 ,1 ,1 ), +NAND_ECCREQ (8 ,512 ), +SPINAND_INFO_OP_VARIANTS (&read_cache_variants, + &write_cache_variants, + &update_cache_variants), +0 , +SPINAND_ECCINFO (µn_8_ooblayout, + micron_8_ecc_get_status)), +/* M78A 1Gb 1.8V */ +SPINAND_INFO ("MT29F1G01ABAFD" ,0x15 , +NAND_MEMORG (1 ,2048 ,128 ,64 ,1024 ,20 ,1 ,1 ,1 ), +NAND_ECCREQ (8 ,512 ), +SPINAND_INFO_OP_VARIANTS (&read_cache_variants, + &write_cache_variants, + &update_cache_variants), +0 , +SPINAND_ECCINFO (µn_8_ooblayout, + micron_8_ecc_get_status)), +/* M79A 4Gb 3.3V */ +SPINAND_INFO ("MT29F4G01ADAGD" ,0x36 , +NAND_MEMORG (1 ,2048 ,128 ,64 ,2048 ,80 ,2 ,1 ,2 ), +NAND_ECCREQ (8 ,512 ), +SPINAND_INFO_OP_VARIANTS (&read_cache_variants, + &write_cache_variants, + &update_cache_variants), +0 , +SPINAND_ECCINFO (µn_8_ooblayout, + micron_8_ecc_get_status), +SPINAND_SELECT_TARGET (micron_select_target)), +/* M70A 4Gb 3.3V */ +SPINAND_INFO ("MT29F4G01ABAFD" ,0x34 , +NAND_MEMORG (1 ,4096 ,256 ,64 ,2048 ,40 ,1 ,1 ,1 ), +NAND_ECCREQ (8 ,512 ), +SPINAND_INFO_OP_VARIANTS (&read_cache_variants, + &write_cache_variants, + &update_cache_variants), +0 , +SPINAND_ECCINFO (µn_8_ooblayout, + micron_8_ecc_get_status)), +/* M70A 4Gb 1.8V */ +SPINAND_INFO ("MT29F4G01ABBFD" ,0x35 , +NAND_MEMORG (1 ,4096 ,256 ,64 ,2048 ,40 ,1 ,1 ,1 ), +NAND_ECCREQ (8 ,512 ), +SPINAND_INFO_OP_VARIANTS (&read_cache_variants, + &write_cache_variants, + &update_cache_variants), +0 , +SPINAND_ECCINFO (µn_8_ooblayout, + micron_8_ecc_get_status)), +/* M70A 8Gb 3.3V */ +SPINAND_INFO ("MT29F8G01ADAFD" ,0x46 , +NAND_MEMORG (1 ,4096 ,256 ,64 ,2048 ,40 ,1 ,1 ,2 ), +NAND_ECCREQ (8 ,512 ), +SPINAND_INFO_OP_VARIANTS (&read_cache_variants, + &write_cache_variants, + &update_cache_variants), +0 , +SPINAND_ECCINFO (µn_8_ooblayout, + micron_8_ecc_get_status), +SPINAND_SELECT_TARGET (micron_select_target)), +/* M70A 8Gb 1.8V */ +SPINAND_INFO ("MT29F8G01ADBFD" ,0x47 , +NAND_MEMORG (1 ,4096 ,256 ,64 ,2048 ,40 ,1 ,1 ,2 ), +NAND_ECCREQ (8 ,512 ), +SPINAND_INFO_OP_VARIANTS (&read_cache_variants, + &write_cache_variants, + &update_cache_variants), +0 , +SPINAND_ECCINFO (µn_8_ooblayout, + micron_8_ecc_get_status), + SPINAND_SELECT_TARGET(micron_select_target)), };static int micron_spinand_detect (struct spinand_device *spinand)
@@ -122,8 +218,19 @@ static int micron_spinand_detect(struct spinand_device *spinand)return 1 ; } +static int micron_spinand_init (struct spinand_device *spinand) +{ +/* +* M70A series device enables Continuos Read feature on Power-up, +* which is not supported here. Making this BIT disable will avoid +* any possible failure. +*/ +return spinand_upd_cfg (spinand,CFG_QUAD_ENABLE ,0 ); +} +static const struct spinand_manufacturer_ops micron_spinand_manuf_ops = { .detect = micron_spinand_detect, + .init = micron_spinand_init, };const struct spinand_manufacturer micron_spinand_manufacturer = {
Signature · 1 line
2.17.1
Miquel Raynal
maintainerRe: [PATCH 1/1] mtd: spinand: Add support for new Micron SPI NAND devices
Hi Shiva,
[email protected] wrote on Mon, 9 Dec 2019 07:42:23 +0100:
Quoted 5 lines
From: Shivamurthy Shastri <[email protected]>
Add device table for new Micron SPI NAND devices. While at it, add support to the multi-die selection. Also, generalize the OOB layout structure and function names.
Sorry for the delay. I am fine with this patch mostly, but could we split it please?
O/ Disable continuous read feature (one typo, see below). I think this might be considered as a fix.
1/ Generalize the OOB layout structure and function names. 2/ Add support for all the parts.
3/ Add multi-die support (one comment below about that).
As a general rule of thumb, small patches, doing one logic change are much easier and quick to review and accept.
drivers/mtd/nand/spi/micron.c static int mt29f2g01abagd_ecc_get_status(struct spinand_device *spinand, · line 100
Quoted 8 lines
drivers/mtd/nand/spi/micron.c +8
-0+static int micron_select_target (struct spinand_device *spinand, +unsigned int target) +{ +struct spi_mem_op op =SPINAND_SET_FEATURE_OP (0xd0 , + spinand->scratchbuf); + +if (target ==1 ) + *spinand->scratchbuf =0x40 ;
Please define 0x40 and explain clearly with a comment that this is multi-die selection.
Quoted 4 lines
drivers/mtd/nand/spi/micron.c +4
-0+ +return spi_mem_exec_op (spinand->spimem, &op); +} +
[...]
drivers/mtd/nand/spi/micron.c static int micron_spinand_detect(struct spinand_device *spinand) · line 226
Quoted 6 lines
drivers/mtd/nand/spi/micron.c +6
-0+static int micron_spinand_init (struct spinand_device *spinand) +{ +/* +* M70A series device enables Continuos Read feature on Power-up, +* which is not supported here. Making this BIT disable will avoid +* any possible failure.
What about:
M70A device series enable Continuous Read feature at power-up, which is not supported. Disable this bit to avoid any possible failure.
drivers/mtd/nand/spi/micron.c static int micron_spinand_detect(struct spinand_device *spinand) · line 236
Quoted 10 lines
drivers/mtd/nand/spi/micron.c +5
-0+*/ +return spinand_upd_cfg (spinand,CFG_QUAD_ENABLE ,0 ); +} +static const struct spinand_manufacturer_ops micron_spinand_manuf_ops = { .detect = micron_spinand_detect, + .init = micron_spinand_init, };const struct spinand_manufacturer micron_spinand_manufacturer = {
Thanks,
Miquèl