ASoC: txx9: Remove unused rtd variable
PATCH 1/1 ASoC: txx9: Remove unused rtd variable
Commit a857e073ffc6 ("ASoC: txx9: txx9aclc: remove snd_pcm_ops") removed the last use of the rtd variable but didn't remove its definition, leading to the following warning/error for MIPS rbtx49xx_defconfig builds:
sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_hw_params':sound/soc/txx9/txx9aclc.c:54:30: error: unused variable 'rtd'
[-Werror=unused-variable]
struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);
^~~Resolve this by removing the unused variable.
--- sound/soc/txx9/txx9aclc.c | 1 - 1 file changed, 1 deletion(-)
sound/soc/txx9/txx9aclc.c +0 -1
@@ -51,7 +51,6 @@ static int txx9aclc_pcm_hw_params(struct snd_soc_component *component,struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { - struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream); struct snd_pcm_runtime *runtime = substream->runtime;struct txx9aclc_dmadata *dmadata = runtime->private_data;int ret;
Signature · 6 lines
2.24.1 _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Hi
Quoted 21 lines
Commit
a857e073ffc6("ASoC: txx9: txx9aclc: removesnd_pcm_ops") removed the last use of the rtd variable but didn't remove its definition, leading to the following warning/error for MIPSrbtx49xx_defconfigbuilds:
sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_hw_params':sound/soc/txx9/txx9aclc.c:54:30: error: unused variable 'rtd'
[-Werror=unused-variable]struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream); ^~~Resolve this by removing the unused variable.
Signed-off-by Paul Burton <[email protected]>Fixes a857e073ffc6 ("ASoC: txx9: txx9aclc: remove snd_pcm_ops")Cc Kuninori Morimoto <[email protected]>Cc Mark Brown <[email protected]>Cc Liam Girdwood <[email protected]>Cc Jaroslav Kysela <[email protected]>Cc Takashi Iwai <[email protected]>
Quoted 1 line
---
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Mark Brown
maintainer[alsa-devel] Applied "ASoC: txx9: Remove unused rtd variable" to the asoc tree
In reply to Paul BurtonThe patch
ASoC: txx9: Remove unused rtd variable
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.6
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
From ec0f6a4c4a987aa20b2e77e0db2ae555276e45e6 Mon Sep 17 00:00:00 2001
From: Paul Burton <[email protected]>
Date: Thu, 9 Jan 2020 11:14:22 -0800
Subject: [PATCH] ASoC: txx9: Remove unused rtd variable
Commit a857e073ffc6 ("ASoC: txx9: txx9aclc: remove snd_pcm_ops") removed the last use of the rtd variable but didn't remove its definition, leading to the following warning/error for MIPS rbtx49xx_defconfig builds:
sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_hw_params':sound/soc/txx9/txx9aclc.c:54:30: error: unused variable 'rtd'
[-Werror=unused-variable]
struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream);
^~~Resolve this by removing the unused variable.
--- sound/soc/txx9/txx9aclc.c | 1 - 1 file changed, 1 deletion(-)
sound/soc/txx9/txx9aclc.c +0 -1
@@ -51,7 +51,6 @@ static int txx9aclc_pcm_hw_params(struct snd_soc_component *component,struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params) { - struct snd_soc_pcm_runtime *rtd = snd_pcm_substream_chip(substream); struct snd_pcm_runtime *runtime = substream->runtime;struct txx9aclc_dmadata *dmadata = runtime->private_data;
Signature · 6 lines
2.20.1 _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel