Skip to contentSkip to conversation

mlx4: Bump up MAX_MSIX from 64 to 128

PATCH Applied Jonathan Lemon 6 participants 8 messages Jan 9, 2020 – Jan 13, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mlx4: Bump up MAX_MSIX from 64 to 128

On modern hardware with a large number of cpus and using XDP, the current MSIX limit is insufficient. Bump the limit in order to allow more queues.

---
 include/linux/mlx4/device.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/mlx4/device.h +1 -1
index 36e412c3d657..20372de0b587 100644
@@ -47,7 +47,7 @@
 #define DEFAULT_UAR_PAGE_SHIFT  12
 
 #define MAX_MSIX_P_PORT		17
-#define MAX_MSIX		64
+#define MAX_MSIX		128
 #define MIN_MSIX_P_PORT		5
 #define MLX4_IS_LEGACY_EQ_MODE(dev_cap) ((dev_cap).num_comp_vectors < \
 					 (dev_cap).num_ports * MIN_MSIX_P_PORT)
Signature · 1 line
2.17.1
#5 lore raw
Quoted 11 lines · Jakub Kicinski
Quoted 5 lines · Jonathan Lemon

On modern hardware with a large number of cpus and using XDP, the current MSIX limit is insufficient. Bump the limit in order to allow more queues.

Applied to net-next, thanks everyone!

(Jack, please make sure you spell your tags right)

Checked, It's correct both in my reply and in net-next.git.

Thanks,
Jack Wang

#6 lore raw
Quoted 6 lines · Jinpu Wang
Quoted 5 lines · Jakub Kicinski
Quoted 4 lines · Jonathan Lemon

On modern hardware with a large number of cpus and using XDP, the current MSIX limit is insufficient. Bump the limit in order to allow more queues.

Quoted 6 lines
Quoted 5 lines
Quoted 1 line

Applied to net-next, thanks everyone!

(Jack, please make sure you spell your tags right)

Checked, It's correct both in my reply and in net-next.git.

I manually corrected it in tree. You swapped 'i' and 'e' in the word reviewed, your email had "reveiwed".

#7 lore raw
Quoted 10 lines · Jakub Kicinski
Quoted 8 lines · Jinpu Wang
Quoted 7 lines · Jakub Kicinski
Quoted 5 lines · Jonathan Lemon

On modern hardware with a large number of cpus and using XDP, the current MSIX limit is insufficient. Bump the limit in order to allow more queues.

Quoted 7 lines
Quoted 4 lines
Quoted 3 lines

Applied to net-next, thanks everyone!

(Jack, please make sure you spell your tags right)

Checked, It's correct both in my reply and in net-next.git.

I manually corrected it in tree. You swapped 'i' and 'e' in the word reviewed, your email had "reveiwed".

oh, sorry for that, will be more careful next time. And thanks for the correction.