Skip to contentSkip to conversation

x86: edison: Enable command line editing

PATCH New Andy Shevchenko 4 participants 11 messages Jan 9, 2020 – Feb 3, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 x86: edison: Enable command line editing

From: Marek Vasut <[email protected]>

Enable command line editing, because it is extremely convenient.

---
 configs/edison_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/edison_defconfig +0 -1
index 14b2eec3ba..124f0f628f 100644
@@ -9,7 +9,6 @@ CONFIG_SMP=y
 CONFIG_BOARD_EARLY_INIT_R=y
 CONFIG_LAST_STAGE_INIT=y
 CONFIG_HUSH_PARSER=y
-# CONFIG_CMDLINE_EDITING is not set
 CONFIG_CMD_CPU=y
 CONFIG_CMD_ASKENV=y
 CONFIG_CMD_GREPENV=y
Signature · 1 line
2.24.1
#1 lore raw

PATCH 2/2 x86: edison: Switch to ACPI mode

SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.

Enable a necessary minimum to use ACPI on Intel Edison.

Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.

Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.

---
 configs/edison_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/edison_defconfig +1 -0
index 124f0f628f..58707d619a 100644
@@ -6,6 +6,7 @@ CONFIG_NR_DRAM_BANKS=3
 CONFIG_VENDOR_INTEL=y
 CONFIG_TARGET_EDISON=y
 CONFIG_SMP=y
+CONFIG_GENERATE_ACPI_TABLE=y
 CONFIG_BOARD_EARLY_INIT_R=y
 CONFIG_LAST_STAGE_INIT=y
 CONFIG_HUSH_PARSER=y
Signature · 1 line
2.24.1
#2 lore raw

PATCH 2/2 x86: edison: Switch to ACPI mode

Quoted 10 lines · Andy Shevchenko

SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.

Enable a necessary minimum to use ACPI on Intel Edison.

Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.

Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.

Bin, Simon, can we get these into 2020.04?

Quoted 20 lines
---
 configs/edison_defconfig | 1 +
 1 file changed, 1 insertion(+)
configs/edison_defconfig +1 -0
index 124f0f628f..58707d619a 100644
@@ -6,6 +6,7 @@ CONFIG_NR_DRAM_BANKS=3
 CONFIG_VENDOR_INTEL=y
 CONFIG_TARGET_EDISON=y
 CONFIG_SMP=y
+CONFIG_GENERATE_ACPI_TABLE=y
 CONFIG_BOARD_EARLY_INIT_R=y
 CONFIG_LAST_STAGE_INIT=y
 CONFIG_HUSH_PARSER=y
Signature · 1 line
2.24.1
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

PATCH 2/2 x86: edison: Switch to ACPI mode

Quoted 7 lines · Andy Shevchenko
Quoted 5 lines · Andy Shevchenko

SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.

Enable a necessary minimum to use ACPI on Intel Edison.

Quoted 7 lines
Quoted 5 lines

Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.

Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.

Bin, Simon, can we get these into 2020.04?

+Tom Rini FYI

I hope so. There's a small mountain of pending x86 patches. I think Bin is probably away until next week?

- Simon

#4 lore raw

PATCH 2/2 x86: edison: Switch to ACPI mode

Quoted 16 lines · Simon Glass
Quoted 13 lines · Andy Shevchenko
Quoted 10 lines · Andy Shevchenko

SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.

Enable a necessary minimum to use ACPI on Intel Edison.

Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.

Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.

Quoted 8 lines
Quoted 1 line

Bin, Simon, can we get these into 2020.04?

+Tom Rini FYI

I hope so. There's a small mountain of pending x86 patches. I think Bin is probably away until next week?

I was off for the Chinese new year holiday vacation, and there was the 2019-nCov epidemic situation going on that further delayed things :(

I will pick up patches that make sense for v2020.04 release.

Regards,
Bin

#5 lore raw

PATCH 2/2 x86: edison: Switch to ACPI mode

Quoted 1 line · Bin Meng

On Thu, Jan 30, 2020 at 10:17 AM Simon Glass <[email protected]> wrote:

...

Quoted 2 lines

and there was the
2019-nCov epidemic situation going on that further delayed things :(

Oh, hope you are doing well!

Quoted 1 line

I will pick up patches that make sense for v2020.04 release.

Thanks!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw

PATCH 2/2 x86: edison: Switch to ACPI mode

In reply to Andy Shevchenko
Quoted 9 lines · Andy Shevchenko

SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.

Enable a necessary minimum to use ACPI on Intel Edison.

Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.

Quoted 8 lines

Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.

---
 configs/edison_defconfig | 1 +
 1 file changed, 1 insertion(+)
#7 lore raw

PATCH 2/2 x86: edison: Switch to ACPI mode

Quoted 15 lines · Bin Meng
Quoted 12 lines · Andy Shevchenko

SFI is quite poor and useless resource provider. Moreover it makes hard to develop and extend functionality in the Linux kernel.

Enable a necessary minimum to use ACPI on Intel Edison.

Linux kernel have been prepared for this change since v5.4, where the last crucial driver, i.e. for Basin Cove PMIC, has been submitted.

Note, that stock image won't suffer by this change since it doesn't have ACPI enabled on the kernel level.

Quoted 7 lines
Quoted 5 lines
---
 configs/edison_defconfig | 1 +
 1 file changed, 1 insertion(+)

applied to u-boot-x86, thanks!

#10 lore raw

PATCH 1/2 x86: edison: Enable command line editing

Quoted 8 lines · Bin Meng
Quoted 5 lines · Andy Shevchenko

From: Marek Vasut <[email protected]>

Enable command line editing, because it is extremely convenient.

Quoted 8 lines
Quoted 6 lines
---
 configs/edison_defconfig | 1 -
 1 file changed, 1 deletion(-)

applied to u-boot-x86, thanks!