mm/huge_memory.c: reduce critical section protected by split_queue_lock
Subsystems (2)
PATCH 1/1 mm/huge_memory.c: reduce critical section protected by split_queue_lock
split_queue_lock protects data in struct deferred_split. We can release the lock after delete the page from deferred_split_queue.
This patch moves the THP accounting out of the lock protection, which is introduced in commit 65c453778aea ("mm, rmap: account shmem thp pages").
Signed-off-by Wei Yang <[email protected]>
--- mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
mm/huge_memory.c +1 -1
@@ -2810,6 +2810,7 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) ds_queue->split_queue_len--;list_del (page_deferred_list (head)); } +spin_unlock (&ds_queue->split_queue_lock);if (mapping) {if (PageSwapBacked (head))__dec_node_page_state (head,NR_SHMEM_THPS );
@@ -2817,7 +2818,6 @@ int split_huge_page_to_list(struct page *page, struct list_head *list)__dec_node_page_state (head,NR_FILE_THPS ); } -spin_unlock (&ds_queue->split_queue_lock);__split_huge_page (page, list, end, flags);if (PageSwapCache (head)) {swp_entry_t entry = { .val =page_private (head) };
Signature · 1 line
2.17.1
Quoted 7 lines · Wei Yang
split_queue_lockprotects data in structdeferred_split. We can release the lock after delete the page fromdeferred_split_queue.This patch moves the THP accounting out of the lock protection, which is introduced in commit
65c453778aea("mm, rmap: account shmem thp pages").Signed-off-by Wei Yang <[email protected]>
Signature · 1 line
Kirill A. Shutemov