Skip to contentSkip to conversation

Add Unisoc's SC9863A support

PATCH In review Chunyan Zhang 2 participants 8 messages Jan 10, 2020 – Jan 17, 2020

Subsystems (2)
lore
Share & tools
lore

Chunyan Zhang

author reviewer
#0 lore raw

v6 cover Add Unisoc's SC9863A support

SC9863A has Octa-core ARM Cortex A55 application processor. Find more details about it on the website: http://www.unisoc.com/sc9863a

Changes from v5:
* Discarded .../bindings/arm/sprd/global-regs.yaml which will be added back when adding syscon into sc9863a devicetree.

Changes from v4:
* Removed syscon nodes which should be added when used.
* Added Acked-by from Rob Herring.

Changes from v3:
* Rebased on v5.5-rc1;
* Fix the cpu-map to put all cpus into the single cluster;
* Fixed a bindings error.

Changes from v2:
* Discard some dt-bindings patches which have been applied by Rob Herring.
* Added a new dt-binding file for sprd global-regs, also added a vendor directory for sprd.
* Moved sprd.yaml to the vendor directory.
* Addressed comments from Rob:
- fixed dtbs_check errors;
- move gic under to the bus node;
- removed msi-controller from gic, sinceSC9863A doesn't provide ITS;
- added specific compatible string for syscon nodes;
- cut down registers range of syscon nodes;
- removed unnecessary property "sprd,sc-id";
- added earlycon support in devicetree.

Changes from v1:
- Convert DT bindings to json-schema.

Chunyan Zhang (2):
dt-bindings: arm: move sprd board file to vendor directory
arm64: dts: Add Unisoc's SC9863A SoC support

 .../bindings/arm/{ => sprd}/sprd.yaml         |   2 +-
 arch/arm64/boot/dts/sprd/Makefile             |   3 +-
 arch/arm64/boot/dts/sprd/sc9863a.dtsi         | 523 ++++++++++++++++++
 arch/arm64/boot/dts/sprd/sharkl3.dtsi         |  78 +++
 arch/arm64/boot/dts/sprd/sp9863a-1h10.dts     |  39 ++
 5 files changed, 643 insertions(+), 2 deletions(-)
 rename Documentation/devicetree/bindings/arm/{ => sprd}/sprd.yaml (92%)
 create mode 100644 arch/arm64/boot/dts/sprd/sc9863a.dtsi
 create mode 100644 arch/arm64/boot/dts/sprd/sharkl3.dtsi
 create mode 100644 arch/arm64/boot/dts/sprd/sp9863a-1h10.dts
Signature · 1 line
2.20.1
author reviewer
#1 lore raw

PATCH v6 1/2 dt-bindings: arm: move sprd board file to vendor directory

From: Chunyan Zhang <[email protected]>

We've created a vendor directory for sprd, so move the board bindings to there.

---
 Documentation/devicetree/bindings/arm/{ => sprd}/sprd.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename Documentation/devicetree/bindings/arm/{ => sprd}/sprd.yaml (92%)
Documentation/devicetree/bindings/arm/sprd/sprd.yaml renamed from Documentation/devicetree/bindings/arm/sprd.yaml +1 -1
similarity index 92%
rename from Documentation/devicetree/bindings/arm/sprd.yaml
rename to Documentation/devicetree/bindings/arm/sprd/sprd.yaml
index c35fb845ccaa..0258a96bfbde 100644
@@ -2,7 +2,7 @@
 # Copyright 2019 Unisoc Inc.
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/arm/sprd.yaml#
+$id: http://devicetree.org/schemas/arm/sprd/sprd.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Unisoc platforms device tree bindings
Signature · 1 line
2.20.1
author reviewer
#2 lore raw

PATCH v6 2/2 arm64: dts: Add Unisoc's SC9863A SoC support

In reply to Chunyan Zhang

From: Chunyan Zhang <[email protected]>

Add basic DT to support Unisoc's SC9863A, with this patch, the board sp9863a-1h10 can run into console.

---
 arch/arm64/boot/dts/sprd/Makefile         |   3 +-
 arch/arm64/boot/dts/sprd/sc9863a.dtsi     | 523 ++++++++++++++++++++++
 arch/arm64/boot/dts/sprd/sharkl3.dtsi     |  78 ++++
 arch/arm64/boot/dts/sprd/sp9863a-1h10.dts |  39 ++
 4 files changed, 642 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/sprd/sc9863a.dtsi
 create mode 100644 arch/arm64/boot/dts/sprd/sharkl3.dtsi
 create mode 100644 arch/arm64/boot/dts/sprd/sp9863a-1h10.dts
arch/arm64/boot/dts/sprd/Makefile +2 -1
index 2bdc23804f40..f4f1f5148cc2 100644
@@ -1,3 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0
 dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \
-			sp9860g-1h10.dtb
+			sp9860g-1h10.dtb	\
+			sp9863a-1h10.dtb
arch/arm64/boot/dts/sprd/sc9863a.dtsi new file +523 -0

523 lines not on this page · raw message

arch/arm64/boot/dts/sprd/sharkl3.dtsi new file +78 -0

78 lines not on this page · raw message

arch/arm64/boot/dts/sprd/sp9863a-1h10.dts new file +39 -0
new file mode 100644
index 000000000000..5c32c1596337
@@ -0,0 +1,39 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Unisoc SP9863A-1h10 boards DTS file
+ *
+ * Copyright (C) 2019, Unisoc Inc.
+ */
+
+/dts-v1/;
+
+#include "sc9863a.dtsi"
+
+/ {
+	model = "Spreadtrum SP9863A-1H10 Board";
+
+	compatible = "sprd,sp9863a-1h10", "sprd,sc9863a";
+
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+	};
+
+	memory@80000000 {
+		device_type = "memory";
+		reg = <0x0 0x80000000 0x0 0x80000000>;
+	};
+
+	chosen {
+		stdout-path = "serial1:115200n8";
+		bootargs = "earlycon";
+	};
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
Signature · 1 line
2.20.1
#3 lore raw

Re: [PATCH v6 2/2] arm64: dts: Add Unisoc's SC9863A SoC support

Hi,

Quoted 7 lines · Chunyan Zhang

From: Chunyan Zhang <[email protected]>

Add basic DT to support Unisoc's SC9863A, with this patch, the board sp9863a-1h10 can run into console.

You reposting a patch that we have already applied, and there's also no changelog for it in the description.

If you need to change the contents to fix something, you need to send a patch for the delta by now, with the usual expectations of explaining why the fix is needed, etc.

Thanks,

-Olof

author reviewer
#4 lore raw

Re: [PATCH v6 2/2] arm64: dts: Add Unisoc's SC9863A SoC support

Quoted 7 lines · Olof Johansson

Hi,

Quoted 3 lines · Chunyan Zhang

From: Chunyan Zhang <[email protected]>

Quoted 7 lines
Quoted 4 lines

Add basic DT to support Unisoc's SC9863A, with this patch, the board sp9863a-1h10 can run into console.

You reposting a patch that we have already applied, and there's also no changelog for it in the description.

Oh, I have to explain a bit.

I was expecting an email which inform me that the patch was got merged. That's the reason I resent this patchset.

About the changelog, this new patchset actually had a cover-letter[1] in which I documented a little changes (which was not important now).

Thanks for your help,
Chunyan

[1] https://lkml.org/lkml/2020/1/10/36

Quoted 9 lines

If you need to change the contents to fix something, you need to send a patch for the delta by now, with the usual expectations of explaining why the fix is needed, etc.

Thanks,

-Olof

#5 lore raw

Re: [PATCH v6 2/2] arm64: dts: Add Unisoc's SC9863A SoC support

Quoted 14 lines · Chunyan Zhang
Quoted 12 lines · Olof Johansson

Hi,

Quoted 7 lines · Chunyan Zhang

From: Chunyan Zhang <[email protected]>

Add basic DT to support Unisoc's SC9863A, with this patch, the board sp9863a-1h10 can run into console.

Quoted 7 lines
Quoted 2 lines

You reposting a patch that we have already applied, and there's also no changelog for it in the description.

Oh, I have to explain a bit.

I was expecting an email which inform me that the patch was got merged. That's the reason I resent this patchset.

Ah, yes -- me too. This was a combination of two things:

1) The patch was originally sent to [email protected], not [email protected]
2) I bounced it to there to apply it using PatchWork

... but, it seems that the bot won't reply to patches that have been bounced, only those who were originally sent there.

In this case, I should have made a manual reply -- I've gotten too used to the bot and relied on it doing it.

Quoted 2 lines

About the changelog, this new patchset actually had a cover-letter[1] in which I documented a little changes (which was not important now).

Not sure why, but I seem to have missed it. Maybe because it was 3 patches on v5, and I didn't notice that one was now a cover letter. Anyway, all good.

I'll also apply 1/2 shortly.

-Olof

#6 lore raw

Re: [PATCH v6 2/2] arm64: dts: Add Unisoc's SC9863A SoC support

Quoted 35 lines · Olof Johansson
Quoted 14 lines · Chunyan Zhang
Quoted 12 lines · Olof Johansson

Hi,

Quoted 7 lines · Chunyan Zhang

From: Chunyan Zhang <[email protected]>

Add basic DT to support Unisoc's SC9863A, with this patch, the board sp9863a-1h10 can run into console.

Quoted 7 lines
Quoted 2 lines

You reposting a patch that we have already applied, and there's also no changelog for it in the description.

Oh, I have to explain a bit.

I was expecting an email which inform me that the patch was got merged. That's the reason I resent this patchset.

Ah, yes -- me too. This was a combination of two things:

1) The patch was originally sent to [email protected], not [email protected]
2) I bounced it to there to apply it using PatchWork

... but, it seems that the bot won't reply to patches that have been bounced, only those who were originally sent there.

In this case, I should have made a manual reply -- I've gotten too used to the bot and relied on it doing it.

Quoted 8 lines
Quoted 2 lines

About the changelog, this new patchset actually had a cover-letter[1] in which I documented a little changes (which was not important now).

Not sure why, but I seem to have missed it. Maybe because it was 3 patches on v5, and I didn't notice that one was now a cover letter. Anyway, all good.

I'll also apply 1/2 shortly.

I'm ahead of myself, it's already applied as well.

-Olof

author reviewer
#7 lore raw

Re: [PATCH v6 2/2] arm64: dts: Add Unisoc's SC9863A SoC support

Quoted 40 lines · Olof Johansson
Quoted 38 lines · Olof Johansson
Quoted 14 lines · Chunyan Zhang
Quoted 12 lines · Olof Johansson

Hi,

Quoted 7 lines · Chunyan Zhang

From: Chunyan Zhang <[email protected]>

Add basic DT to support Unisoc's SC9863A, with this patch, the board sp9863a-1h10 can run into console.

Quoted 7 lines
Quoted 2 lines

You reposting a patch that we have already applied, and there's also no changelog for it in the description.

Oh, I have to explain a bit.

I was expecting an email which inform me that the patch was got merged. That's the reason I resent this patchset.

Ah, yes -- me too. This was a combination of two things:

1) The patch was originally sent to [email protected], not [email protected]
2) I bounced it to there to apply it using PatchWork

... but, it seems that the bot won't reply to patches that have been bounced, only those who were originally sent there.

In this case, I should have made a manual reply -- I've gotten too used to the bot and relied on it doing it.

Quoted 2 lines

About the changelog, this new patchset actually had a cover-letter[1] in which I documented a little changes (which was not important now).

Quoted 8 lines
Quoted 5 lines

Not sure why, but I seem to have missed it. Maybe because it was 3 patches on v5, and I didn't notice that one was now a cover letter. Anyway, all good.

I'll also apply 1/2 shortly.

I'm ahead of myself, it's already applied as well.

Thank you very much!
Chunyan

FYI:
The patchset v5 seems also NOT sent to [email protected], it was accurately sent to [email protected] :-)
https://patchwork.ozlabs.org/cover/1214863/