drm/virtio: add missing virtio_gpu_array_lock_resv call
Subsystems (4)
Gerd Hoffmann
maintainerPATCH 1/1 drm/virtio: add missing virtio_gpu_array_lock_resv call
When submitting a fenced command we must lock the object reservations because virtio_gpu_queue_fenced_ctrl_buffer() unlocks after adding the fence.
--- drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/virtio/virtgpu_plane.c +1 -0
@@ -232,6 +232,7 @@ static void virtio_gpu_cursor_plane_update(struct drm_plane *plane,if (!objs)return ;virtio_gpu_array_add_obj (objs, vgfb->base.obj[0 ]); +virtio_gpu_array_lock_resv (objs); virtio_gpu_cmd_transfer_to_host_2d (vgdev, 0, plane->state->crtc_w,
Signature · 6 lines
2.18.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 3 lines · Gerd Hoffmann
When submitting a fenced command we must lock the object reservations because
virtio_gpu_queue_fenced_ctrl_buffer()unlocks after adding the fence.
Thanks a lot! With this patch applied, my VM doesn't throw lockdep warnings anymore. If you want, you can add:
Quoted 5 lines
Reported-by Jann Horn <[email protected]>Signed-off-by Gerd Hoffmann <[email protected]>--- drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines · Jann Horn
Quoted 3 lines · Gerd Hoffmann
When submitting a fenced command we must lock the object reservations because
virtio_gpu_queue_fenced_ctrl_buffer()unlocks after adding the fence.Thanks a lot! With this patch applied, my VM doesn't throw lockdep warnings anymore. If you want, you can add:
Tested-by Jann Horn <[email protected]>Quoted 2 lines
Reported-by Jann Horn <[email protected]>Signed-off-by Gerd Hoffmann <[email protected]>
Quoted 3 lines
Quoted 3 lines
--- drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+)
Quoted 13 lines · Jann Horn
Quoted 3 lines · Gerd Hoffmann
When submitting a fenced command we must lock the object reservations because
virtio_gpu_queue_fenced_ctrl_buffer()unlocks after adding the fence.Thanks a lot! With this patch applied, my VM doesn't throw lockdep warnings anymore. If you want, you can add:
Tested-by Jann Horn <[email protected]>Quoted 2 lines
Reported-by Jann Horn <[email protected]>Signed-off-by Gerd Hoffmann <[email protected]>
Quoted 3 lines
Quoted 3 lines
--- drivers/gpu/drm/virtio/virtgpu_plane.c | 1 + 1 file changed, 1 insertion(+)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel