Skip to contentSkip to conversation

imsm: Disable --dump/--restore options

PATCH In review Blazej Kucman 2 participants 2 messages Jan 10, 2020 – Jan 16, 2020 MD RAID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imsm: Disable --dump/--restore options

Currently --dump/--restore are not working correctly. Temporarily disable this functionally for IMSM to avoid unexpected behaviors and side effects.

---
 super-intel.c | 7 +++++++
 1 file changed, 7 insertions(+)
super-intel.c +7 -0
index 5c1f759f..b2a4528d 100644
@@ -2130,6 +2130,13 @@ static void export_examine_super_imsm(struct supertype *st)
 
 static int copy_metadata_imsm(struct supertype *st, int from, int to)
 {
+	/*
+	 * Disable this functionality for IMSM,
+	 * since it is not working correctly.
+	 */
+	pr_err("--dump/--restore is not supported for IMSM metadata format.\n");
+	return 1;
+
 	/* The second last sector of the device contains
 	 * the "struct imsm_super" metadata.
 	 * This contains mpb_size which is the size in bytes of the
Signature · 1 line
2.16.4
#1 lore raw
Quoted 5 lines · Blazej Kucman

Currently --dump/--restore are not working correctly. Temporarily disable this functionally for IMSM to avoid unexpected behaviors and side effects.

I dislike leaving the code in there dead, especially as it's not clear when this will get fixed.

Should we just remove it, or do you have plans to fix this in the near future?

Thanks,
Jes