Skip to contentSkip to conversation

package/snort: needs zlib

PATCH New Peter Seiderer 2 participants 6 messages Jan 10, 2020 – Jan 11, 2020

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/snort: needs zlib

Fixes:

checking zlib.h usability... no
checking zlib.h presence... no
checking for zlib.h... no

ERROR! zlib header not found, go get it from
http://www.zlib.net

---
 package/snort/Config.in | 1 +
 package/snort/snort.mk  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)
package/snort/Config.in +1 -0
index 7d2c52c3f3..fc74efcfed 100644
@@ -9,6 +9,7 @@ config BR2_PACKAGE_SNORT
 	select BR2_PACKAGE_DAQ
 	select BR2_PACKAGE_PCRE
 	select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
+	select BR2_PACKAGE_ZLIB
 	help
 	  Snort is a free and open source network intrusion
 	  prevention system (IPS) and network intrusion detection
package/snort/snort.mk +1 -1
index 024c94162b..4006d176bf 100644
@@ -9,7 +9,7 @@ SNORT_SITE = https://www.snort.org/downloads/snort
 SNORT_LICENSE = GPL-2.0
 SNORT_LICENSE_FILES = LICENSE COPYING
 
-SNORT_DEPENDENCIES = libpcap libdnet daq pcre host-pkgconf
+SNORT_DEPENDENCIES = libpcap libdnet daq pcre zlib host-pkgconf
 
 # patching configure.in
 SNORT_AUTORECONF = YES
Signature · 1 line
2.24.1
#1 lore raw

PATCH 2/2 package/snort: bump version to 2.9.15.1

Fixes:
- http://autobuild.buildroot.net/results/17802b5ad87f494a86d158f2547e68edddcc0a68

../../src/util.h:377:21: error: static declaration of 'gettid' follows non-static declaration
static inline pid_t gettid(void)

                       ^~~~~~
  In file included from .../host/aarch64-buildroot-linux-gnu/sysroot/usr/include/unistd.h:1170,
                   from .../host/aarch64-buildroot-linux-gnu/sysroot/usr/include/daq_common.h:25,
                   from .../host/aarch64-buildroot-linux-gnu/sysroot/usr/include/daq.h:26,
                   from ../../src/decode.h:48,
                   from ../../src/spo_plugbase.h:31,
                   from ../../src/snort.h:36,
                   from sfcontrol.c:37:
  .../host/aarch64-buildroot-linux-gnu/sysroot/usr/include/bits/unistd_ext.h:34:16: note: previous declaration of 'gettid' was here
   extern __pid_t gettid (void) __THROW;
                  ^~~~~~
---
 package/snort/snort.hash | 2 +-
 package/snort/snort.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/snort/snort.hash +1 -1
index 898840dadc..7364df1330 100644
@@ -1,5 +1,5 @@
 # Locally computed:
-sha256 bfb437746446ef72a03c501db13cd6da5edd2b41f55c80c437ba288be6da7dba  snort-2.9.15.tar.gz
+sha256 2cccfc1d1a706586cd47ae9f085a7d5e4e36390b8e9c28cd2020b4b5b587f6c3  snort-2.9.15.1.tar.gz
 
 # Hash for license files:
 sha256 f98260a6d3e5ef4ede8a2a6b698e5ac91d64c09243f7171e1c5b17b920a835c7  LICENSE
package/snort/snort.mk +1 -1
index 4006d176bf..0f1d6b13de 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-SNORT_VERSION = 2.9.15
+SNORT_VERSION = 2.9.15.1
 SNORT_SITE = https://www.snort.org/downloads/snort
 SNORT_LICENSE = GPL-2.0
 SNORT_LICENSE_FILES = LICENSE COPYING
Signature · 1 line
2.24.1
#2 lore raw

PATCH 1/2 package/snort: needs zlib

In reply to Peter Seiderer
Quoted 10 lines · On Fri, 10 Jan 2020 18:28:17 +0100 Peter Seiderer <[email protected]> wrote:

Fixes:

checking zlib.h usability... no
checking zlib.h presence... no
checking for zlib.h... no

ERROR! zlib header not found, go get it from
http://www.zlib.net

Since when is zlib needed? We've add the snort package for quite some time. Is it due to the bump to 2.9.15 in December ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/2 package/snort: needs zlib

Hello Thomas,

Quoted 9 lines · Thomas Petazzoni
Quoted 6 lines · On Fri, 10 Jan 2020 18:28:17 +0100 Peter Seiderer <[email protected]> wrote:

Fixes:

checking zlib.h usability... no
checking zlib.h presence... no
checking for zlib.h... no

Quoted 7 lines
Quoted 4 lines

ERROR! zlib header not found, go get it from
http://www.zlib.net

Since when is zlib needed? We've add the snort package for quite some time. Is it due to the bump to 2.9.15 in December ?

No, I think it is a side effect of 'package/libpcap: remove unnecessary dependency on zlib' ([1]) as snort selects/depends on libpcap...

Regards,
Peter

[1] https://git.buildroot.net/buildroot/commit/?id=fe4b9321e5ef3594776bba443d9718efd766f40e

Quoted 2 lines

Thomas

#4 lore raw

PATCH 1/2 package/snort: needs zlib

Quoted 14 lines · On Fri, 10 Jan 2020 22:38:37 +0100 Peter Seiderer <[email protected]> wrote:
Quoted 12 lines · Thomas Petazzoni
Quoted 9 lines · On Fri, 10 Jan 2020 18:28:17 +0100 Peter Seiderer <[email protected]> wrote:

Fixes:

checking zlib.h usability... no
checking zlib.h presence... no
checking for zlib.h... no

ERROR! zlib header not found, go get it from
http://www.zlib.net

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Since when is zlib needed? We've add the snort package for quite some time. Is it due to the bump to 2.9.15 in December ?

No, I think it is a side effect of 'package/libpcap: remove unnecessary dependency on zlib' ([1]) as snort selects/depends on libpcap...

Ah, yes, indeed.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

PATCH 1/2 package/snort: needs zlib

In reply to Peter Seiderer
Quoted 6 lines · On Fri, 10 Jan 2020 18:28:17 +0100 Peter Seiderer <[email protected]> wrote:

Fixes:

checking zlib.h usability... no
checking zlib.h presence... no
checking for zlib.h... no

Quoted 8 lines

ERROR! zlib header not found, go get it from
http://www.zlib.net

---
 package/snort/Config.in | 1 +
 package/snort/snort.mk  | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

Thanks, series applied. For PATCH 1/2, I've extended the commit log with more details.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com