netfilter: fix a use-after-free in mtype_destroy()
Subsystems (3)
PATCH 1/1 netfilter: fix a use-after-free in mtype_destroy()
map->members is freed by ip_set_free() right before using it in mtype_ext_cleanup() again. So we just have to move it down.
Reported-by [email protected]
Fixes 40cd63bf33b2 ("netfilter: ipset: Support extensions which need a per data destroy function")
Cc Pablo Neira Ayuso <[email protected]>
Acked-by Jozsef Kadlecsik <[email protected]>
Signed-off-by Cong Wang <[email protected]>
--- net/netfilter/ipset/ip_set_bitmap_gen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/ipset/ip_set_bitmap_gen.h +1 -1
@@ -60,9 +60,9 @@ mtype_destroy(struct ip_set *set)if (SET_WITH_TIMEOUT (set))del_timer_sync (&map->gc); -ip_set_free (map->members);if (set->dsize && set->extensions &IPSET_EXT_DESTROY )mtype_ext_cleanup (set); +ip_set_free (map->members);ip_set_free (map); set->data =NULL ;
Signature · 1 line
2.21.1
Quoted 2 lines · Cong Wang
map->membersis freed byip_set_free()right before using it inmtype_ext_cleanup()again. So we just have to move it down.
Applied, thanks.