Skip to contentSkip to conversation

drm/amdkfd: Fix a compiling warning

PATCH In review Yong Zhao 3 participants 3 messages Jan 11, 2020 – Jan 13, 2020

Subsystems (3)
lore
Share & tools
lore

Yong Zhao

author
#0 lore raw

PATCH 1/1 drm/amdkfd: Fix a compiling warning

The warning was introduced in

commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e

Author: Yong Zhao <[email protected]>
Date:   Fri Dec 13 11:31:48 2019 -0500

drm/amdkfd: Improve function get_sdma_rlc_reg_offset()

Change-Id I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c +1 -1
index 2b26925623eb..f9011a07cb90 100644
@@ -71,7 +71,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
 				unsigned int engine_id,
 				unsigned int queue_id)
 {
-	uint32_t sdma_engine_reg_base;
+	uint32_t sdma_engine_reg_base = 0;
 	uint32_t sdma_rlc_reg_offset;
 
 	switch (engine_id) {
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Yong Zhao

The warning was introduced in

commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e

Author: Yong Zhao <[email protected]>
Date:   Fri Dec 13 11:31:48 2019 -0500

drm/amdkfd: Improve function get_sdma_rlc_reg_offset()

Change-Id I87da4f1ad8a190327a4a71f0ff78812cb942d6e0

Instead of quoting the whole change description, the usual way to point to a prior patch that you're fixing is with a tag

Fixes <12 digits of sha1> ("commit title")

With that fixed, this patch is

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c +0 -0
index 2b26925623eb..f9011a07cb90 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev, · line 77

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c +1 -1
@@ -71,7 +71,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
  				unsigned int engine_id,
  				unsigned int queue_id)
  {
-	uint32_t sdma_engine_reg_base;
+	uint32_t sdma_engine_reg_base = 0;
  	uint32_t sdma_rlc_reg_offset;
 
  	switch (engine_id) {

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#2 lore raw
In reply to Yong Zhao

[AMD Official Use Only - Internal Distribution Only]

FWIW:
https://patchwork.freedesktop.org/patch/347923/

Alex

________________________________
From: amd-gfx <[email protected]> on behalf of Yong Zhao <[email protected]>
Sent: Friday, January 10, 2020 7:40 PM
To: [email protected] <[email protected]>
Cc: Zhao, Yong <[email protected]>
Subject: [PATCH] drm/amdkfd: Fix a compiling warning

The warning was introduced in

commit b4267f2e687ff5e0402ab915c9a4d47f9a4eb73e

Author: Yong Zhao <[email protected]>
Date:   Fri Dec 13 11:31:48 2019 -0500

drm/amdkfd: Improve function get_sdma_rlc_reg_offset()

Change-Id I87da4f1ad8a190327a4a71f0ff78812cb942d6e0
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_arcturus.c +1 -1
index 2b26925623eb..f9011a07cb90 100644
@@ -71,7 +71,7 @@ static uint32_t get_sdma_rlc_reg_offset(struct amdgpu_device *adev,
                                 unsigned int engine_id,
                                 unsigned int queue_id)
 {
-       uint32_t sdma_engine_reg_base;
+       uint32_t sdma_engine_reg_base = 0;
         uint32_t sdma_rlc_reg_offset;
 
         switch (engine_id) {

--
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=02%7C01%7Calexander.deucher%40amd.com%7C6428020902c0464fb20408d7962ee8c9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637143000578441842&amp;sdata=VP7%2FbA3lxSX2l9Hx2TySiChP4VKBch2SQRNOei2wElw%3D&amp;reserved=0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx